From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D821BC433EF for ; Tue, 7 Sep 2021 15:21:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD83761106 for ; Tue, 7 Sep 2021 15:21:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344920AbhIGPWH (ORCPT ); Tue, 7 Sep 2021 11:22:07 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:53386 "EHLO lizzard.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236041AbhIGPWH (ORCPT ); Tue, 7 Sep 2021 11:22:07 -0400 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 187FKnVP028526 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Sep 2021 17:20:49 +0200 Received: from [167.87.245.242] ([167.87.245.242]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 187FKmkV006563; Tue, 7 Sep 2021 17:20:48 +0200 Subject: Re: [PATCH 1/3] arm64: dts: ti: iot2050: Flip mmc device ordering on Advanced devices To: Nishanth Menon Cc: Tero Kristo , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bao Cheng Su , Chao Zeng References: <8e2e435ef67868cb98382b44c51ddb5c8d045d66.1631024536.git.jan.kiszka@siemens.com> <20210907151301.7fqwmc7hmcyhhybv@carve> From: Jan Kiszka Message-ID: <35e0cadf-526c-6402-fb8e-8cdb8b7a0bfe@siemens.com> Date: Tue, 7 Sep 2021 17:20:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210907151301.7fqwmc7hmcyhhybv@carve> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07.09.21 17:13, Nishanth Menon wrote: > On 16:22-20210907, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This ensures that the SD card will remain mmc0 across Basic and Advanced >> devices, also avoiding surprises for users coming from the downstream >> kernels. >> >> Signed-off-by: Jan Kiszka >> --- >> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >> index ec9617c13cdb..d1d5278e0b94 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >> +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >> @@ -18,6 +18,11 @@ / { >> compatible = "siemens,iot2050-advanced", "ti,am654"; >> model = "SIMATIC IOT2050 Advanced"; >> >> + aliases { >> + mmc0 = &sdhci1; >> + mmc1 = &sdhci0; >> + }; > > > Should we do this at SoC level? > Well, I wouldn't mind - but that would also impact your EVMs. For us, this is fine as we are coming from that ordering above with our downstream kernel/dts. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux