devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: claudiu beznea <claudiu.beznea@tuxon.dev>
To: Mihai Sain <mihai.sain@microchip.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, nicolas.ferre@microchip.com,
	alexandre.belloni@bootlin.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/8] ARM: dts: microchip: sam9x60ek: Add power-supply properties for sdmmc nodes
Date: Tue, 6 Feb 2024 07:54:48 +0200	[thread overview]
Message-ID: <35eca42a-5bb0-4d24-972b-6fe2fb4d87ab@tuxon.dev> (raw)
In-Reply-To: <20240205080027.4565-3-mihai.sain@microchip.com>

Hi, Mihai,

On 05.02.2024 10:00, Mihai Sain wrote:
> The sdmmc0 and sdmmc1 controllers are powered from 3.3V regulator.
> Add vmmc-supply and vqmmc-supply properties to sdmmc nodes.
> The sdmmc controller from SAM9X60 MPU doesn't support the IO voltage signaling/switching required by the UHS sd-card.

Please wrap the line at 75 chars (see [1]).

Thank you,
Claudiu Beznea

[1]
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#the-canonical-patch-format.

> In order to use the sd high-speed mode, keep vqmmc at 3V3.
> 
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
>  arch/arm/boot/dts/microchip/at91-sam9x60ek.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
> index f3cbb675cea4..b19a0956dc97 100644
> --- a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
> @@ -560,6 +560,8 @@ &sdmmc0 {
>  	status = "okay";
>  	cd-gpios = <&pioA 23 GPIO_ACTIVE_LOW>;
>  	disable-wp;
> +	vmmc-supply = <&vdd1_3v3>;
> +	vqmmc-supply = <&vdd1_3v3>;
>  };
>  
>  &sdmmc1 {
> @@ -568,6 +570,8 @@ &sdmmc1 {
>  	pinctrl-0 = <&pinctrl_sdmmc1_default>;
>  	no-1-8-v;
>  	non-removable;
> +	vmmc-supply = <&vdd1_3v3>;
> +	vqmmc-supply = <&vdd1_3v3>;
>  	status = "disabled"; /* Conflict with flx4. */
>  };
>  

  reply	other threads:[~2024-02-06  5:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-05  8:00 [PATCH v2 0/8] Add power-supply properties for sdmmc nodes on Microchip boards Mihai Sain
2024-02-05  8:00 ` [PATCH v2 1/8] ARM: dts: microchip: sam9x60_curiosity: Add power-supply properties for sdmmc nodes Mihai Sain
2024-02-05  8:00 ` [PATCH v2 2/8] ARM: dts: microchip: sam9x60ek: " Mihai Sain
2024-02-06  5:54   ` claudiu beznea [this message]
2024-02-05  8:00 ` [PATCH v2 3/8] ARM: dts: microchip: sama5d27_som1_ek: " Mihai Sain
2024-02-05  8:00 ` [PATCH v2 4/8] ARM: dts: microchip: sama5d27_wlsom1: Add power-supply property for sdmmc1 node Mihai Sain
2024-02-05  8:00 ` [PATCH v2 5/8] ARM: dts: microchip: sama5d27_wlsom1_ek: Add power-supply property for sdmmc0 node Mihai Sain
2024-02-05  8:00 ` [PATCH v2 6/8] ARM: dts: microchip: sama5d29_curiosity: Add power-supply properties for sdmmc nodes Mihai Sain
2024-02-05  8:00 ` [PATCH v2 7/8] ARM: dts: microchip: sama5d2_icp: Add power-supply property for sdmmc0 node Mihai Sain
2024-02-05  8:00 ` [PATCH v2 8/8] ARM: dts: microchip: sama5d2_xplained: " Mihai Sain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35eca42a-5bb0-4d24-972b-6fe2fb4d87ab@tuxon.dev \
    --to=claudiu.beznea@tuxon.dev \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihai.sain@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).