From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH v4 3/3] media: mtk-mdp: Fix mdp device tree Date: Wed, 7 Jun 2017 11:13:37 +0200 Message-ID: <35fb23dd-00e2-e0f1-c3ed-e317883ed007@gmail.com> References: <1495509851-29159-1-git-send-email-minghsiu.tsai@mediatek.com> <1495509851-29159-4-git-send-email-minghsiu.tsai@mediatek.com> <2407aa14-610d-0252-f264-edf22961752e@xs4all.nl> <59ac9ca0-3f2f-fa65-011d-c832e4ced265@gmail.com> <9ca0b2c5-db3d-4794-1431-89f5a093252f@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9ca0b2c5-db3d-4794-1431-89f5a093252f-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hans Verkuil , Minghsiu Tsai , Hans Verkuil , daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Rob Herring , Mauro Carvalho Chehab , Daniel Kurtz , Pawel Osciak , Houlong Wei Cc: srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Eddie Huang , Yingjoe Chen , Wu-Cheng Li , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 07/06/17 11:11, Hans Verkuil wrote: > On 07/06/17 11:07, Matthias Brugger wrote: >> >> >> On 07/06/17 10:56, Hans Verkuil wrote: >>> On 07/06/17 10:44, Matthias Brugger wrote: >>>> Hi Hans, hi Mauro, >>>> >>>> On 23/05/17 05:24, Minghsiu Tsai wrote: >>>>> From: Daniel Kurtz >>>>> >>>>> If the mdp_* nodes are under an mdp sub-node, their corresponding >>>>> platform device does not automatically get its iommu assigned properly. >>>>> >>>>> Fix this by moving the mdp component nodes up a level such that they are >>>>> siblings of mdp and all other SoC subsystems. This also simplifies the >>>>> device tree. >>>>> >>>>> Although it fixes iommu assignment issue, it also break compatibility >>>>> with old device tree. So, the patch in driver is needed to iterate over >>>>> sibling mdp device nodes, not child ones, to keep driver work properly. >>>>> >>>>> Signed-off-by: Daniel Kurtz >>>>> Signed-off-by: Minghsiu Tsai >>>>> Signed-off-by: Matthias Brugger >>>>> >>>> >>>> Are you OK to take this patch, or do you have any further comments? >>> >>> Nope, it's all good. Queued for 4.13. >>> >> >> Thanks! >> >> I queued the other two in v4.12-next/dts64 > > Media bindings normally go through the media subsystem, but you've taken > that one as well? I need to know, because then I drop it in my tree. > My fault, I'll drop it from my tree. After that I only queued patch 2/3. Sorry. Matthias -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html