[PATCH 0/2] Update Wave521c Compatible for TI Devices

[PATCH 0/2] Update Wave521c Compatible for TI Devices

[Brandon Brnich]

Hello All, 

There has been ongoing discussion[1] surrounding the issue
of having K3 prefix included in the compatible for dt bindings.
This series removes this prefix from both the device tree
binding as well as the driver.

[1] https://lore.kernel.org/all/20231201063309.tingjc3cjhsqb6r7@confusing/ 

Brandon Brnich (2):
  dt-bindings: media: Remove K3 Family Prefix from Compatible
  media: chips-media: wave5: Remove K3 References

 Documentation/devicetree/bindings/media/cnm,wave521c.yaml | 2 +-
 drivers/media/platform/chips-media/wave5/wave5-vpu.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.34.1

[PATCH 1/2] dt-bindings: media: Remove K3 Family Prefix from Compatible

[Brandon Brnich]

K3 family prefix is not included in other TI compatible
strings. Remove this prefix to keep naming convention
consistent.

Fixes: de4b9f7e371a ("dt-bindings: media: wave5: add yaml devicetree bindings")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Closes: https://lore.kernel.org/all/CAMuHMdUYOq=q1j=d+Eac28hthOUAaNUkuvxmRu-mUN1pLKq69g@mail.gmail.com/
Signed-off-by: Brandon Brnich <b-brnich@ti.com>
---
 Documentation/devicetree/bindings/media/cnm,wave521c.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
index 6d5569e77b7a..471840e858c9 100644
--- a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
+++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
@@ -17,7 +17,7 @@ properties:
   compatible:
     items:
       - enum:
-          - ti,k3-j721s2-wave521c
+          - ti,j721s2-wave521c
       - const: cnm,wave521c
 
   reg:
-- 
2.34.1

[PATCH 2/2] media: chips-media: wave5: Remove K3 References

[Brandon Brnich]

Change compatible string to match dt bindings for
TI devices with Wave521c. 

K3 family prefix should not be included
as it deviates from naming convention.

Fixes: 9707a6254a8a ("media: chips-media: wave5: Add the v4l2 layer")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Closes: https://lore.kernel.org/all/CAMuHMdUYOq=q1j=d+Eac28hthOUAaNUkuvxmRu-mUN1pLKq69g@mail.gmail.com/
Signed-off-by: Brandon Brnich <b-brnich@ti.com>
---
 drivers/media/platform/chips-media/wave5/wave5-vpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c b/drivers/media/platform/chips-media/wave5/wave5-vpu.c
index bfe4caa79cc9..0d90b5820bef 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-vpu.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c
@@ -272,7 +272,7 @@ static const struct wave5_match_data ti_wave521c_data = {
 };
 
 static const struct of_device_id wave5_dt_ids[] = {
-	{ .compatible = "ti,k3-j721s2-wave521c", .data = &ti_wave521c_data },
+	{ .compatible = "ti,j721s2-wave521c", .data = &ti_wave521c_data },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, wave5_dt_ids);
-- 
2.34.1

Re: [PATCH 1/2] dt-bindings: media: Remove K3 Family Prefix from Compatible

[Krzysztof Kozlowski]

On 04/12/2023 19:14, Brandon Brnich wrote:
> K3 family prefix is not included in other TI compatible
> strings. Remove this prefix to keep naming convention
> consistent.
> 
> Fixes: de4b9f7e371a ("dt-bindings: media: wave5: add yaml devicetree bindings")

This change breaks the ABI, so does it mean it was not yet released?

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Best regards,
Krzysztof

Re: [PATCH 2/2] media: chips-media: wave5: Remove K3 References

[Krzysztof Kozlowski]

On 04/12/2023 19:14, Brandon Brnich wrote:
> Change compatible string to match dt bindings for
> TI devices with Wave521c. 
> 
> K3 family prefix should not be included
> as it deviates from naming convention.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Best regards,
Krzysztof