From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] of/unittest: Disable new dtc node_name_vs_property_name and interrupt_map warnings
Date: Wed, 27 Oct 2021 19:05:22 -0500 [thread overview]
Message-ID: <361311a6-5818-6fc8-56d9-1a0ab8eaa74b@gmail.com> (raw)
In-Reply-To: <20211026225527.3460520-1-robh@kernel.org>
On 10/26/21 5:55 PM, Rob Herring wrote:
> The unittest dtbs have various intentional errors which cause warnings.
> With the latest dtc sync to v1.6.1-19-g0a3a9d3449c8, we need to disable
> some new checks: node_name_vs_property_name and interrupt_map warnings.
>
> These warnings are also generated for static_base_1.dtb, so let's just
> disable the problematic warnings for all unittest dtbs instead of just
> testcases.dtb.
>
> Fixes: e76187b9792e ("scripts/dtc: Update to upstream version v1.6.1-19-g0a3a9d3449c8")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/of/unittest-data/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile
> index a5d2d9254b2c..7e1a25ad4e5c 100644
> --- a/drivers/of/unittest-data/Makefile
> +++ b/drivers/of/unittest-data/Makefile
> @@ -37,7 +37,9 @@ DTC_FLAGS_overlay_base += -@
> DTC_FLAGS_testcases += -@
>
> # suppress warnings about intentional errors
> -DTC_FLAGS_testcases += -Wno-interrupts_property
> +DTC_FLAGS += -Wno-interrupts_property \
> + -Wno-node_name_vs_property_name \
> + -Wno-interrupt_map
>
> # Apply overlays statically with fdtoverlay. This is a build time test that
> # the overlays can be applied successfully by fdtoverlay. This does not
>
Before applying this commit, I am not seeing the warning that -Wno-interrupt_map
suppresses. I've tried with (1) CONFIG_OF_DYNAMIC and (2) with both
CONFIG_OF_DYNAMIC and CONFIG_OF_OVERLAY, and I don't see the warning.
Where are you seeing the interrupt_map warning?
I would prefer not changing from DTC_FLAGS_testcases to DTC_FLAGS because
the suppresses the warning for all unittest .dts files, not just the two
that lead to the node_name_vs_property_name warning. These two cases can
be covered with DTC_FLAGS_testcases and DTC_FLAGS_static_test_1.
-Frank
next prev parent reply other threads:[~2021-10-28 0:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 22:55 [PATCH] of/unittest: Disable new dtc node_name_vs_property_name and interrupt_map warnings Rob Herring
2021-10-28 0:05 ` Frank Rowand [this message]
2021-10-28 4:37 ` Stephen Rothwell
2021-10-28 12:54 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=361311a6-5818-6fc8-56d9-1a0ab8eaa74b@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).