From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Farber, Eliav" <farbere@amazon.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Rahul Tanwar <rtanwar@maxlinear.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: moortec, mr75203: fix multipleOf for coefficients
Date: Wed, 12 Jul 2023 14:07:31 +0200 [thread overview]
Message-ID: <36182c36-07fc-e6f6-eb63-bf51ee3d8a86@linaro.org> (raw)
In-Reply-To: <4d9a0899-145e-3223-41da-b91b81afaaa2@amazon.com>
On 12/07/2023 13:58, Farber, Eliav wrote:
> On 7/12/2023 11:11 AM, Krzysztof Kozlowski wrote:
>> Few coefficients use default values multiple of 100, not 1000 (in the
>> example DTS and in the Linux driver):
>>
>> moortec,mr75203.example.dtb: pvt@e0680000: moortec,ts-coeff-g:0:0:
>> 61400 is not a multiple of 1000
>
> Why isn't multiple of 1000 correct?
61400 is not a multiple of 1000, at least not in integers. 61400 is a
multiple of 100.
> According to the Moortec datasheet for the series 6 of the temperature
> sensor
> the coefficients are:
> G = 57.4 (57.4 * 1000 = 57400)
57.4 is not integer. With that approach 1 is also multiple of 1000, because:
G = 1 * 0.001 * 1000.
> H = 249.4
> For series 5 coefficients are:
> G = 60 (60 * 1000 = 60000)
> H = 200
> J = -0.1
Trim the context of replies. No need to quote entire text below.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-12 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 8:11 [PATCH] dt-bindings: hwmon: moortec,mr75203: fix multipleOf for coefficients Krzysztof Kozlowski
2023-07-12 11:58 ` [PATCH] dt-bindings: hwmon: moortec, mr75203: " Farber, Eliav
2023-07-12 12:07 ` Krzysztof Kozlowski [this message]
2023-07-14 20:45 ` [PATCH] dt-bindings: hwmon: moortec,mr75203: " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36182c36-07fc-e6f6-eb63-bf51ee3d8a86@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=farbere@amazon.com \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=rtanwar@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).