devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Leela Krishna Amudala <l.krishna@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
	devicetree@vger.kernel.org, khw0178.kim@samsung.com,
	prathyush.k@samsung.com, cpgs@samsung.com
Subject: Re: [PATCH 1/2] ARM: dts: Exynos5420: add clock entries to gsc power domain
Date: Tue, 15 Oct 2013 20:49:38 +0200	[thread overview]
Message-ID: <3629005.VyZGZ4FEyV@flatron> (raw)
In-Reply-To: <1381836054-6590-2-git-send-email-l.krishna@samsung.com>

Hi Leela,

On Tuesday 15 of October 2013 16:50:53 Leela Krishna Amudala wrote:
> Add clock nodes for oscillator clock, input clocks and parents of input
> clocks to gsc power domain so that we can set/restore the input
> clocks while powering on and powering off a domain.
> 
> Signed-off-by: Prathyush K <prathyush.k@samsung.com>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi index 09aa06c..7f0296c 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -116,6 +116,9 @@
>  	gsc_pd: power-domain@10044000 {
>  		compatible = "samsung,exynos4210-pd";
>  		reg = <0x10044000 0x20>;
> +		clocks = <&clock 1>, <&clock 1032>, <&clock 1033>,
> +			 <&clock 1034>, <&clock 1035>;
> +		clock-names = "oscclk", "pclk0", "clk0", "pclk1", "clk1";

This does not seem right. Do you have any actual code that uses this?

Best regards,
Tomasz

  reply	other threads:[~2013-10-15 18:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15 11:20 [PATCH 0/2] Add G-Scaler device nodes to dt file Leela Krishna Amudala
2013-10-15 11:20 ` [PATCH 1/2] ARM: dts: Exynos5420: add clock entries to gsc power domain Leela Krishna Amudala
2013-10-15 18:49   ` Tomasz Figa [this message]
2013-10-16 10:06     ` Leela Krishna Amudala
2013-10-15 11:20 ` [PATCH 2/2] ARM: dts: Exynos5420: Add dt support for gscaler Leela Krishna Amudala
2013-10-15 18:51   ` Tomasz Figa
2013-10-16 10:08     ` Leela Krishna Amudala
2013-10-16 10:16       ` Leela Krishna Amudala
2013-10-16 10:20         ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3629005.VyZGZ4FEyV@flatron \
    --to=tomasz.figa@gmail.com \
    --cc=cpgs@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene.kim@samsung.com \
    --cc=khw0178.kim@samsung.com \
    --cc=l.krishna@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=prathyush.k@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).