* [PATCH 0/2] Add G-Scaler device nodes to dt file
@ 2013-10-15 11:20 Leela Krishna Amudala
2013-10-15 11:20 ` [PATCH 1/2] ARM: dts: Exynos5420: add clock entries to gsc power domain Leela Krishna Amudala
2013-10-15 11:20 ` [PATCH 2/2] ARM: dts: Exynos5420: Add dt support for gscaler Leela Krishna Amudala
0 siblings, 2 replies; 9+ messages in thread
From: Leela Krishna Amudala @ 2013-10-15 11:20 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: kgene.kim, devicetree, khw0178.kim, prathyush.k, cpgs
This patchset adds clock entries to gsc power domain and gsc device
nodes to DT file
Note: This pathcset is rebased and tested on Kgene's for-next branch.
Leela Krishna Amudala (2):
ARM: dts: Exynos5420: add clock entries to gsc power domain
ARM: dts: Exynos5420: Add dt support for gscaler
arch/arm/boot/dts/exynos5420.dtsi | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] ARM: dts: Exynos5420: add clock entries to gsc power domain
2013-10-15 11:20 [PATCH 0/2] Add G-Scaler device nodes to dt file Leela Krishna Amudala
@ 2013-10-15 11:20 ` Leela Krishna Amudala
2013-10-15 18:49 ` Tomasz Figa
2013-10-15 11:20 ` [PATCH 2/2] ARM: dts: Exynos5420: Add dt support for gscaler Leela Krishna Amudala
1 sibling, 1 reply; 9+ messages in thread
From: Leela Krishna Amudala @ 2013-10-15 11:20 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: kgene.kim, devicetree, khw0178.kim, prathyush.k, cpgs
Add clock nodes for oscillator clock, input clocks and parents of input
clocks to gsc power domain so that we can set/restore the input
clocks while powering on and powering off a domain.
Signed-off-by: Prathyush K <prathyush.k@samsung.com>
Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
---
arch/arm/boot/dts/exynos5420.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 09aa06c..7f0296c 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -116,6 +116,9 @@
gsc_pd: power-domain@10044000 {
compatible = "samsung,exynos4210-pd";
reg = <0x10044000 0x20>;
+ clocks = <&clock 1>, <&clock 1032>, <&clock 1033>,
+ <&clock 1034>, <&clock 1035>;
+ clock-names = "oscclk", "pclk0", "clk0", "pclk1", "clk1";
};
isp_pd: power-domain@10044020 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] ARM: dts: Exynos5420: Add dt support for gscaler
2013-10-15 11:20 [PATCH 0/2] Add G-Scaler device nodes to dt file Leela Krishna Amudala
2013-10-15 11:20 ` [PATCH 1/2] ARM: dts: Exynos5420: add clock entries to gsc power domain Leela Krishna Amudala
@ 2013-10-15 11:20 ` Leela Krishna Amudala
2013-10-15 18:51 ` Tomasz Figa
1 sibling, 1 reply; 9+ messages in thread
From: Leela Krishna Amudala @ 2013-10-15 11:20 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: kgene.kim, devicetree, khw0178.kim, prathyush.k, cpgs
Adds G-Scaler devices to the DT device list
Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
---
arch/arm/boot/dts/exynos5420.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 7f0296c..f86aeea 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -31,6 +31,8 @@
i2c1 = &i2c_1;
i2c2 = &i2c_2;
i2c3 = &i2c_3;
+ gsc0 = &gsc_0;
+ gsc1 = &gsc_1;
};
cpus {
@@ -313,4 +315,22 @@
clocks = <&clock 431>, <&clock 143>;
clock-names = "mixer", "sclk_hdmi";
};
+
+ gsc_0: gsc@0x13e00000 {
+ compatible = "samsung,exynos5-gsc";
+ reg = <0x13e00000 0x1000>;
+ interrupts = <0 85 0>;
+ clocks = <&clock 465>;
+ clock-names = "gscl";
+ samsung,power-domain = <&gsc_pd>;
+ };
+
+ gsc_1: gsc@0x13e10000 {
+ compatible = "samsung,exynos5-gsc";
+ reg = <0x13e10000 0x1000>;
+ interrupts = <0 86 0>;
+ clocks = <&clock 466>;
+ clock-names = "gscl";
+ samsung,power-domain = <&gsc_pd>;
+ };
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ARM: dts: Exynos5420: add clock entries to gsc power domain
2013-10-15 11:20 ` [PATCH 1/2] ARM: dts: Exynos5420: add clock entries to gsc power domain Leela Krishna Amudala
@ 2013-10-15 18:49 ` Tomasz Figa
2013-10-16 10:06 ` Leela Krishna Amudala
0 siblings, 1 reply; 9+ messages in thread
From: Tomasz Figa @ 2013-10-15 18:49 UTC (permalink / raw)
To: Leela Krishna Amudala
Cc: linux-samsung-soc, kgene.kim, devicetree, khw0178.kim,
prathyush.k, cpgs
Hi Leela,
On Tuesday 15 of October 2013 16:50:53 Leela Krishna Amudala wrote:
> Add clock nodes for oscillator clock, input clocks and parents of input
> clocks to gsc power domain so that we can set/restore the input
> clocks while powering on and powering off a domain.
>
> Signed-off-by: Prathyush K <prathyush.k@samsung.com>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi index 09aa06c..7f0296c 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -116,6 +116,9 @@
> gsc_pd: power-domain@10044000 {
> compatible = "samsung,exynos4210-pd";
> reg = <0x10044000 0x20>;
> + clocks = <&clock 1>, <&clock 1032>, <&clock 1033>,
> + <&clock 1034>, <&clock 1035>;
> + clock-names = "oscclk", "pclk0", "clk0", "pclk1", "clk1";
This does not seem right. Do you have any actual code that uses this?
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] ARM: dts: Exynos5420: Add dt support for gscaler
2013-10-15 11:20 ` [PATCH 2/2] ARM: dts: Exynos5420: Add dt support for gscaler Leela Krishna Amudala
@ 2013-10-15 18:51 ` Tomasz Figa
2013-10-16 10:08 ` Leela Krishna Amudala
0 siblings, 1 reply; 9+ messages in thread
From: Tomasz Figa @ 2013-10-15 18:51 UTC (permalink / raw)
To: Leela Krishna Amudala
Cc: linux-samsung-soc, kgene.kim, devicetree, khw0178.kim,
prathyush.k, cpgs
Hi Leela,
On Tuesday 15 of October 2013 16:50:54 Leela Krishna Amudala wrote:
> Adds G-Scaler devices to the DT device list
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi index 7f0296c..f86aeea 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -31,6 +31,8 @@
> i2c1 = &i2c_1;
> i2c2 = &i2c_2;
> i2c3 = &i2c_3;
> + gsc0 = &gsc_0;
> + gsc1 = &gsc_1;
Do you really need these aliases?
> };
>
> cpus {
> @@ -313,4 +315,22 @@
> clocks = <&clock 431>, <&clock 143>;
> clock-names = "mixer", "sclk_hdmi";
> };
> +
> + gsc_0: gsc@0x13e00000 {
coding style: There should be no 0x in node name and the name should
be more meaningful, e.g. video-scaler.
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ARM: dts: Exynos5420: add clock entries to gsc power domain
2013-10-15 18:49 ` Tomasz Figa
@ 2013-10-16 10:06 ` Leela Krishna Amudala
0 siblings, 0 replies; 9+ messages in thread
From: Leela Krishna Amudala @ 2013-10-16 10:06 UTC (permalink / raw)
To: Tomasz Figa
Cc: Leela Krishna Amudala, linux-samsung-soc, Kukjin Kim, devicetree,
khw0178.kim, prathyush.k, cpgs
Hi Tomasz,
On Wed, Oct 16, 2013 at 12:19 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Leela,
>
> On Tuesday 15 of October 2013 16:50:53 Leela Krishna Amudala wrote:
>> Add clock nodes for oscillator clock, input clocks and parents of input
>> clocks to gsc power domain so that we can set/restore the input
>> clocks while powering on and powering off a domain.
>>
>> Signed-off-by: Prathyush K <prathyush.k@samsung.com>
>> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5420.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>> b/arch/arm/boot/dts/exynos5420.dtsi index 09aa06c..7f0296c 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -116,6 +116,9 @@
>> gsc_pd: power-domain@10044000 {
>> compatible = "samsung,exynos4210-pd";
>> reg = <0x10044000 0x20>;
>> + clocks = <&clock 1>, <&clock 1032>, <&clock 1033>,
>> + <&clock 1034>, <&clock 1035>;
>> + clock-names = "oscclk", "pclk0", "clk0", "pclk1", "clk1";
>
> This does not seem right. Do you have any actual code that uses this?
>
I'm not sure whether the code that uses this is present or not.
For time being I'll discard this patch from the series and will post it later.
Best Wishes,
Leela Krishna.
> Best regards,
> Tomasz
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] ARM: dts: Exynos5420: Add dt support for gscaler
2013-10-15 18:51 ` Tomasz Figa
@ 2013-10-16 10:08 ` Leela Krishna Amudala
2013-10-16 10:16 ` Leela Krishna Amudala
0 siblings, 1 reply; 9+ messages in thread
From: Leela Krishna Amudala @ 2013-10-16 10:08 UTC (permalink / raw)
To: Tomasz Figa
Cc: Leela Krishna Amudala, linux-samsung-soc, Kukjin Kim, devicetree,
khw0178.kim, prathyush.k, cpgs
Hi Tomasz,
On Wed, Oct 16, 2013 at 12:21 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Leela,
>
> On Tuesday 15 of October 2013 16:50:54 Leela Krishna Amudala wrote:
>> Adds G-Scaler devices to the DT device list
>>
>> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5420.dtsi | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>> b/arch/arm/boot/dts/exynos5420.dtsi index 7f0296c..f86aeea 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -31,6 +31,8 @@
>> i2c1 = &i2c_1;
>> i2c2 = &i2c_2;
>> i2c3 = &i2c_3;
>> + gsc0 = &gsc_0;
>> + gsc1 = &gsc_1;
>
> Do you really need these aliases?
>
Yes, without these aliases probe function fails saying
[ 1.040000] exynos-gsc 13e00000.gsc: Invalid platform device id: 65517
[ 1.045000] exynos-gsc: probe of 13e00000.gsc failed with error -22
>> };
>>
>> cpus {
>> @@ -313,4 +315,22 @@
>> clocks = <&clock 431>, <&clock 143>;
>> clock-names = "mixer", "sclk_hdmi";
>> };
>> +
>> + gsc_0: gsc@0x13e00000 {
>
> coding style: There should be no 0x in node name and the name should
> be more meaningful, e.g. video-scaler.
>
Okay, will change it and post next version of this patch.
Best Wishes,
Leela Krishna.
> Best regards,
> Tomasz
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] ARM: dts: Exynos5420: Add dt support for gscaler
2013-10-16 10:08 ` Leela Krishna Amudala
@ 2013-10-16 10:16 ` Leela Krishna Amudala
2013-10-16 10:20 ` Tomasz Figa
0 siblings, 1 reply; 9+ messages in thread
From: Leela Krishna Amudala @ 2013-10-16 10:16 UTC (permalink / raw)
To: Leela Krishna Amudala
Cc: Tomasz Figa, linux-samsung-soc, Kukjin Kim, devicetree,
khw0178.kim, prathyush.k, cpgs
On Wed, Oct 16, 2013 at 3:38 PM, Leela Krishna Amudala
<l.krishna@samsung.com> wrote:
> Hi Tomasz,
>
> On Wed, Oct 16, 2013 at 12:21 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
>> Hi Leela,
>>
>> On Tuesday 15 of October 2013 16:50:54 Leela Krishna Amudala wrote:
>>> Adds G-Scaler devices to the DT device list
>>>
>>> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
>>> ---
>>> arch/arm/boot/dts/exynos5420.dtsi | 20 ++++++++++++++++++++
>>> 1 file changed, 20 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>>> b/arch/arm/boot/dts/exynos5420.dtsi index 7f0296c..f86aeea 100644
>>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>>> @@ -31,6 +31,8 @@
>>> i2c1 = &i2c_1;
>>> i2c2 = &i2c_2;
>>> i2c3 = &i2c_3;
>>> + gsc0 = &gsc_0;
>>> + gsc1 = &gsc_1;
>>
>> Do you really need these aliases?
>>
>
> Yes, without these aliases probe function fails saying
> [ 1.040000] exynos-gsc 13e00000.gsc: Invalid platform device id: 65517
> [ 1.045000] exynos-gsc: probe of 13e00000.gsc failed with error -22
>
In gsc_probe() function, of_alias_get_id(pdev->dev.of_node, "gsc") is
returning error value,
Hence probe failing.
>>> };
>>>
>>> cpus {
>>> @@ -313,4 +315,22 @@
>>> clocks = <&clock 431>, <&clock 143>;
>>> clock-names = "mixer", "sclk_hdmi";
>>> };
>>> +
>>> + gsc_0: gsc@0x13e00000 {
>>
>> coding style: There should be no 0x in node name and the name should
>> be more meaningful, e.g. video-scaler.
>>
>
> Okay, will change it and post next version of this patch.
>
> Best Wishes,
> Leela Krishna.
>
>> Best regards,
>> Tomasz
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] ARM: dts: Exynos5420: Add dt support for gscaler
2013-10-16 10:16 ` Leela Krishna Amudala
@ 2013-10-16 10:20 ` Tomasz Figa
0 siblings, 0 replies; 9+ messages in thread
From: Tomasz Figa @ 2013-10-16 10:20 UTC (permalink / raw)
To: Leela Krishna Amudala
Cc: Tomasz Figa, linux-samsung-soc, Kukjin Kim, devicetree,
khw0178.kim, prathyush.k, cpgs
On Wednesday 16 of October 2013 15:46:21 Leela Krishna Amudala wrote:
> On Wed, Oct 16, 2013 at 3:38 PM, Leela Krishna Amudala
> <l.krishna@samsung.com> wrote:
> > Hi Tomasz,
> >
> > On Wed, Oct 16, 2013 at 12:21 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> >> Hi Leela,
> >>
> >> On Tuesday 15 of October 2013 16:50:54 Leela Krishna Amudala wrote:
> >>> Adds G-Scaler devices to the DT device list
> >>>
> >>> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> >>> ---
> >>> arch/arm/boot/dts/exynos5420.dtsi | 20 ++++++++++++++++++++
> >>> 1 file changed, 20 insertions(+)
> >>>
> >>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> >>> b/arch/arm/boot/dts/exynos5420.dtsi index 7f0296c..f86aeea 100644
> >>> --- a/arch/arm/boot/dts/exynos5420.dtsi
> >>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> >>> @@ -31,6 +31,8 @@
> >>> i2c1 = &i2c_1;
> >>> i2c2 = &i2c_2;
> >>> i2c3 = &i2c_3;
> >>> + gsc0 = &gsc_0;
> >>> + gsc1 = &gsc_1;
> >>
> >> Do you really need these aliases?
> >>
> >
> > Yes, without these aliases probe function fails saying
> > [ 1.040000] exynos-gsc 13e00000.gsc: Invalid platform device id: 65517
> > [ 1.045000] exynos-gsc: probe of 13e00000.gsc failed with error -22
> >
>
> In gsc_probe() function, of_alias_get_id(pdev->dev.of_node, "gsc") is
> returning error value,
> Hence probe failing.
OK.
> >>> };
> >>>
> >>> cpus {
> >>> @@ -313,4 +315,22 @@
> >>> clocks = <&clock 431>, <&clock 143>;
> >>> clock-names = "mixer", "sclk_hdmi";
> >>> };
> >>> +
> >>> + gsc_0: gsc@0x13e00000 {
> >>
> >> coding style: There should be no 0x in node name and the name should
> >> be more meaningful, e.g. video-scaler.
> >>
> >
> > Okay, will change it and post next version of this patch.
OK. Thanks.
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-10-16 10:20 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-15 11:20 [PATCH 0/2] Add G-Scaler device nodes to dt file Leela Krishna Amudala
2013-10-15 11:20 ` [PATCH 1/2] ARM: dts: Exynos5420: add clock entries to gsc power domain Leela Krishna Amudala
2013-10-15 18:49 ` Tomasz Figa
2013-10-16 10:06 ` Leela Krishna Amudala
2013-10-15 11:20 ` [PATCH 2/2] ARM: dts: Exynos5420: Add dt support for gscaler Leela Krishna Amudala
2013-10-15 18:51 ` Tomasz Figa
2013-10-16 10:08 ` Leela Krishna Amudala
2013-10-16 10:16 ` Leela Krishna Amudala
2013-10-16 10:20 ` Tomasz Figa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).