devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Rahul Sharma <rahul.sharma@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	kgene.kim@samsung.com, sw0312.kim@samsung.com,
	inki.dae@samsung.com, s.nawrocki@samsung.com, joshi@samsung.com,
	r.sh.open@gmail.com
Subject: Re: [PATCH v4 5/7] ARM: dts: add clocks for exynos5420 hdmi subsystem
Date: Fri, 23 Aug 2013 21:43:06 +0200	[thread overview]
Message-ID: <3634494.5b0t0b50Cd@flatron> (raw)
In-Reply-To: <1377253461-20851-6-git-send-email-rahul.sharma@samsung.com>

Hi Rahul,

On Friday 23 of August 2013 15:54:19 Rahul Sharma wrote:
> Add clocks for hdmi and mixer for exynos5420 SoC.
> 
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi index 7c6214d..1405074 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -279,6 +279,10 @@
>  		compatible = "samsung,exynos4212-hdmi";
>  		reg = <0x14530000 0x70000>;
>  		interrupts = <0 95 0>;
> +		clocks = <&clock 413>, <&clock 143>, <&clock 144>,
> +			<&clock 158>, <&clock 1024>;
> +		clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
> +			"sclk_hdmiphy", "mout_hdmi";
>  		status = "disabled";
>  	};
> 
> @@ -286,6 +290,8 @@
>  		compatible = "samsung,exynos5420-mixer";
>  		reg = <0x14450000 0x10000>;
>  		interrupts = <0 94 0>;
> +		clocks = <&clock 431>, <&clock 143>;
> +		clock-names = "mixer", "sclk_hdmi";
>  		status = "disabled";
>  	};
>  };

You just added all the nodes in previous patch. There is no need for a 
separate patch adding clocks. Please squash this with previous patch.

Best regards,
Tomasz


  reply	other threads:[~2013-08-23 19:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-23 10:24 [PATCH v4 0/7] ARM: dts: add support for exynos hdmi subsystem Rahul Sharma
2013-08-23 10:24 ` [PATCH v4 1/7] ARM: dts: add mixer clocks to mixer node for Exynos5250 Rahul Sharma
2013-08-23 10:24 ` [PATCH v4 2/7] ARM: dts: add clocks to hdmi dt node for exynos5250 Rahul Sharma
2013-08-23 10:24 ` [PATCH v4 3/7] ARM: dts: add i2c device nodes for Exynos5420 Rahul Sharma
2013-08-23 10:24 ` [PATCH v4 4/7] ARM: dts: add dt nodes for exynos5420 hdmi subsystem Rahul Sharma
2013-08-23 19:48   ` Tomasz Figa
2013-08-24  6:35     ` Rahul Sharma
2013-08-24 14:32       ` Tomasz Figa
2013-08-26  5:12         ` Rahul Sharma
2013-08-23 10:24 ` [PATCH v4 5/7] ARM: dts: add clocks " Rahul Sharma
2013-08-23 19:43   ` Tomasz Figa [this message]
2013-08-23 10:24 ` [PATCH v4 6/7] ARM: dts: add hdmi hpd gpio pinctrl node for exynos5420 Rahul Sharma
2013-08-23 10:24 ` [PATCH v4 7/7] of/documentation: update with clock information for exynos hdmi subsystem Rahul Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3634494.5b0t0b50Cd@flatron \
    --to=tomasz.figa@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=inki.dae@samsung.com \
    --cc=joshi@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=r.sh.open@gmail.com \
    --cc=rahul.sharma@samsung.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).