From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v4 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port Date: Tue, 16 Feb 2016 22:20:51 +0100 Message-ID: <3647094.zzYms58VAY@wuerfel> References: <1455646502-23834-1-git-send-email-gregory.clement@free-electrons.com> <1455646502-23834-4-git-send-email-gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1455646502-23834-4-git-send-email-gregory.clement@free-electrons.com> Sender: linux-kernel-owner@vger.kernel.org To: Gregory CLEMENT Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , arm@kernel.org, Catalin Marinas , Will Deacon , Jonathan Corbet , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, Tejun Heo , Hans de Goede , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Rutland , devicetree@vger.kernel.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Lior Amsalem , Nadav Haklai , Omri Itach , Wilson Ding List-Id: devicetree@vger.kernel.org On Tuesday 16 February 2016 19:14:53 Gregory CLEMENT wrote: > > +config SERIAL_MVEBU_UART > + bool "Marvell EBU serial port support" > + select SERIAL_CORE It would be nice to make this a tristate option with depends on ARCH_MVEBU || COMPILE_TEST so we can build it in an allmodconfig kernel as a standalone module like the other drivers. > + > +config SERIAL_MVEBU_CONSOLE > + bool "Console on Marvell EBU serial port" > + depends on SERIAL_MVEBU_UART then this one must become depends on SERIAL_MVEBU_UART so it does not get enabled if the driver is not builtin. Arnd