From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: gchan9527@gmail.com, Robert Foss <rfoss@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Bjorn Andersson <andersson@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] media: qcom: camss: Add sc7180 resources
Date: Sat, 22 Jun 2024 13:18:05 +0200 [thread overview]
Message-ID: <3660e37e-2716-4d9f-a9cf-b69568d4e77c@linaro.org> (raw)
In-Reply-To: <20240621-b4-sc7180-camss-v1-5-14937929f30e@gmail.com>
On 21.06.2024 11:40 AM, George Chan via B4 Relay wrote:
> From: George Chan <gchan9527@gmail.com>
>
> This commit describes the hardware layout for the sc7180 for the
> following hardware blocks:
>
> - 2 x VFE
> - 1 x VFE Lite
> - 2 x CSID
> - 1 x CSID Lite
> - 4 x CSI PHY
>
> Signed-off-by: George Chan <gchan9527@gmail.com>
> ---
[...]
> if (ret) {
> - dev_err(dev, "clock enable failed: %d\n", ret);
> + dev_err(dev, "clock enable failed: %s %d\n", clock[i].name, ret);
This is a good change, but should be separate
Generally this looks quite in line with [1], although I wasn't able to find
the matching clock rates
Konrad
[1] https://git.codelinaro.org/clo/la/kernel/msm-4.14/-/blob/UC.UM.1.0.r1-02500-sa8155.0/arch/arm64/boot/dts/qcom/atoll-camera.dtsi
next prev parent reply other threads:[~2024-06-22 11:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 9:40 [PATCH 0/6] media: qcom: camss: Add sc7180 support George Chan via B4 Relay
2024-06-21 9:40 ` [PATCH 1/6] media: dt-bindings: media: camss: Add qcom,sc7180-camss binding George Chan via B4 Relay
2024-06-21 10:02 ` Krzysztof Kozlowski
2024-06-22 15:24 ` george chan
2024-06-21 10:29 ` Rob Herring (Arm)
2024-06-21 11:24 ` Bryan O'Donoghue
2024-06-22 15:31 ` george chan
2024-06-23 11:10 ` Bryan O'Donoghue
2024-06-23 21:45 ` george chan
2024-06-21 9:40 ` [PATCH 2/6] media: qcom: camss: Add CAMSS_SC7180 enum George Chan via B4 Relay
2024-06-21 10:03 ` Krzysztof Kozlowski
2024-06-21 11:16 ` Bryan O'Donoghue
2024-06-21 9:40 ` [PATCH 3/6] media: qcom: camss: csiphy-3ph: Add Gen2 v1.2.2 two-phase MIPI CSI-2 DPHY init George Chan via B4 Relay
2024-06-21 11:25 ` Bryan O'Donoghue
2024-06-22 11:20 ` Konrad Dybcio
2024-06-22 13:47 ` george chan
[not found] ` <CADgMGSs7owyvvvRTr4YvCdmMiJV86CjD5YLsJiBZZONDhfFisQ@mail.gmail.com>
2024-06-23 11:17 ` Bryan O'Donoghue
2024-06-23 21:37 ` george chan
2024-06-23 22:13 ` Bryan O'Donoghue
2024-06-23 23:16 ` george chan
2024-06-23 23:26 ` Bryan O'Donoghue
2024-06-21 9:40 ` [PATCH 4/6] media: qcom: camss: Add sc7180 support George Chan via B4 Relay
2024-06-21 9:40 ` [PATCH 5/6] media: qcom: camss: Add sc7180 resources George Chan via B4 Relay
2024-06-22 11:18 ` Konrad Dybcio [this message]
2024-06-23 21:48 ` george chan
2024-06-23 22:14 ` Bryan O'Donoghue
2024-06-23 23:27 ` george chan
2024-06-21 9:40 ` [PATCH RFT 6/6] arm64: dts: qcom: sc7180: Add support for camss subsys George Chan via B4 Relay
2024-06-21 10:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3660e37e-2716-4d9f-a9cf-b69568d4e77c@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=gchan9527@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).