From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC PATCH] of: base: add support to get machine model name Date: Thu, 17 Nov 2016 14:50:13 +0100 Message-ID: <3670336.mMHByOpDl4@wuerfel> References: <1479383450-19183-1-git-send-email-sudeep.holla@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1479383450-19183-1-git-send-email-sudeep.holla@arm.com> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, devicetree@vger.kernel.org, linux-sh@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring , linuxppc-dev@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On Thursday, November 17, 2016 11:50:50 AM CET Sudeep Holla wrote: > Currently platforms/drivers needing to get the machine model name are > replicating the same snippet of code. In some case, the OF reference > counting is either missing or incorrect. > > This patch adds support to read the machine model name either using > the "model" or the "compatible" property in the device tree root node. > > Signed-off-by: Sudeep Holla I like the idea. One small comment: > +int of_machine_get_model_name(const char **model) > +{ > + int error; > + struct device_node *root; > + > + root = of_find_node_by_path("/"); > + if (!root) > + return -EINVAL; The global of_root variable points ot this already, and is defined in the same file, so I think we can just skip the lookup. Arnd