From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com ([192.55.52.151]:4926 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726906AbfAQPd7 (ORCPT ); Thu, 17 Jan 2019 10:33:59 -0500 Reply-To: thor.thayer@linux.intel.com Subject: Re: [PATCH 1/4] EDAC, altera: Fix S10 persistent register offset References: <1547680314-31045-1-git-send-email-thor.thayer@linux.intel.com> <1547680314-31045-2-git-send-email-thor.thayer@linux.intel.com> From: Thor Thayer Message-ID: <367d4509-1d4d-48b4-8c67-caf4dd39ccbe@linux.intel.com> Date: Thu, 17 Jan 2019 09:36:30 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Dinh Nguyen , bp@alien8.de, robh+dt@kernel.org, mark.rutland@arm.com, mchehab@kernel.org Cc: devicetree@vger.kernel.org, linux-edac@vger.kernel.org List-ID: On 1/17/19 8:52 AM, Dinh Nguyen wrote: > > > On 1/16/19 5:11 PM, thor.thayer@linux.intel.com wrote: >> From: Thor Thayer >> >> Correct the persistent register offset where address >> and status are stored. >> >> Fixes: 08f08bfb7b4c ("EDAC, altera: Merge Stratix10 into the Arria10 SDRAM >> probe routine") > > The "Fixes" line should be all on one line. I recently got dinged for this. > >>>>From Documentation/process/submitting-patches.rst" > > "If your patch fixes a bug in a specific commit, e.g. you found an issue > using > ``git bisect``, please use the 'Fixes:' tag with the first 12 characters of > the SHA-1 ID, and the one line summary. For example:: > > Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")" > > Dinh > I'll fix that and send out another patchset. Thanks Dinh.