From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76B6944162A for ; Fri, 28 Aug 2026 12:42:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787920985; cv=none; b=TqDqfUe9mziao8iPUC5VIsYYfVH7HFG9VXIYdyVcAzYVtHye8LS8Gt2O3etpTC87WnojJZ3vH3Rsac3Ii5plypH0MaGrZSAFiRE16X3UZLiQT3uu8y9aqjf5P4hfymy6/baqLKzET5thWvdl3Zm43nW/pnYZ6t1PhZYIICsmTt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787920985; c=relaxed/simple; bh=xcKYBW/fzhoq3B/N4hMrGWjH26fUKgE4ehUFJv7khkY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nfIQG0bHww4S1ANr71hZEFNrRM33hYSVv7hZPqWrHjUyVk5sYDX1A1C7fog0N3kNjlyeRfxKNuV9GUjNbJO/ojF1deP5pK0cEBmMYGgZnAqtaLZQktaF+kHHWki8r9RtlGfjS96FZOK3ndU4MB5A5p3fQwo4o4Qa+ep5rvoAgyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KHxTnYhL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SVN2ghPw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KHxTnYhL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SVN2ghPw" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67SA7E4Y2725222 for ; Fri, 28 Aug 2026 12:42:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vafQ8CbVP264KdhCPbqi7uL9q+TNsqpYwNy+Mox5+1U=; b=KHxTnYhLQMs8U4zW dLmlKuGf9SJQA0OBsqlhZBm3lmBWBRJlTnETDPcmRWp1du+nby9jWmF1EEEXzEB+ MRZFSn17ukfca4H1lgm0bpLU/NDkc9rWN/b85N397m6lO5MpSzPpmRr9MBWtLBNW bGR92USgqwEpEibt+iJ7shUFZP3DPdvLYXYXUwrAKOH25mGfysOvIkGf+kLBQHCl /djJLfNRnnmsLlgJk0lDrFRoFsWE0Rmc9J6oiRCZ3ZjTx+IYw4GJTp61/PaKUW4w fG3URrLhtd2zIasytjd3iC4ycLVmpDdsdyhFvx3cwLndRzcPEvwsFeCtSCsGCT8d 2AP2qg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gb7eh0qg9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Aug 2026 12:42:53 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-52faa0dd18bso22799591cf.0 for ; Fri, 28 Aug 2026 05:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787920973; x=1788525773; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vafQ8CbVP264KdhCPbqi7uL9q+TNsqpYwNy+Mox5+1U=; b=SVN2ghPwdVmOYMirDFjZ6b0R+y8uCbN9QxzqHsURxjSlH6zR/YhApjoMPtzWtevW/S Bwk4qnhmXstjjrY5i9KZKhG2Fj5byUFnm6G7cZwn0D3j+e4HrGKdUv88pWuuJlGv07wz 3gw+602PpMjIM1UVPXqYFha/MR2R4BLSQEl+sMKvvOb8OwTtyNgaIGZl4Yk+mMnR+XTJ Le6Pg0v4Biu3W1otlECOjmMnA5lNVtW8H6D4yNc5u1B4koVkWJJXJE91NxWxI09f+wHK 4vT1DxNQIbBgMsSCMs3mbj5a5B2N9Razy3otlHT+nbMj/dXYfCHMlyI6o30uQrcIKqP+ dtzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787920973; x=1788525773; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vafQ8CbVP264KdhCPbqi7uL9q+TNsqpYwNy+Mox5+1U=; b=qVgDUsZ3whSqFrvHwZwjOWP9+OlXff14pA6hgcwDcBHxLDb3Ak2pI07A2FJiLdT13b yy97mNexghZstE+0cXhIRzxTbkAOT+pLqmD4G3KG7rq1QvKhPED1uSEZYEXFcosRb0DU WFql5+w2HUN1fxQu3sHi+GWVxsC6x4MmmkEwl5qqy3YeXKsbanX0T950hbDO2cblwRSj mXHPacBMJhZt6UJTWlw9N7Kd21dU8Nm5RryYTkk+peFZMOo3RgEiWGRu14johMsnfoSr yDEZQNNKIlRcrkSSa38RAYwgK9/A23fMpTI6IGjPrkjnR9fQDlXO74ASVTfzv9p+Xl6P K4OQ== X-Forwarded-Encrypted: i=1; AHgh+RqfZ6l8MPwFvEwEmiS8su7qnmX2Ebi3oWQd/9TPjXDTDfi8j7Chg3GXW8gksp+uhdvrCn8qVrm5B6lN@vger.kernel.org X-Gm-Message-State: AFuF++kkl4q+nk/PMLlwl/5BPJow+Jn01Ha+EVLVuitWKW7GVDgGKkoF i3sydiQ9j9vBmNcXZ6C8eRjQSPqvGAoMAIElLC5Mow/kVCOcg2yyqS9sTLJLiT4quyb8Hkt3TTD 6mutqjxQlizPlGBecC/UiXlK06namksVbKUh/sMVQ8rD1QFio2AclR1XM5U60/Hgp X-Gm-Gg: AR+sD12zCK3mf3DCF8yGNzi+Hz+M7HApMTtzAMsVRs+MMcFmy52Exdgh61RGJoFBts1 J95/9q3YGBLiqXVIdJLwQdaaxNqQ4051GDdAp9eUqUFS9474uLrRcgV3cyh3bT8lPEsk5SoJNJq eSASPptCrUlFSqtXe9q9IaHRHQ78IdzW2j03YV/7qMXksHRHqI9d5RRa1N3wgfvqb9b88bp8Ugz FosN9QJd/1Ywr+0SepyenyhPN9hv1rky9WG0DDj1pT1zhp5eI6oDFGk77kEpAOkosmbNdOOH9L0 PWiOlnDnFbv11fD+1RhYQVs3YwtpO4Xp9L+wcyeEZ5L3Q4fSDMCuy1h3pv+MANVeKDYnJM3/DiT dbvKBV2CX9xjv3jP0XevmSPA6kFY= X-Received: by 2002:a05:622a:1105:b0:52d:7b2a:93b with SMTP id d75a77b69052e-52fb9404fffmr67524101cf.9.1787920972877; Fri, 28 Aug 2026 05:42:52 -0700 (PDT) X-Received: by 2002:a05:622a:1105:b0:52d:7b2a:93b with SMTP id d75a77b69052e-52fb9404fffmr67523581cf.9.1787920972331; Fri, 28 Aug 2026 05:42:52 -0700 (PDT) Received: from [192.168.68.119] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49b4c321184sm163839105e9.11.2026.08.28.05.42.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 05:42:51 -0700 (PDT) Message-ID: <36b61b1a-1b5a-4946-96d5-576baf707af9@oss.qualcomm.com> Date: Fri, 28 Aug 2026 13:42:50 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/9] ASoC: dt-bindings: qcom,qaif-cpu: Add binding To: Harendra Gautam , Srinivas Kandagatla Cc: Mohammad Rafi Shaik , Mark Brown , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prasad Kumpatla , Krzysztof Kozlowski , Sarath Ganapathiraju , Kumar Anurag Singh References: <20260824063627.3595610-1-harendra.gautam@oss.qualcomm.com> <20260824063627.3595610-2-harendra.gautam@oss.qualcomm.com> <08b6fd88-84b3-4b3f-a8c5-dd6bfd39403f@oss.qualcomm.com> <137d4a06-4542-488d-91e2-d338ffb9d47d@kernel.org> <375dfd48-4351-445b-890f-cbf3a835f65a@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <375dfd48-4351-445b-890f-cbf3a835f65a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: iIAr0p9lafehAs0vJhyYf5Pa19aWN0Xg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI4MDEwOSBTYWx0ZWRfXwQ1yvmnshIqG 2dhrHVYZl3uQnwTk5MLeW8OgRS9somZp81Lee4pDG4cpDRC4M0wbHzuxtUjkyrYbYoSljb3pvo9 wssOY7m1pFtJg9KyOxS8EVq+2I3RdwQgSJhLdO6MEoXeJ8UF9NkPHo5CzJos2PxauLMGZ0xjhgF 8moePD60S893wXBHQHn2miLNohUdrLHD5MRXV/0WIG8j51avXWLonCsq/DGAPWzA7gMlgxu05xN RuiI1JFQvdpF9pa7eBMU5cLHvRaAQxnZ67fB4VEfLMbTc3K25p+hUvoHlzhlUnqAaCX6fPg1dz4 zV7JI9TaH115Lh/OdOD1+sZfzxJ1zJuXIUJepVyiOqc3XOVSFp8rlHgckesocdB2BqdWvBu9kPG e8fFAVHegmF7DUO3UPetuGSHblujl2bGbIXZVGZBNRf3N3SjcScucHPqIfYX7sNz0BgSBp1N5QI 0zm6bWchEPVNjuzSZ4A== X-Proofpoint-ORIG-GUID: iIAr0p9lafehAs0vJhyYf5Pa19aWN0Xg X-Proofpoint-Spam-Info: AW1haW4tMjYwODI4MDEwOSBTYWx0ZWRfXz3nwRxOOYo4h dTLrmHo3V0r9kjM/P3weXAZukPqXgKmHv4vFa3fQSeDFhn1+EA1A614kOSwHvjAP1L/vEJABTdO cJn/CztjmM4MKs2D3+KchmXFL9zywIY= X-Authority-Analysis: v=2.4 cv=RoP16imK c=1 sm=1 tr=0 ts=6a91824d cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=P-IC7800AAAA:8 a=YEwIN1lEEnS1Bx47E9YA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-28_03,2026-08-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 phishscore=0 suspectscore=0 impostorscore=0 malwarescore=0 spamscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608280109 On 8/28/26 1:37 PM, Srinivas Kandagatla wrote: > On 8/28/26 9:58 AM, Harendra Gautam wrote: >>>>>>>> +#define QAIF_CDC_DMA_VA_TX8 254 >>>>>>>> +#define QAIF_CDC_DMA_VA_TX9 255 >>>>>>>> + >>>>>>> These DAI IDs exceed the LPASS_MAX_PORT limit, which will cause sound >>>>>>> card registration to fail. >>>>>>> >>>>>>> Check sound/soc/qcom/common.c, as the current indices (246-255) are >>>>>>> beyond the supported LPASS port range. >>>>>>> >>>>>>> Best Regards, >>>>>>> Rafi. >>>>>> Thanks for pointing this out. We can either add the range check for >>>>>> min/max QAIF DAI IDs in qcom/common.c or introduce a common helper in >>>>>> qcom/common.h to validate the supported DAI IDs across Qualcomm >>>>>> platforms. >>>>> >>>>> You should add these ids to >>>>> include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h instead to avoid >>>>> conflicts with common code. >>>>> >>>>> --srini >>>> Thanks for the suggestion. qcom,q6dsp-lpass-ports.h is specific to Q6 >>>> DSP/AFE virtual port IDs. Since QAIF is a direct MMIO driver with no >>>> Q6 DSP involvement, would adding QAIF IDs there not be misleading? >>> >>> These are IDs that will be reused across both dsp and non-dsp solution. >>> So it makes more sense to keep it in one single place to allow the >>> hardware description (DT) unchanged across different software solutions. >>> >>> >>>> would it be better to update the range check in common.c/common.h to >>>> accommodate both LPASS and QAIF DAI ID ranges instead? >>> No, that does not make sense because these numbering might conflicting >>> with other ports in future. >>> >>> --srini >> Srini, could you please confirm if adding QAIF DAIs to >> qcom,q6dsp-lpass-ports.h is acceptable given that it increases >> LPASS_MAX_PORT by 56 (from 149 to 205), which indirectly grows >> multiple arrays sized by AFE_PORT_MAX and APM_PORT_MAX in other > > BTW, the dai ids are already added by Prasad > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h?h=next-20260827#n240 > > > You should use them. Correction, he only added QAIF clk ids, not the dai ids, Not sure why dai ids are missing. That also raises question on how did Prasad test it without the QAIF dai ids. --srini > > to your question about increase in size, yes, this is know issue, i have > some changes to send which will remove the need of this static array > which should fix the concerns. > > But for now all the hardware dai ids for qualcomm SoCs should be in a > single place irrespective of dsp or non dsp solution. > > > --srini >> drivers eg below >> https://elixir.bootlin.com/linux/v7.2/source/sound/soc/qcom/qdsp6/q6afe-dai.c#L30 >> https://elixir.bootlin.com/linux/v7.2/source/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c#L21 >> -Harendra >