devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Gowthami Thiagarajan <gthiagarajan@marvell.com>,
	will@kernel.org, mark.rutland@arm.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org
Cc: sgoutham@marvell.com, bbhushan2@marvell.com, lcherian@marvell.com
Subject: Re: [PATCH v2 6/6] dt-bindings: perf: Add Marvell Odyssey DDR PMU
Date: Mon, 14 Aug 2023 10:16:29 +0200	[thread overview]
Message-ID: <36dbb926-0694-f84b-44dc-9608537024b5@linaro.org> (raw)
In-Reply-To: <20230812142518.778259-7-gthiagarajan@marvell.com>

On 12/08/2023 16:25, Gowthami Thiagarajan wrote:
> Add binding documentation for Marvell Odyssey DDR PMU.
> 
> Signed-off-by: Gowthami Thiagarajan <gthiagarajan@marvell.com>
> ---
> 
> v1->v2
> - No change
> 
>  .../devicetree/bindings/perf/marvell-cn10k-ddr.yaml      | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/perf/marvell-cn10k-ddr.yaml b/Documentation/devicetree/bindings/perf/marvell-cn10k-ddr.yaml
> index a18dd0a8c43a..a435cbf4aea0 100644
> --- a/Documentation/devicetree/bindings/perf/marvell-cn10k-ddr.yaml
> +++ b/Documentation/devicetree/bindings/perf/marvell-cn10k-ddr.yaml
> @@ -11,10 +11,15 @@ maintainers:
>  
>  properties:
>    compatible:
> -    items:
> +    oneOf:
>        - enum:
>            - marvell,cn10k-ddr-pmu
> -
> +          - marvell,odyssey-ddr-pmu
> +      - items:
> +          - enum:
> +              - marvell,cn10k-ddr-pmu
> +              - marvell,odyssey-ddr-pmu
> +          - const: marvell,cn10k-ddr-pmu

This is absolutely bogus and does not make sense.

marvell,cn10k-ddr-pmu is not compatible with marvell,cn10k-ddr-pmu

Questions about actual name of SoC remain...

>    reg:
>      maxItems: 1
>  

Best regards,
Krzysztof


      reply	other threads:[~2023-08-14  8:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-12 14:25 [PATCH v2 0/6] Marvell Odyssey uncore performance monitor support Gowthami Thiagarajan
2023-08-12 14:25 ` [PATCH v2 1/6] perf/marvell: Marvell PEM " Gowthami Thiagarajan
2023-08-12 14:25 ` [PATCH v2 2/6] dt-bindings: perf: Add Marvell PEM performance monitor unit Gowthami Thiagarajan
2023-08-14  8:13   ` Krzysztof Kozlowski
2023-08-12 14:25 ` [PATCH v2 3/6] perf/marvell : Odyssey LLC-TAD performance monitor support Gowthami Thiagarajan
2023-08-12 14:25 ` [PATCH v2 4/6] dt-bindings: perf: Add Marvell Odyssey LLC-TAD pmu Gowthami Thiagarajan
2023-08-14  8:15   ` Krzysztof Kozlowski
2023-08-12 14:25 ` [PATCH v2 5/6] perf/marvell: Odyssey DDR Performance monitor support Gowthami Thiagarajan
2023-08-12 14:25 ` [PATCH v2 6/6] dt-bindings: perf: Add Marvell Odyssey DDR PMU Gowthami Thiagarajan
2023-08-14  8:16   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36dbb926-0694-f84b-44dc-9608537024b5@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=bbhushan2@marvell.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gthiagarajan@marvell.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lcherian@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sgoutham@marvell.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).