From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/12] arm64: dts: qcom: apq8096-db820c: correct UFS pad supply
Date: Wed, 6 Sep 2023 11:43:29 +0200 [thread overview]
Message-ID: <36f475ff-a6be-40ea-8a27-042d36b53daa@linaro.org> (raw)
In-Reply-To: <20230905161920.252013-6-krzysztof.kozlowski@linaro.org>
On 5.09.2023 18:19, Krzysztof Kozlowski wrote:
> The Qualcomm UFS phy switched from dedicated driver to QMP phy driver.
> Eventually the old driver was removed in commit 02dca8c981b5 ("phy:
> qcom: remove ufs qmp phy driver"). The original driver and its binding
> used vddp-ref-clk regulator supply, but the new one did not and left the
> supply unused.
>
> The Qualcomm UFS phy bindings were also migrated to newer ones and
> dropped support for vddp-ref-clk regulator in commit dc5cb63592bd
> ("dt-bindings: phy: migrate QMP UFS PHY bindings to
> qcom,sc8280xp-qmp-ufs-phy.yaml").
>
> It turns out that this regulator, although with inaccurate name
> vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or
> similar, depending on the SoC) used by UFS controller.
>
> Bring back handling of this supply by using more appropriate regulator -
> UFS controller host supply. This also fixes dtbs_check warning:
>
> apq8096-db820c.dtb: phy@627000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2023-09-06 9:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 16:19 [PATCH 00/12] arm64: dts: qcom: correct UFS pad supply Krzysztof Kozlowski
2023-09-05 16:19 ` [PATCH 01/12] arm64: dts: qcom: sm6125-sprout: drop incorrect UFS phy max current Krzysztof Kozlowski
2023-09-06 9:40 ` Konrad Dybcio
2023-09-06 9:45 ` Krzysztof Kozlowski
2023-09-06 9:48 ` Konrad Dybcio
2023-09-05 16:19 ` [PATCH 02/12] arm64: dts: qcom: sm6125-sprout: correct UFS pad supply Krzysztof Kozlowski
2023-09-06 9:43 ` Konrad Dybcio
2023-09-05 16:19 ` [PATCH 03/12] arm64: dts: qcom: sm6115-pro1x: " Krzysztof Kozlowski
2023-09-06 9:43 ` Konrad Dybcio
2023-09-05 16:19 ` [PATCH 04/12] arm64: dts: qcom: sm6115p-j606f: " Krzysztof Kozlowski
2023-09-06 9:43 ` Konrad Dybcio
2023-09-05 16:19 ` [PATCH 05/12] arm64: dts: qcom: apq8096-db820c: " Krzysztof Kozlowski
2023-09-06 9:43 ` Konrad Dybcio [this message]
2023-09-05 16:19 ` [PATCH 06/12] arm64: dts: qcom: msm8996-oneplus: " Krzysztof Kozlowski
2023-09-06 9:43 ` Konrad Dybcio
2023-09-05 16:19 ` [PATCH 07/12] arm64: dts: qcom: msm8996-gemini: " Krzysztof Kozlowski
2023-09-06 9:43 ` Konrad Dybcio
2023-09-05 16:19 ` [PATCH 08/12] arm64: dts: qcom: msm8998-pro1: " Krzysztof Kozlowski
2023-09-06 9:43 ` Konrad Dybcio
2023-09-05 16:19 ` [PATCH 09/12] arm64: dts: qcom: msm8998-mtp: " Krzysztof Kozlowski
2023-09-06 9:44 ` Konrad Dybcio
2023-09-05 16:19 ` [PATCH 10/12] arm64: dts: qcom: msm8998-oneplus: " Krzysztof Kozlowski
2023-09-06 9:44 ` Konrad Dybcio
2023-09-05 16:19 ` [PATCH 11/12] arm64: dts: qcom: msm8998-sagit: " Krzysztof Kozlowski
2023-09-06 9:44 ` Konrad Dybcio
2023-09-05 16:19 ` [PATCH 12/12] arm64: dts: qcom: sm4250-billie2: " Krzysztof Kozlowski
2023-09-06 9:44 ` Konrad Dybcio
2023-09-20 3:58 ` [PATCH 00/12] arm64: dts: qcom: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36f475ff-a6be-40ea-8a27-042d36b53daa@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).