From: Arnd Bergmann <arnd@arndb.de>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [RFC 3/3] ARM: e3xx: Add header file for pinctrl constants
Date: Fri, 06 Nov 2015 09:54:46 +0100 [thread overview]
Message-ID: <3715539.QztuvljIIp@wuerfel> (raw)
In-Reply-To: <1446766883-25703-4-git-send-email-moritz.fischer@ettus.com>
On Thursday 05 November 2015 15:41:23 Moritz Fischer wrote:
> +/* Pin names for the E31x usecase */
> +#define E31X_TX_BANDSEL_2 "DB_1"
> +#define E31X_RX1B_BANDSEL_0 "DB_3"
> +#define E31X_RX1B_BANDSEL_1 "DB_5"
> +#define E31X_VCTXRX2_V2 "DB_7"
> +#define E31X_TX_ENABLE1A "DB_9"
> +#define E31X_TX_ENABLE2A "DB_11"
> +#define E31X_TX_BANDSEL_0 "DB_12"
Why not put the strings directly into the .dts files and change the
lookup table in the driver accordingly:
+static const struct pinctrl_pin_desc e3xx_pins[] = {
+ /* pin0 doesn't exist */
+ PINCTRL_PIN(1, "TX_BANDSEL_2"),
+ PINCTRL_PIN(3, "RX1B_BANDSEL_0"),
+ PINCTRL_PIN(5, "RX1B_BANDSEL_1"),
+ PINCTRL_PIN(7, "VCTXRX2_V2"),
That would save you the hassle of the three-way dependency between the
dts file, the driver and the header when you want to change something
going through three different maintainer trees.
arnd
next prev parent reply other threads:[~2015-11-06 8:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 23:41 [RFC 0/3] Adding support for NI Ettus Research USRP E3XX pinconf Moritz Fischer
2015-11-05 23:41 ` [RFC 1/3] Documentation: dt: Add devicetree bindings for NI USRP E3xx pinconf Moritz Fischer
2015-11-06 8:56 ` Arnd Bergmann
2015-11-05 23:41 ` [RFC 2/3] pinctrl: e3xx: Adding support for NI Ettus Research " Moritz Fischer
2015-11-06 20:56 ` Andy Shevchenko
2015-11-09 10:21 ` Linus Walleij
2015-11-10 3:55 ` Moritz Fischer
2015-11-05 23:41 ` [RFC 3/3] ARM: e3xx: Add header file for pinctrl constants Moritz Fischer
2015-11-06 8:54 ` Arnd Bergmann [this message]
2015-11-06 16:01 ` Moritz Fischer
2015-11-06 16:42 ` Arnd Bergmann
2015-11-06 17:55 ` Moritz Fischer
2015-11-06 20:28 ` Arnd Bergmann
2015-11-17 10:55 ` [RFC 0/3] Adding support for NI Ettus Research USRP E3XX pinconf Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3715539.QztuvljIIp@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=moritz.fischer@ettus.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox