Re: Re: [PATCH v2 1/2] dt-bindings: hwmon: Add Eswin EIC7700 PVT sensor

["Huan He" <hehuan1@eswincomputing.com>]

> > 
> > Add device tree binding documentation for ESWIN EIC7700 Process, Voltage
> > and Temperature sensor.
> > 
> > The EIC7700 SoC integrates two PVT instances for monitoring SoC and DDR
> > power domains respectively.
> > 
> > Signed-off-by: Yulin Lu <luyulin@eswincomputing.com>
> > Signed-off-by: Huan He <hehuan1@eswincomputing.com>
> > ---
> >  .../bindings/hwmon/eswin,eic7700-pvt.yaml     | 70 +++++++++++++++++++
> >  1 file changed, 70 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/eswin,eic7700-pvt.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/eswin,eic7700-pvt.yaml b/Documentation/devicetree/bindings/hwmon/eswin,eic7700-pvt.yaml
> > new file mode 100644
> > index 000000000000..f4ba228924fe
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/eswin,eic7700-pvt.yaml
> > @@ -0,0 +1,70 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/eswin,eic7700-pvt.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ESWIN EIC7700 PVT Sensor
> > +
> > +maintainers:
> > +  - Yulin Lu <luyulin@eswincomputing.com>
> > +  - Huan He <hehuan1@eswincomputing.com>
> > +
> > +description:
> > +  ESWIN EIC7700 SoC integrates embedded process, voltage and temperature
> > +  sensors to monitor the internal SoC environment. The system includes two
> > +  PVT sensor instances. The PVT0 monitors the main SoC power domain. The
> > +  PVT1 sensor monitors the DDR core power domain.
> > +
> > +allOf:
> > +  - $ref: /schemas/hwmon/hwmon-common.yaml#
> 
> FYI, including this is kinda pointless because you have the label
> property defined below and your "additionalProperties: false" blocks
> shunt-resistor-micro-ohms from being used.

I plan to keep the $ref: /schemas/hwmon/hwmon-common.yaml in use, change
the original additionalProperties: false to unevaluatedProperties: false,
and remove the label definition from our schema since it is already
provided by hwmon-common.yaml. Could you please confirm if this
modification conforms to the community standards?

> 
> > +
> > +properties:
> > +  compatible:
> > +    const: eswin,eic7700-pvt
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  label:
> > +    description:
> > +      Human readable identifier used to distinguish between different PVT
> > +      instances. Typically "pvt0" for SoC PVT sensor and "pvt1" for DDR
> > +      core PVT sensor.
> > +
> > +  resets:
> > +    maxItems: 1
> > +
> > +  '#thermal-sensor-cells':
> 
> > +    description: Thermal sensor cells if used for thermal sensoring.
> 
> You can drop this description if there's a resend, common properties
> used in the obvious way don't need any more info.

We will remove this in the next patch.

Thank you very much for taking the time to review the patch and for your
valuable feedback.

Best regards,
Huan He

> 
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> pw-bot: not-applicable
> 
> Cheers,
> Conor.
> 
> > +    const: 0
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - interrupts
> > +  - label
> > +  - resets
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    pvt@50b00000 {
> > +      compatible = "eswin,eic7700-pvt";
> > +      reg = <0x50b00000 0x10000>;
> > +      clocks = <&clocks 244>;
> > +      interrupts = <349>;
> > +      interrupt-parent = <&plic>;
> > +      label = "pvt0";
> > +      resets = <&reset 111>;
> > +      #thermal-sensor-cells = <0>;
> > +    };
> > +...
> > -- 
> > 2.25.1
> >