From: Tomasz Figa <tomasz.figa@gmail.com>
To: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Cc: Vikas Sajjan <vikas.sajjan@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
devicetree-discuss@lists.ozlabs.org,
sunil joshi <joshi@samsung.com>, Inki Dae <inki.dae@samsung.com>,
Tom Gall <tom.gall@linaro.org>
Subject: Re: [PATCH v4 5/5] ARM: exynos: dts: Add FIMD DT binding Documentation
Date: Tue, 26 Feb 2013 23:11:32 +0100 [thread overview]
Message-ID: <3726480.lf0XiLbqs9@flatron> (raw)
In-Reply-To: <512D2FBB.5090507@gmail.com>
On Tuesday 26 of February 2013 22:57:15 Sylwester Nawrocki wrote:
> On 02/26/2013 05:19 AM, Vikas Sajjan wrote:
> > ok thanks. Will modify the documentation as below.
> >
> > compatible = "samsung, exynos4-fimd"; for Exynos4 SoCs
> > compatible = "samsung, exynos5-fimd" ; for Exynos5 SoCs
> > compatible = "samsung, s3c64xx-fimd" ; for S3C64XX SoCs
> > compatible = "samsung, s3c24xx-fimd" ; for S3C24XX SoCs
> > compatible = "samsung, s5p64x0-fimd" ; for S5P64X0 SoCs
>
> There should be no wildcards in the compatible property. I guess we can
> just add the two first one above for now and leave other out for when
> someone actually adds support for these SoCs at the drivers.
>
> I suppose we could, for example, have something like:
>
> compatible = "samsung,s3c2410-fimd"; // for
> s3c2410 compatible = "samsung,s3c2440-fimd", "samsung,s3c2410-fimd"; //
> for s3c2440
>
> etc. But this really needs to be checked with the documentation
> in each case.
>
> > compatible = "samsung, s5pc100-fimd" ; for S5PC100 SoCs
> > compatible = "samsung, s5pv210-fimd" ; for S5PV210 SoCs
We should stick to the rule that compatible value should be named after
first specific SoC model in which this particular IP version was included.
So this is what I would suggest:
compatible = "samsung,s3c2443-fimd"; // for S3C24XX SoCs
compatible = "samsung,s3c6400-fimd"; // for S3C64XX SoCs
compatible = "samsung,s5p6440-fimd"; // for S5P64X0 SoCs
compatible = "samsung,s5pc100-fimd"; // for S5PC100 SoC
compatible = "samsung,s5pv210-fimd"; // for S5PV210 SoC
compatible = "samsung,exynos4210-fimd"; // for Exynos4 SoCs
compatible = "samsung,exynos5250-fimd"; // for Exynos5 SoCs
(All the hardware variants are taken from s3c-fb driver.)
Best regards,
Tomasz
next prev parent reply other threads:[~2013-02-26 22:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1360912200-26377-1-git-send-email-vikas.sajjan@linaro.org>
[not found] ` <1360912200-26377-6-git-send-email-vikas.sajjan@linaro.org>
[not found] ` <511E1008.6010308@samsung.com>
[not found] ` <CAD025yQokBbJwyFWeg8KwzTsE-4jgra5UhLuic5zJnQRt+GNTw@mail.gmail.com>
[not found] ` <5122A119.7070501@gmail.com>
2013-02-21 7:04 ` [PATCH v4 5/5] ARM: exynos: dts: Add FIMD DT binding Documentation Vikas Sajjan
2013-02-22 7:06 ` Vikas Sajjan
2013-02-22 21:37 ` Sylwester Nawrocki
2013-02-26 4:19 ` Vikas Sajjan
2013-02-26 21:57 ` Sylwester Nawrocki
2013-02-26 22:11 ` Tomasz Figa [this message]
2013-02-26 22:48 ` Sylwester Nawrocki
2013-02-22 22:10 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3726480.lf0XiLbqs9@flatron \
--to=tomasz.figa@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=inki.dae@samsung.com \
--cc=joshi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=tom.gall@linaro.org \
--cc=vikas.sajjan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).