From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1D12C433FE for ; Thu, 3 Nov 2022 12:32:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231665AbiKCMca (ORCPT ); Thu, 3 Nov 2022 08:32:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231659AbiKCMcZ (ORCPT ); Thu, 3 Nov 2022 08:32:25 -0400 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16F9E10544 for ; Thu, 3 Nov 2022 05:32:22 -0700 (PDT) Received: by mail-qk1-x72a.google.com with SMTP id z30so942480qkz.13 for ; Thu, 03 Nov 2022 05:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=89rx9VoTuC7g0qdb+V9KXopipeQYjCJGbZv00TdzOE0=; b=o5XhGT3dISsj0AhS0b8oU+q8yJWUjiD72PhTzij8ETk1QUUINlo6rvo8zmajQJGfo+ zw6P6xP6WrXb3robzpR0tTKmrWWsIKPkAUAYt8KNBf0QMt8XJ/wAew8nk2YEkzz0Ddc+ cx+lqnvGPpUEJwspAMnxEDd/i7SwSTC4eND6ks7RF1dTo7x1eDxgVrLfHhTGRhoT8xEX LPgHAhnHd6tLdJjnFXlre+9s5AQ7OUl4qwXGt/1X9ofKUQ420k8icdNc5gy6q/zkhJNM YBbSSEiITM/KxP65d9YzXQjV51o9iMAeWNAYN9T2vMZfPM4FXdoDWdTmnLOODPS+GaB2 KC3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=89rx9VoTuC7g0qdb+V9KXopipeQYjCJGbZv00TdzOE0=; b=P3VxJw+gftreMm0+ZiIrTEvgjh44m9LCGV75uiJDnnwlS0RaaNzAnUgaGlOkyhbWr1 9HPO8UPOFCjJ0Sh9hi3LWxnerU9q7Wh0ukDanM9lpgbxFAhSMK0UONB3FfDEC0b0jmkh VZNM2QNX+uzfT+evPYf/ZgOHdZg13lbhyoCogIokqwwUI4V7+OWVUHd5WElw0OlrTbNz H4l6DfgxsssjdaXz9fJ+xZLCyUFqsIVnCV5niweZ3PjAXwYTRNQKVGF9pW8MnX+AT9Z9 Ata0b4NInpHg58MsDX/S69mhEPfyHO4ZyuDLZ2Sej4v4WAXeeKknqMwo9f0Ge/yhIfHo IwdQ== X-Gm-Message-State: ACrzQf3ce1l1ndY+Z1bsbBzS8lMQDKRBJgnEO3QI1j2H6SmDqggI33vn EZb+/E3LgGY/lttQDa/glG1qyQ== X-Google-Smtp-Source: AMsMyM7hhWYMwJIM/iYR0o/zA8dGOdK9n2c0soG1TcplmfzHJ5MkF8+DyVZ18OIDEmGq/K2JbY6Wtg== X-Received: by 2002:a05:620a:4146:b0:6fa:c8e:b60 with SMTP id k6-20020a05620a414600b006fa0c8e0b60mr22054168qko.454.1667478741073; Thu, 03 Nov 2022 05:32:21 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:a35d:9f85:e3f7:d9fb? ([2601:586:5000:570:a35d:9f85:e3f7:d9fb]) by smtp.gmail.com with ESMTPSA id cn6-20020a05622a248600b0035cd6a4ba3csm450573qtb.39.2022.11.03.05.32.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 05:32:20 -0700 (PDT) Message-ID: <372b6da1-62a7-6204-5d02-8a4abb22c4ab@linaro.org> Date: Thu, 3 Nov 2022 08:32:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 1/3] arm64: exynos: Add new compatible string for Exynos3250 SoC. To: Aakarsh Jain , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, smitha.t@samsung.com References: <20221102130602.48969-1-aakarsh.jain@samsung.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20221102130602.48969-1-aakarsh.jain@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/11/2022 09:06, Aakarsh Jain wrote: > Exynos3250 uses the same compatible as Exynos5420, but both > the MFC IPs found in these SoC are different interms of clock > property. So using same compatible for both SoC is not correct. > Lets have a separate compatible for Exynos3250 and Exynos5420 > to differentiate these SoCs. > > Suggested-by: Alim Akhtar > Signed-off-by: Aakarsh Jain > --- > Documentation/devicetree/bindings/media/s5p-mfc.txt | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Use subject prefixes matching the subsystem (git log --oneline -- ...). > > We are already in process of converting this txt file to yaml. > https://patchwork.kernel.org/project/linux-media/patch/ > 20221011122516.32135-2-aakarsh.jain@samsung.com/ > modifying this txt binding for completeness. > > diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Documentation/devicetree/bindings/media/s5p-mfc.txt > index aa54c8159d9f..4ff1898e5a51 100644 > --- a/Documentation/devicetree/bindings/media/s5p-mfc.txt > +++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt > @@ -11,9 +11,10 @@ Required properties: > (a) "samsung,mfc-v5" for MFC v5 present in Exynos4 SoCs > (b) "samsung,mfc-v6" for MFC v6 present in Exynos5 SoCs > (c) "samsung,mfc-v7" for MFC v7 present in Exynos5420 SoC > - (d) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC > - (e) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC > - (f) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC > + (d) "samsung,exynos3250-mfc" for MFC v7 present in Exynos3250 SoC This should be followed by mfc-v7 fallback. > + (e) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC > + (f) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC > + (g) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC > > - reg : Physical base address of the IP registers and length of memory > mapped region. Best regards, Krzysztof