From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A152BC76196 for ; Mon, 3 Apr 2023 06:39:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230414AbjDCGjj (ORCPT ); Mon, 3 Apr 2023 02:39:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbjDCGji (ORCPT ); Mon, 3 Apr 2023 02:39:38 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70D581729; Sun, 2 Apr 2023 23:39:37 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 38B2424E14F; Mon, 3 Apr 2023 14:39:29 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 3 Apr 2023 14:39:29 +0800 Received: from [192.168.125.82] (183.27.97.179) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 3 Apr 2023 14:39:28 +0800 Message-ID: <374e7ebd-bf39-2792-2847-24b14d1d871d@starfivetech.com> Date: Mon, 3 Apr 2023 14:39:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 2/3] phy: starfive: Add mipi dphy rx support Content-Language: en-US To: Vinod Koul CC: Conor Dooley , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Jack Zhu , , , , References: <20230223015952.201841-1-changhuang.liang@starfivetech.com> <20230223015952.201841-3-changhuang.liang@starfivetech.com> <2aa1bdbd-e37e-941a-9422-0908545c14f7@starfivetech.com> <0dd5e35b-512e-41ed-af33-f94b7e2868c1@spud> From: Changhuang Liang In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.179] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/4/3 14:34, Vinod Koul wrote: > On 03-04-23, 14:31, Changhuang Liang wrote: >> >> >> On 2023/4/3 14:24, Conor Dooley wrote: >>> On Mon, Apr 03, 2023 at 09:39:00AM +0800, Changhuang Liang wrote: >>>> On 2023/3/31 21:52, Vinod Koul wrote: >>>>> On 21-03-23, 14:08, Changhuang Liang wrote: >>>>>> On 2023/3/20 20:37, Vinod Koul wrote: >>>>>>> On 22-02-23, 17:59, Changhuang Liang wrote: > >>>>>>>> +static int stf_dphy_configure(struct phy *phy, union phy_configure_opts *opts) >>>>>>>> +{ >>>>>>>> + struct stf_dphy *dphy = phy_get_drvdata(phy); >>>>>>>> + int map[6] = {4, 0, 1, 2, 3, 5}; >>>>>>> >>>>>>> what does this mean? >>>>>> >>>>>> This is the physical lane and logical lane mapping table, should I add a note for it? >>>>> >>>>> Yes please. Also will the mapping be always static or ever change? >>>>> >>>> >>>> The mapping is always static on the visionfive2 single board computer. >>>> Thanks for your comments. >>> >>> What about other boards featuring a JH7110? >> >> maybe add this mapping in the device tree, we just need to parse the device tree is better. > > If the mapping is hw description then yes it makes sense > Yes, different hardware may be described differently, I will change it in next version.