From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34CE13E92BC for ; Wed, 27 May 2026 13:33:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779888784; cv=none; b=Vh95wwk+p0FhTrz+I9zA/5gmutiqfZEA8H4rjzLC05UNtobR1W4D7/oHuKCIU0dBtGmaU5rz53sl2FygrzYRlhBBnrYbY6TM6sDRpA+2WHp9na5vdsUe97tjE87rIYvDd66xp58WUOj22nnAU2csU9czd9BY7QzBscPvDtNXGls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779888784; c=relaxed/simple; bh=GeKLc7/+dJvLDIky390YOmE9RaNQtsnp6BD0MQMUEeQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X+1mEiSleItSoXyNTveqMVcrhNv8vqOqL6PgpKp55Z7gsyztRFGvvJolJrOJY+TSnN64bdOIFAtrt5/uUHGakPfUnXQi9xw+KX7uSrEGdhhIiAXGW0Fq0CU7baUcpvL+kJDfgfQSlXf5sSIMwiFyF0vQ2NacdGebH0p3WI+woeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WHfLAHLX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BMaBncSq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WHfLAHLX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BMaBncSq" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64R9qxNr195636 for ; Wed, 27 May 2026 13:33:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CL59JHQMdaZ9xSO2ZRHaR8OddiR/bapur84ZCcORKo0=; b=WHfLAHLXddp08c3h sDZgxxFDiMINQqglTS+vQtgTGGoCi4s6zyQWM9ft+o1zGgHOPqfAL9ufQmBcn0CX Z+C/ul4DgBa5BR7KVgqtzDmlvYDqik6jWm8gvRj1Vtt8t+G97DUNJQFM819RWyvr 5CyIJiYWGpjsfHHXfZlmGyNbhe/bwFRLXwT4wqhfzuaxLGkCT03J+fNlIlpcTTGC rQlFVzv+oy+FbWzkzKuTt+4/QOvz7ImiBwkW4JSs88Evbn4X2ZcspqUhoeG/70Kj XbeNXO3m4GMXQyGsV/ggtSud/dN3/BHMbfGA9S2t1ZlFls4kcHTRPln9axtEI3c0 CHJOZg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4edxce8qtw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 27 May 2026 13:33:01 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c8292e18166so5704120a12.3 for ; Wed, 27 May 2026 06:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779888781; x=1780493581; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CL59JHQMdaZ9xSO2ZRHaR8OddiR/bapur84ZCcORKo0=; b=BMaBncSqr6ifLU39d2icZY0JyVpxzVJD/8EtWg+K2iLMyhpo29/Z+GqGbVcyiRQsgk S94JEbnh9sb8/PiYo3ZsiXPSZVXjE2r+tP/ZBdlj/LGjIKxXvCXl86TmE1Ya3jvSGXSf uoLwuXF7LnKrr51Kvrn0KvoEb9xaWnxJQBW3pvSfT3oYdGDk39MQnEGy0YE+oA3gcZsb f81VdlYTpObAZYgmmLy/zMP/s1pbxGLJ5WWB8ZH05Uiy8z6Yunc0DcR3zH8vVmGBz3+/ aNGh5OECPF47rTkbBRFRp++jXz5w8F6/ISLPtQKmCXT+YEJZJoHs+OJo2ri6ZSaC5jad RJhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779888781; x=1780493581; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CL59JHQMdaZ9xSO2ZRHaR8OddiR/bapur84ZCcORKo0=; b=qyQk5G36HIEb3qbEu4SHcjEv0/Xz4U1pX13P6JwkBpbDUXtntSjD0qWDCUcfElaV/l 6bjjskB0aO7P1+SR8J+4F6OCYI+II7F4SOopvwU19oeQrelFHGXOLXwvfcyeSCVp+bGI ZJsNfGrAiAc9dzfF0ldjrN8bAeOjMiMUxhC7zWY1vuu053lrc5LN/fNxwURK56wcUVE2 VkNu/t0QfExTdPPQNu7l2Av06Pya9fUJ0WCbV+7HUWsiluFY4Q+VT90nfk+8wjdyva2o nnDxl3rxSLQ30JdjixDROAzEqyiAD4FTFJjaR5rSW9cJyEV/4rT84y9LRFggAkAOK9t0 P+5A== X-Forwarded-Encrypted: i=1; AFNElJ9lJIPrhp82HwLQ97+0B+Hyb0YjtD2GHxQslpfmGtP7vXSA+pm6xcvs/LiLcpuLbrvM5A+eGmONdBbd@vger.kernel.org X-Gm-Message-State: AOJu0YwDC5O84ZMdtwEnF+6iPC61oLe7XxziG066mrOvxyLdPw5Zkw1j nkVjtAWIQqFfYh4txnyhCBQxgE23YEoI4mQHp0QxzNL8wO93v1GKnnQ+qZrdfoe8tL7k0WQJa6f KzMdVp2jUSsLxp3q8+KkpHzaL+9gkPvQGitqotczMslozYTH8ZYyFY4YoBbhAPpPg X-Gm-Gg: Acq92OFDZFU3zK6tkGebSv8tQ10tf2Hk144JC4+ErWvQFW641W33DRzimGfm6mUFsib ZDWFrBdLa3tPDxnThOVYHgcwaTkhCAJwTeqAhnvZuErT8iSo9T4KuwymfdYJ2nOKPHEmZgVMLwW b7Wy9sT5MLcY3jjt9InXBjE4uCXoVj8Pb+2dzZHPloMaMv3AYjkiiCDz1aACamC6CA0mciLhNp4 nbAlTLpqA/tXOIjhTReqOoX3iejZVBTsvP22wJBFVRA0qAsgifAevMh8QM7o2nEbF7HU4GYMLWu 2TmlxczMPSBv4rJLBiIFnVrAbB/0VMPgOiexBW4xCuWjyzlow2e1DuIZldcOYr8LyNi+tnbwBLM mNkxY98Bm60GDO4Vh9FlSu1HuzC/H0y90iv+70VbH90dqX0Ix X-Received: by 2002:a05:6a00:124d:b0:835:cc47:6ff8 with SMTP id d2e1a72fcca58-8415f3a54bemr21955248b3a.45.1779888780758; Wed, 27 May 2026 06:33:00 -0700 (PDT) X-Received: by 2002:a05:6a00:124d:b0:835:cc47:6ff8 with SMTP id d2e1a72fcca58-8415f3a54bemr21955194b3a.45.1779888780182; Wed, 27 May 2026 06:33:00 -0700 (PDT) Received: from [10.219.57.29] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841d6e80288sm2663478b3a.10.2026.05.27.06.32.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2026 06:32:59 -0700 (PDT) Message-ID: <3758be2d-4553-40b3-8ae6-bc3e502d0531@oss.qualcomm.com> Date: Wed, 27 May 2026 19:02:53 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/5] arm64: dts: qcom: Add Shikra CQ2390M SoM platform To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Neil Armstrong , Wesley Cheng , Ulf Hansson Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-mmc@vger.kernel.org, monish.chunara@oss.qualcomm.com, Rakesh Kota References: <20260522-shikra-dt-v3-0-80ffde8a3dc4@oss.qualcomm.com> <20260522-shikra-dt-v3-3-80ffde8a3dc4@oss.qualcomm.com> <63752557-6468-4aef-a847-06aa39ce108d@oss.qualcomm.com> Content-Language: en-US From: Komal Bajaj In-Reply-To: <63752557-6468-4aef-a847-06aa39ce108d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 5PMtxpsrMznHe3RhgQxtJS8PPyqNmgNj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI3MDEzMiBTYWx0ZWRfX/H9MCidUgkWI 6+c5l/LYHzuKgGNJgnQi/+Qfxcag3zqRG3AMLHYvxxRa7moSD2ceCVOJggbwN7Kc1NeUCMlrgfG RTFw3RVrv8wdCj+W9bdXh8WDmZ2Db0dxjOWWH2ViEEjsM0gd0zMITr8UhjvoyM0pO5Yfd2nW40Q HCfSpHHrSx2654pBkMRwy6qGSczc2pH0pU/JzSlJFVVaO6EvvkvP135ZUf9sbFOI03/qFdtZpIM GTYM7Ga/3Z72TP6hOHY4PtSCOZtLYiiUI/nlve4iKpgE0pUKvbLyGTpzm6bw/U+l7pzzZgwK+Fi CpQ5Oy08MLm6GwZ2j4P3Uy9DylcKMQnfYk6aIRBON4QznwfK62kcgPQjYYOqRmVwn0eY0V+B/UH QTXN7kNxObUzyh5Bl1VPoe9Tsk3FCD1NbDuwk47lDob6tnc1rm9xAKR2VKSAwdiw1UbbxnZKwVA 68iobcZ4UQK3l4+JLTQ== X-Proofpoint-GUID: 5PMtxpsrMznHe3RhgQxtJS8PPyqNmgNj X-Authority-Analysis: v=2.4 cv=SIpykuvH c=1 sm=1 tr=0 ts=6a16f28d cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Ze1idgdxkBYruiX_gtsA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-27_02,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 adultscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605270132 On 5/25/2026 6:46 PM, Konrad Dybcio wrote: > On 5/22/26 8:02 PM, Komal Bajaj wrote: >> Add device tree include for the CQ2390M variant of the Shikra >> System-on-Module, a compact compute module integrating the Shikra SoC >> and PMIC for IoT applications, designed to mount on carrier boards. >> >> - shikra-cqm-som.dtsi: Retail SoM with modem (PM4125 and PM8005 PMIC) >> >> The DTSI includes the common shikra.dtsi, adds PM4125 and PM8005 PMIC >> regulator definitions specific to this variant. >> >> Co-developed-by: Rakesh Kota >> Signed-off-by: Rakesh Kota >> Signed-off-by: Komal Bajaj >> --- > [...] > >> +/ { >> + gpio-key { > This is usually 'gpio-keys', reglardless of the amount ACK > >> + compatible = "gpio-keys"; >> + label = "gpio-keys"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&vol_up_n>; > property-n > property-names > > in this order, please Yes, i will correct this. > > [...] > >> +&pm4125_resin { >> + linux,code = ; >> + status = "okay"; > A \n before 'status' is customary ACK > >> +}; >> + >> +&pm8005_regulators { >> + status = "disabled"; >> +}; > ? Already there's an ongoing discussion over the thread [1]. PM8005 regulators are controlled by rpmpd so it's not expected to be enabled here. [1]: https://lore.kernel.org/all/20260525093453.edmqryggp5kcqxxy@hu-kotarake-hyd.qualcomm.com/ > > (also double \n below) Will remove it. Thanks Komal > > Konrad