devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH v4 03/10] dt-bindings: display/msm: move qcom,sc7180-mdss schema to mdss.yaml
Date: Thu, 25 Aug 2022 17:37:43 +0300	[thread overview]
Message-ID: <375daf2f-9b8b-597f-41ae-b5be27e22e80@linaro.org> (raw)
In-Reply-To: <b01585c9-1810-2f25-d4dd-bea31b685e79@linaro.org>

On 25/08/2022 15:40, Dmitry Baryshkov wrote:
>>>     clock-names:
>>>       items:
>>> +      - const: bus
>>>         - const: iface
>>> -      - const: ahb
>>> +      - const: rot
>>> +      - const: lut
>>>         - const: core
>>> +      - const: vsync
>>
>> All these changes point that device schemas are simply different and
>> trying to unify them is not correct approach.
> 
> I'm not going the argue the mdss-common + platform specifics, but please 
> note that these changes are coming from me removing one extra level of 
> depth in dpu-smth.yaml. Currently these files have both mdss and dpu 
> devices, I'm stripping the mdss out of them.

True, it's second time I got myself looking at wrong part of diff hunk.
Still your allOf:if:then grows with different cases. I guess the biggest
differences came with sdm845 and later only children and clocks differ.

Best regards,
Krzysztof

  reply	other threads:[~2022-08-25 14:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25  9:50 [PATCH v4 00/10] dt-bindings: display/msm: rework MDSS and DPU bindings Dmitry Baryshkov
2022-08-25  9:50 ` [PATCH v4 01/10] dt-bindings: display/msm: split qcom,mdss bindings Dmitry Baryshkov
2022-08-25 11:51   ` Krzysztof Kozlowski
2022-08-25 11:55   ` Krzysztof Kozlowski
2022-08-25  9:50 ` [PATCH v4 02/10] dt-bindings: display/msm: move qcom,sdm845-mdss schema to mdss.yaml Dmitry Baryshkov
2022-08-25 11:59   ` Krzysztof Kozlowski
2022-08-25  9:50 ` [PATCH v4 03/10] dt-bindings: display/msm: move qcom,sc7180-mdss " Dmitry Baryshkov
2022-08-25 12:01   ` Krzysztof Kozlowski
2022-08-25 12:40     ` Dmitry Baryshkov
2022-08-25 14:37       ` Krzysztof Kozlowski [this message]
2022-08-25  9:50 ` [PATCH v4 04/10] dt-bindings: display/msm: move qcom,sc7280-mdss " Dmitry Baryshkov
2022-08-25  9:50 ` [PATCH v4 05/10] dt-bindings: display/msm: move qcom,qcm2290-mdss " Dmitry Baryshkov
2022-08-25  9:50 ` [PATCH v4 06/10] dt-bindings: display/msm: move qcom,msm8998-mdss " Dmitry Baryshkov
2022-08-25  9:51 ` [PATCH v4 07/10] dt-bindings: display/mdm: add gcc-bus clock to dpu-smd845 Dmitry Baryshkov
2022-08-25  9:51 ` [PATCH v4 08/10] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml Dmitry Baryshkov
2022-08-25  9:51 ` [PATCH v4 09/10] dt-bindings: display/msm/dpu-common: add opp-table property Dmitry Baryshkov
2022-08-25  9:51 ` [PATCH v4 10/10] dt-bindings: display/msm: add support for the display on SM8250 Dmitry Baryshkov
2022-08-25 20:11 ` [PATCH v4 00/10] dt-bindings: display/msm: rework MDSS and DPU bindings Rob Herring
2022-08-25 20:45   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=375daf2f-9b8b-597f-41ae-b5be27e22e80@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=airlied@linux.ie \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).