From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BAF240F74B for ; Fri, 28 Aug 2026 12:37:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787920663; cv=none; b=LerqgmO/1UQ3Jcoy3WQawNr0x0k57fjxJneeqf1oSBIkk7reVN5WLaGPkn/Bb94z8SB1PDDEQcBherHzA3d1xVedJP2XyKfcAhS4rRyF76MPDzGkDAIOwmIDlYt/gZ4RCLg9vURLk8do6on2f1X7UCqNkecuc2KmVAesWQFl9ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787920663; c=relaxed/simple; bh=xNHLosBmH0XiPfdIaRXd6JhnDcpZkYxuucgrupLtItA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TJ36HZNt/5PUWCEuPsEvjCkKM05MysRTBoLchcieG5XZkqq/BcbSe+l6wq5LIJ1ZeWNBNSEzBzQatFMS9Q9nzue1LGSLSc8gi2k+fwZMuKf1Lz5Z2kye2TVaxTUvNtgb5X30kyHiUlrNUiiHVyurAeiAjbRP1VQ+sYd8Q+3zARM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pu4t0v3w; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d0KO1epa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pu4t0v3w"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d0KO1epa" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67SA8Knc2798385 for ; Fri, 28 Aug 2026 12:37:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sVGs2yC+wr0Kx/gwM5INziNp+kp+s6je+k96BIrufmQ=; b=pu4t0v3wCfoosE9g dXq2hXl7rqTokh70/S9oWaNHqcyT9htAUIagX+Jxg0eotImdPdpDr5czgi3m2yfP iTXVBZMG/2uW54FGGSdbgq3EShkLNbJIZfoLOuKPv6dUWRxiJDbSpRlJt5QiVkmj XHC4OtdSBLwylx+7UO389Q/gz4DKCzZcmdj87VuQ3B5YGgrT3D+INrloYYFT4OQl oGjrX3bfRFXH30g0q5wBNjuB6avveEfAUqfQyRQZO+eyJoQpvXFfGuaLXkOMJErc Y5wG8T9rzp3Afw9DUiu7YxnxxahEL6UIbFNHU5ZVQh0nVADplY/0FWfd9vFamk6w WNI+/Q== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gb62h171g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Aug 2026 12:37:36 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-52d827597fbso11923441cf.0 for ; Fri, 28 Aug 2026 05:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787920655; x=1788525455; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sVGs2yC+wr0Kx/gwM5INziNp+kp+s6je+k96BIrufmQ=; b=d0KO1epaU8XadrPPfdEnBz5mZ+zmR4a5nNTQK6eWGn8bi0pjf8Umt3e6LQSot/EPM6 MmroY4LZxh/sfhr6gjWeuATV2xyiPCPtrGxTuDstrGag/4qsnAyiSbu1ERL6KGwCHmfU iynx4zTe08TgNB45J3wl16knw9axvMXUmzmNR3bo76qF6u74Mub6qE46bFBgxN/O0Hw/ 0gwrG2VJ2p2VoaLfxB5shmpMjJdihh0XBXWZUQM8O6BvQ+lZLbWNED9FyTwxniNrag1x 8DzYOsLPxT8wWJ76y34yR9n4CxzWiTvi90Op8JpH/3DOHnmBLHqp4zLvFv6j3KSfWcqe Uwiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787920655; x=1788525455; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sVGs2yC+wr0Kx/gwM5INziNp+kp+s6je+k96BIrufmQ=; b=Cw/4JcWEynuX3zbwHBX36/n2Dn5YzGPvKGITu9OaZZjz0+GKkmktHZEl78inXoo6zr OSZWShcknYWzsB3EJg98kVxYW8YxHrmN1YHKX/bPmBIDxtvpwrm/8SPac2/FeINbz+J3 P4KPKf6P1JZS2ZhtyeTjR6hIZEr2xRgpbrSVKX3T3/fUccab3M6lU88z+y6om42jcxXH mGVHqe6JS61vr3X5/an2zEoxWk8cdYZsEtuU3a64TsqfFjj9731JUdu3RqPq6SKgb+VH 0ooAgXWvJt8oTE1WA6GZxWsUxsIFCIy71r4HmB3V7t5CUrThJ2OeHz8yHUck2wITbIio wNOA== X-Forwarded-Encrypted: i=1; AHgh+RoOtxbR9lycHlk/UadrNjbpTd2yiZyz24Le38XeCL0ZJ2pqULWpLKYySgDKepYcJlG9RPyHbkDKQ5AX@vger.kernel.org X-Gm-Message-State: AFuF++k5nM+U5yvTY0oRUOB2EW8aAy5mQ5iWn020FqbR0t0s3AMmWgzN 4wRlhe0NAhfOnrjhiGs0aB54wX7Bi1XaXTD82oig7BsQJWGjq2nv64khRBt+a5Bcwsru5KX4TK3 lLIIrqCQWosvMiCvXY01z0/Ed0vE7GQ58PWGAn5oe95asBeRXvc2Sx4iK7Fypjzp2 X-Gm-Gg: AR+sD10dB+fLV0NtvvBLQs3NWWW7jwGkthILgs9tm0kYHy3OdVoQE9FXwCBccLLzE6Q YyPyUAmAeAE3WO2EJGCL9I74qMsp0KJr1N5PsOZKJXpw/FL+Gv1tkV088nT2tBQ1F2BwverV2ie DuAgHlJQWu8X4ViwtcqtS7v3RSbPRCWufIwbg+8QFmrSd0o8GsxFc9ePsaX3dL/8wjtLI9HW30n 23JyJulSUUgmovvnA23vVsCf1hO1PseOd+GAWIVJVnZB+JxqkTX5kvSERGxrAds9S6AXkhD4EVQ gASSZNtBfL08/IBAdfT2Rk9A+NTrmFGRKLSELC0PHAJMGrefGI0YMxyoKgnMW5+Gk5qCZEs2fe8 9OY9HNtn2jIhuZjGK5xujQAR/274= X-Received: by 2002:a05:622a:1f95:b0:52d:ea18:a9c with SMTP id d75a77b69052e-52fb96ae584mr81958521cf.34.1787920653699; Fri, 28 Aug 2026 05:37:33 -0700 (PDT) X-Received: by 2002:a05:622a:1f95:b0:52d:ea18:a9c with SMTP id d75a77b69052e-52fb96ae584mr81957671cf.34.1787920653235; Fri, 28 Aug 2026 05:37:33 -0700 (PDT) Received: from [192.168.68.119] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49b95013d06sm66837655e9.12.2026.08.28.05.37.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 05:37:32 -0700 (PDT) Message-ID: <375dfd48-4351-445b-890f-cbf3a835f65a@oss.qualcomm.com> Date: Fri, 28 Aug 2026 13:37:31 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/9] ASoC: dt-bindings: qcom,qaif-cpu: Add binding To: Harendra Gautam , Srinivas Kandagatla Cc: Mohammad Rafi Shaik , Mark Brown , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prasad Kumpatla , Krzysztof Kozlowski , Sarath Ganapathiraju , Kumar Anurag Singh References: <20260824063627.3595610-1-harendra.gautam@oss.qualcomm.com> <20260824063627.3595610-2-harendra.gautam@oss.qualcomm.com> <08b6fd88-84b3-4b3f-a8c5-dd6bfd39403f@oss.qualcomm.com> <137d4a06-4542-488d-91e2-d338ffb9d47d@kernel.org> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODI4MDEwOSBTYWx0ZWRfX+BL2VEiSBmfL AqppuyxY0btyrObR6BJq1RxIAS4FxmaiI5Ebsoof+b/WAQKrg29fjTzlzXM2bKS5eXZtAIhPSum 8xpdqxwPXMfvwjzIwbqO9K9Z43cuYWc= X-Proofpoint-GUID: L22D7Zwj1_-lKF4-RKN3w7dIx9NG3EeC X-Proofpoint-ORIG-GUID: L22D7Zwj1_-lKF4-RKN3w7dIx9NG3EeC X-Authority-Analysis: v=2.4 cv=I5dVgtgg c=1 sm=1 tr=0 ts=6a918110 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=P-IC7800AAAA:8 a=bIOyMTNkgNfJq1KbeLIA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI4MDEwOSBTYWx0ZWRfX5/169IDwllvS 3QNMRmtcv+IQ8+/UwNdaJJINqiZbNrauxjYNr2KOtC15vATTJ1xz3GgoprEW5cmjQzrTqGEBiIT GDQfIgigBvnpsnJWuMbVeiLe/NfM/hosiuoMGlffj4u9VenkwgD3L8nKs9lLP5mr0H/eKEDQ/Iv LT/EROTZS6momtspCOtjCOcIARWDJD/wkMWsCeR6wNftNUSuWosgAl8BirtvhzHuZqOH9oRFT5b jbX+Q+dghq2qvDGSOKFFLHyEjruSv51T+fsDz7yN91drUg2PZNSYDXFCB4nTsxSu8F4abrDGkdL I8kE4e7rWJGSclsDjoppjbeklc9Zp3XvtKhXQ85a7E3dnTBnOWOSk+AvAytdaGBkBuSYKAJeETs hlQBYCk7d67LpFqCP3Nt7/mb6YIfPGYZXufD+UhQNoPeULwr7BGH3tnj4DdUptxPuGEJ5voruGK ysyqZSrWpnPCDt42WrA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-28_03,2026-08-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608280109 On 8/28/26 9:58 AM, Harendra Gautam wrote: >>>>>>> +#define QAIF_CDC_DMA_VA_TX8 254 >>>>>>> +#define QAIF_CDC_DMA_VA_TX9 255 >>>>>>> + >>>>>> These DAI IDs exceed the LPASS_MAX_PORT limit, which will cause sound >>>>>> card registration to fail. >>>>>> >>>>>> Check sound/soc/qcom/common.c, as the current indices (246-255) are >>>>>> beyond the supported LPASS port range. >>>>>> >>>>>> Best Regards, >>>>>> Rafi. >>>>> Thanks for pointing this out. We can either add the range check for >>>>> min/max QAIF DAI IDs in qcom/common.c or introduce a common helper in >>>>> qcom/common.h to validate the supported DAI IDs across Qualcomm >>>>> platforms. >>>> >>>> You should add these ids to >>>> include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h instead to avoid >>>> conflicts with common code. >>>> >>>> --srini >>> Thanks for the suggestion. qcom,q6dsp-lpass-ports.h is specific to Q6 >>> DSP/AFE virtual port IDs. Since QAIF is a direct MMIO driver with no >>> Q6 DSP involvement, would adding QAIF IDs there not be misleading? >> >> These are IDs that will be reused across both dsp and non-dsp solution. >> So it makes more sense to keep it in one single place to allow the >> hardware description (DT) unchanged across different software solutions. >> >> >>> would it be better to update the range check in common.c/common.h to >>> accommodate both LPASS and QAIF DAI ID ranges instead? >> No, that does not make sense because these numbering might conflicting >> with other ports in future. >> >> --srini > Srini, could you please confirm if adding QAIF DAIs to > qcom,q6dsp-lpass-ports.h is acceptable given that it increases > LPASS_MAX_PORT by 56 (from 149 to 205), which indirectly grows > multiple arrays sized by AFE_PORT_MAX and APM_PORT_MAX in other BTW, the dai ids are already added by Prasad https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h?h=next-20260827#n240 You should use them. to your question about increase in size, yes, this is know issue, i have some changes to send which will remove the need of this static array which should fix the concerns. But for now all the hardware dai ids for qualcomm SoCs should be in a single place irrespective of dsp or non dsp solution. --srini > drivers eg below > https://elixir.bootlin.com/linux/v7.2/source/sound/soc/qcom/qdsp6/q6afe-dai.c#L30 > https://elixir.bootlin.com/linux/v7.2/source/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c#L21 > -Harendra