From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4B84EE49A0 for ; Wed, 23 Aug 2023 12:39:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233376AbjHWMjP (ORCPT ); Wed, 23 Aug 2023 08:39:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232906AbjHWMjO (ORCPT ); Wed, 23 Aug 2023 08:39:14 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 840C3E40; Wed, 23 Aug 2023 05:39:11 -0700 (PDT) Received: from i53875a83.versanet.de ([83.135.90.131] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qYn8T-0003UY-66; Wed, 23 Aug 2023 14:38:57 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Rob Herring , Krzysztof Kozlowski , Jakob Unterwurzacher Cc: jakob.unterwurzacher@theobroma-systems.com, Ermin Sunj , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] TSD: arm64: dts: rockchip: use codec as clock master Date: Wed, 23 Aug 2023 14:38:56 +0200 Message-ID: <3763479.7s5MMGUR32@diego> In-Reply-To: <20230823122000.585787-1-jakob.unterwurzacher@theobroma-systems.com> References: <20230823122000.585787-1-jakob.unterwurzacher@theobroma-systems.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Jakob, the change itself looks ok, but there are some logistic changes needed. For one, please drop the local TSD prefix from patches submitted upstream. The patch subject should be something like arm64: dts: rockchip: use codec as clock master on px30-ringneck Am Mittwoch, 23. August 2023, 14:19:59 CEST schrieb Jakob Unterwurzacher: > From: Ermin Sunj > > If the codec is not the clock master, the MCLK needs to be > synchronous to both I2S_SCL ans I2S_LRCLK. We do not have that > on Haikou, causing distorted audio. > > Before: > > Running audioloopback.py script on Ringneck, 1kHz > output sine wave is not stable and shows distortion. > > After: > > 10h stress tests audioloopback.py failed only one time. > That is 0.00014% failure rate. > > Signed-off-by: Ermin Sunj As sender of the patch you need to add another Signed-off-by line of your own. With this you indicate that you were allowed to submit the patch. So this needs two SOB-lines, one for Ermin as the original author and one for you as the submitter. Probably same for the second patch. Thanks Heiko > --- > arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts > index 3a447d03e2a8..dafeef0c2dab 100644 > --- a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts > +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts > @@ -68,8 +68,10 @@ i2s0-sound { > simple-audio-card,format = "i2s"; > simple-audio-card,name = "Haikou,I2S-codec"; > simple-audio-card,mclk-fs = <512>; > + simple-audio-card,frame-master = <&sgtl5000_codec>; > + simple-audio-card,bitclock-master = <&sgtl5000_codec>; > > - simple-audio-card,codec { > + sgtl5000_codec: simple-audio-card,codec { > clocks = <&sgtl5000_clk>; > sound-dai = <&sgtl5000>; > }; >