Devicetree
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>, linux-arm-kernel@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
	Yunfei Dong <yunfei.dong@mediatek.com>,
	Qianqian Yan <qianqian.yan@mediatek.com>,
	devicetree@vger.kernel.org,
	gtk_ruiwang <gtk_ruiwang@mediatek.com>,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: mt8173: fix vcodec-enc clock
Date: Fri, 15 May 2020 17:28:20 +0200	[thread overview]
Message-ID: <3769d9da-9465-61ca-7ae5-39ef4ef52e85@gmail.com> (raw)
In-Reply-To: <20200504124442.208004-1-hsinyi@chromium.org>



On 04/05/2020 14:44, Hsin-Yi Wang wrote:
> Fix the assigned-clock-parents to higher frequency clock to avoid h264
> encode timeout:
> 
> [  134.763465] mtk_vpu 10020000.vpu: vpu ipi 4 ack time out !
> [  134.769008] [MTK_VCODEC][ERROR][18]: vpu_enc_send_msg() vpu_ipi_send msg_id c002 len 32 fail -5
> [  134.777707] [MTK_VCODEC][ERROR][18]: vpu_enc_encode() AP_IPIMSG_ENC_ENCODE 0 fail
> 
> venc_sel is the clock used by h264 encoder, and venclt_sel is the clock
> used by vp8 encoder. Assign venc_sel to vcodecpll_ck and venclt_sel to
> vcodecpll_370p5.
> 
>     vcodecpll                         1482000000
>        vcodecpll_ck                    494000000
>           venc_sel                     494000000
> ...
>        vcodecpll_370p5                 370500000
>           venclt_sel                   370500000
> 
> Fixes: fbbad0287cec ("arm64: dts: Using standard CCF interface to set vcodec clk")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>

Applied to v5.7-fixes

Thanks!

> ---
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index a212bf124e81..d0e9a2aada2e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -1422,8 +1422,8 @@ vcodec_enc: vcodec@18002000 {
>  				      "venc_lt_sel";
>  			assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>,
>  					  <&topckgen CLK_TOP_VENC_LT_SEL>;
> -			assigned-clock-parents = <&topckgen CLK_TOP_VENCPLL_D2>,
> -						 <&topckgen CLK_TOP_UNIVPLL1_D2>;
> +			assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>,
> +						 <&topckgen CLK_TOP_VCODECPLL_370P5>;
>  		};
>  
>  		jpegdec: jpegdec@18004000 {
> 

      reply	other threads:[~2020-05-15 15:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04 12:44 [PATCH] arm64: dts: mt8173: fix vcodec-enc clock Hsin-Yi Wang
2020-05-15 15:28 ` Matthias Brugger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3769d9da-9465-61ca-7ae5-39ef4ef52e85@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gtk_ruiwang@mediatek.com \
    --cc=hsinyi@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=qianqian.yan@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=yunfei.dong@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox