From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E80D31ACEC9; Mon, 9 Dec 2024 14:46:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733755570; cv=none; b=uLd8kN2QA/vWUbqjtMU34BHj9LfkJZg6yCnbu635rY5pp+doBmyt+t+hy9RXNJ6QNuqkRSVME8YnbVDt7ktWEHZOaOfnjnUggtK3LwNRVDsywk71lAsutte3KnBZ3qydYNNDGoirSQVdUIHHGjmqYLPq+dw9oBymMYfxxnb5d+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733755570; c=relaxed/simple; bh=2Ontbdl/Ui2RDELfVUpWEnj2cLmzdFyE2WE4OdC/s/Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SIoMnfN3XHsUZk52vxnGiQhJBLHd0/kCqtiKMMaWoazPmd+K2TJ5OIqpDvnzEvuPDNbLN1MFSWnUpEVyXsFXMb03IX19NoOrQMItlg8jdm64ID0HMYmgtIGibNbQOsUIRSdJpJ3/FKaJR/Toa4J+qeVqEm74PDetYPawlZUm6AM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=11OGKHN5; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="11OGKHN5" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=IWv5S8qTo3ORVYAj9ok2lHaimbOV5HPyhvsgh0TLoGA=; b=11OGKHN5/i14E8mbq+cWtikWTp IA8mdbKXzjYA5dn1ppe6vgoW43RZjt4japA9BxE3oqShRPsHyzbqvs6/YvHGdyTkXxiHYw2vHMaQO nKQw5gyAflUC6DChEjhHvxJueVZWszIjI+6sGg0zp4okvboBr6KpcC2nZQJ2cAfkN1Zc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1tKf1H-00FgRu-W0; Mon, 09 Dec 2024 15:45:55 +0100 Date: Mon, 9 Dec 2024 15:45:55 +0100 From: Andrew Lunn To: Dimitri Fedrau Cc: dimitri.fedrau@liebherr.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Heiner Kallweit , Russell King , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: phy: dp83822: Add support for GPIO2 clock output Message-ID: <376bdfed-a000-486f-9aa5-4e186753bdd8@lunn.ch> References: <20241209-dp83822-gpio2-clk-out-v1-0-fd3c8af59ff5@liebherr.com> <20241209-dp83822-gpio2-clk-out-v1-2-fd3c8af59ff5@liebherr.com> <20241209135205.GA2891@debian> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241209135205.GA2891@debian> > > I would of preferred MDIO_MMD_VEND2 rather than DP83822_DEVADDR, but > > having just this one instance correct would look a bit odd. > > > Is it worth fixing it in a separate patch, replacing all DP83822_DEVADDR > with MDIO_MMD_VEND2 ? You could do. As a reviewer, i like to be able to quickly see, these are vendor registers, i don't need to check if they are part of 802.3, and should have standard names, and be pulled out into a library for others to share. So if you want to add a patch, i'm happy with that. Andrew