From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57EE1C18E5A for ; Wed, 11 Mar 2020 09:08:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DEF8208E4 for ; Wed, 11 Mar 2020 09:08:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728692AbgCKJIB convert rfc822-to-8bit (ORCPT ); Wed, 11 Mar 2020 05:08:01 -0400 Received: from gloria.sntech.de ([185.11.138.130]:37994 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726934AbgCKJIB (ORCPT ); Wed, 11 Mar 2020 05:08:01 -0400 Received: from p5b127c69.dip0.t-ipconnect.de ([91.18.124.105] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jBxLH-0000Xw-Dr; Wed, 11 Mar 2020 10:07:55 +0100 From: Heiko Stuebner To: Johan Jonker Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/5] ARM: dts: rockchip: fix vqmmc-supply property name for rk3188-bqedison2qc Date: Wed, 11 Mar 2020 10:07:54 +0100 Message-ID: <37714750.JZCpAI0Cju@phil> In-Reply-To: <20200307134841.13803-1-jbx6244@gmail.com> References: <20200307134841.13803-1-jbx6244@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Samstag, 7. März 2020, 14:48:37 CET schrieb Johan Jonker: > A test with the command below does not detect all errors > in combination with 'additionalProperties: false' and > allOf: > - $ref: "synopsys-dw-mshc-common.yaml#" > allOf: > - $ref: "mmc-controller.yaml#" > > 'additionalProperties' applies to all properties that are not > accounted-for by 'properties' or 'patternProperties' in > the immediate schema. > > First when we combine rockchip-dw-mshc.yaml, > synopsys-dw-mshc-common.yaml and mmc-controller.yaml it gives > this error: > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: mmc@10218000: > 'vmmcq-supply' does not match any of the regexes: > '^.*@[0-9]+$', > '^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)| > uhs-(sdr(12|25|50|104)|ddr50))$', > 'pinctrl-[0-9]+' > > 'vmmcq-supply' is not a valid property name for mmc nodes. > Fix this error by renaming it to 'vqmmc-supply'. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml > > Signed-off-by: Johan Jonker applied all 5 for 5.7 Thanks Heiko