From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6396C77B7E for ; Tue, 2 May 2023 11:16:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233850AbjEBLQj (ORCPT ); Tue, 2 May 2023 07:16:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233871AbjEBLQh (ORCPT ); Tue, 2 May 2023 07:16:37 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D17F05593 for ; Tue, 2 May 2023 04:16:33 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3062d764455so1421635f8f.3 for ; Tue, 02 May 2023 04:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683026192; x=1685618192; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s817+XhrEg864Iqg3Xcty8Ttwo371gDLoynkgJ6CeeI=; b=rNUVMF3BvxXL0xQpPwhYfDlOuzSLJPGWxOLslPhlJfzm1rInIcckmOpDjO5f9SaPKZ w5neFb1yP0MUarZyFtMqPU6Rer7hHTDD2arXUQAMr3q+FbVfXg4Aq1zZROR2qOi8npUX YiXt4glqUy6isPnxaPcwxAdTiQY+SeNIELbOzIxOhz+ArTzlF/SnheDeBmJCDeV/6gHd q7z3NhuttC6rqRA2JEw9ApWJ0D8jTAl6iYjZZFeWZyWZjTOuIW8HoCajJOXa8et3jq5q LSyhYm0yWYg0XxNS8PyUs3p8WFOiCyE5W6owqoEvlJdsXcoEsMylZf4cCNkkuVD0yqkV VNLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683026192; x=1685618192; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s817+XhrEg864Iqg3Xcty8Ttwo371gDLoynkgJ6CeeI=; b=IoIFDfpeOYjcO2N47rqh/gafSCTHNbk8P8KFEK/rWHmmZVTo4xYBvb050MtMlQlMQx GtLiCaE8nSlTEvUtcxah8K7DMMbVJl0j2DHhSuf+Uq+v1Dq5U7oE6cjXEiI3lV4LF0RR nITUB59GuvlmdEjT6oMZJrZn/I8HZnsDfexHlnVga6Kef1E95Tysm53RME4MV2RYHqW9 jcDJnbhkxw2CrRFgVB2j5G/IBOc4A0ouAVYVo3x0R5cDzxC04ywdbQZ3JVqRPVDjaC9G eeO/pnLks8gEHGSioQm3nZyeAaU0UtxSRiIsLIpXQiQM+dWK5JKeXodUQ36KHYCdiKJg iXcA== X-Gm-Message-State: AC+VfDy1K0k4bq+ohqjbzrwZHqbZ/CYtVLalBBsKxwiQA1KWE/GQE/YC TOHPi6Pvi6EWTHe/uYMyDSLkQQ== X-Google-Smtp-Source: ACHHUZ5R1xHiewsaYowCn7zk4jCqNu7AvXQJZf7mGtVWVa5QPXWRuaUeerGoCYNzzkiBRWlm1Hq/PA== X-Received: by 2002:adf:da47:0:b0:2f4:4e1a:bea2 with SMTP id r7-20020adfda47000000b002f44e1abea2mr12468916wrl.59.1683026192325; Tue, 02 May 2023 04:16:32 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id a18-20020a056000101200b002e61e002943sm30697474wrx.116.2023.05.02.04.16.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 04:16:31 -0700 (PDT) Message-ID: <378d0ec8-5ce1-57d3-eccf-8e053d647f47@linaro.org> Date: Tue, 2 May 2023 12:16:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v6 12/13] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1 Content-Language: en-US To: Konrad Dybcio , linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, luca.weiss@fairphone.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: caleb.connolly@linaro.org, subbaram@quicinc.com, jackp@quicinc.com, robertom@qti.qualcomm.com References: <20230501121111.1058190-1-bryan.odonoghue@linaro.org> <20230501121111.1058190-13-bryan.odonoghue@linaro.org> <109dc9fe-5ca7-1a98-3222-8c2297f4e8ce@linaro.org> <41581143-2caa-bac1-479c-c8feaf2de1b9@linaro.org> From: Bryan O'Donoghue In-Reply-To: <41581143-2caa-bac1-479c-c8feaf2de1b9@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/05/2023 12:13, Konrad Dybcio wrote: > > > On 2.05.2023 13:03, Bryan O'Donoghue wrote: >> On 02/05/2023 12:00, Konrad Dybcio wrote: >>>> +            #address-cells = <1>; >>>> +            #size-cells = <0>; >>>> + >>>> +            port@0 { >>>> +                reg = <0>; >>>> +                pm8150b_role_switch_out: endpoint { >>> Similarly to the QMPPHY, the port definition can be moved to >>> the common node in the SoC DTSI >> >> But then the connector would have to be defined in the SoC dtsi and not all derivatives of SoC can be assumed to have a usb-c-connector. > Not quite! > > You can define an empty endpoint (like we do with DSI<->panel ones) and > fill it in on the device side. Sorry you're saying to define as an example the port here in the dtsi &usb_1_dwc3 { dr_mode = "otg"; usb-role-switch; port { dwc3_role_switch_in: endpoint { remote-endpoint = <&pm8150b_role_switch_out>; }; }; }; and to leave the reciprocal definition in the connector to the dts ? &pm8150b_typec { connector { compatible = "usb-c-connector"; ports { #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; pm8150b_role_switch_out: endpoint { remote-endpoint = <&dwc3_role_switch_in>; }; };