From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: Re: [PATCH v7 2/5] mm: remove x86-only restriction of movable_node Date: Tue, 15 Nov 2016 10:20:00 +1100 Message-ID: <37a9339f-0ce9-261f-90de-be8463705bb5@gmail.com> References: <1479160961-25840-1-git-send-email-arbab@linux.vnet.ibm.com> <1479160961-25840-3-git-send-email-arbab@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1479160961-25840-3-git-send-email-arbab-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Reza Arbab , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Andrew Morton , Rob Herring , Frank Rowand , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Cc: linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bharata B Rao , Nathan Fontenot , Stewart Smith , Alistair Popple , "Aneesh Kumar K.V" , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 15/11/16 09:02, Reza Arbab wrote: > In commit c5320926e370 ("mem-hotplug: introduce movable_node boot > option"), the memblock allocation direction is changed to bottom-up and > then back to top-down like this: > > 1. memblock_set_bottom_up(true), called by cmdline_parse_movable_node(). > 2. memblock_set_bottom_up(false), called by x86's numa_init(). > > Even though (1) occurs in generic mm code, it is wrapped by #ifdef > CONFIG_MOVABLE_NODE, which depends on X86_64. > > This means that when we extend CONFIG_MOVABLE_NODE to non-x86 arches, > things will be unbalanced. (1) will happen for them, but (2) will not. > > This toggle was added in the first place because x86 has a delay between > adding memblocks and marking them as hotpluggable. Since other arches do > this marking either immediately or not at all, they do not require the > bottom-up toggle. > > So, resolve things by moving (1) from cmdline_parse_movable_node() to > x86's setup_arch(), immediately after the movable_node parameter has > been parsed. > > Signed-off-by: Reza Arbab Acked-by: Balbir Singh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html