From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5881F1BD01D for ; Thu, 8 May 2025 16:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746722755; cv=none; b=klo245jzz4WjwM7iVub/Oc7dZ7PpsAflt2VroWREJCXP/Uag+6A0kqhHhwL8WGhukShnEFuWrxI60nS2VI9hJGahB0j5pWX+03JC1GwzrPml12Ps0oS4y5c9kIcGNqCdbWG76+c25bpnpoAnhE9aZXCNXhYLMGalPU2xNG4/M7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746722755; c=relaxed/simple; bh=sYeZLtpHPeuyHV/41fg3SXOFV2Tg9CfQcSP+Mkt6FAw=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=sKUlxh8PWkbddg5jHTjDlEHcmhaJdNKaWIYWydH40/5UdYlLNAYGlu3Z7P1mzVydUBOsw5Ib70w+yR4m5xJoSiG4LagaDSKUOP/UvpLy6uf0BsJMg4avTk5xEjgrhDgWGvB+Q1r3EYMZZVpPpsKh/IA/fi0rjrPflbs2D/YLrnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=mICO/toI; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="mICO/toI" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-73044329768so912355a34.3 for ; Thu, 08 May 2025 09:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1746722752; x=1747327552; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=ZS1DAu/OGipdaeYyDVfVQy+AhcyRGZVYwm5fK44jnLQ=; b=mICO/toIb/HlwX+vg9U5ispi7FBErVNzk5S+GKrVfiMt8Y2sUWYVUeEWT5Wi8nCr6v 02++H8yzwEV94bOjpiHlmNrmIkO6VgiFtwGM41DxDhAI5RvKBGFjuMAaYm9v8XJNE9J4 Cy8eM65qmTdTqF3zci1lPbGYttDTMqQ1LnAnWTD124bQc5HqUbtuHfgffbi136fLyfa8 /O6TdBwVDV83oL5z3ml/Z4RYP8CbJ6CBSv0ybsnE5WvfAy/uSZiRKYvBhb6WzDEAFT1+ F+UMXMva8AbhPui8DGHBcDu3M3kMIEc9NB2MlYOXan5WQUjOCf5bSnQSCJo/QJwkuEIs NcVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746722752; x=1747327552; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZS1DAu/OGipdaeYyDVfVQy+AhcyRGZVYwm5fK44jnLQ=; b=XQoKKDjUViG8+4jy+J1BvfSXWsjFscIPL9y7PcNuINRD9TL2EQnOoJjfgVrV65+Nf0 GHH2kQ+xA6VZ4Gww4CKUF2Cg+7fWyyxoKCOYo9gaZHP8Oxx3fl8YHrPNbV/zYgofoXzQ zuby4ywi6Oe9EgFytFiz2/naCciX5B+CaNbbwzmlsGA0hR7V5Z43hnWTSgtlsK7P7/j/ 4bm7MGdB+8OZ25RPXdcDp7zHZQZp7BWLC743b3r38U8AKaXemuoyzrJvC6UVxq9p2kk2 14e++PmYq58ez1oEJNyxlrHNKpucSEx8RnzGh83GmQkwqJdPiUGjWEsGJh+kOUBA6ZFB aG1w== X-Forwarded-Encrypted: i=1; AJvYcCXFXShrSsqmEVte+oHN3xuBDOTrAANR8LwqICiEJqW3d0XLz2hTvaRV6TEmBdWHTrv04q/QTIsYiXUe@vger.kernel.org X-Gm-Message-State: AOJu0YzxiwKr/gtMZICTeMxzkg1JlkKlWqnoNp5l2w1GBRlxNMqo3b+g QbjfJdc1DlLJURGuR/EWqopg6EaQW3FihEhfuUOXmXWEv2/b0o9vYMXsUhSoTzQ= X-Gm-Gg: ASbGnctGjarKGbV4TPy91/BndznVm7ICBoM0rVKjXx7TwXC3rsVBSznmvPooa8BE7A3 /FAVkUwFWpugxkfhGIg9EIaBI+W0pXTbKHF26QQ4bhK8ZtuXmQWzm1PBl473CTeq8kiM1Ylzkf2 YqeZGIY4GBY4BYqZc17Oz99gWRiD3xqY83mrbA5HqZVWa6zQxJbJMogTr/wAeaeyJaQpgfRF8uX 4qSDC4SaYl1pjBAj401+b9Atim6Tt1TNIIjN54xtWcxh+fiRC2F8jxEL2KUXf94ObC8yLtw6yUh LPN+B6tBqpZ8VEstd8OWA7R8xUepR/UPdNJiVCVeNpHNhFjMVVDB/LdGYx3vemo3Yi6oJwEn89P kd2fOa1g8IUqdXmHi7g== X-Google-Smtp-Source: AGHT+IEZDZLOMxJDt8kLUDFqLwM51K2NVQLT54ITBkIlx9L3ppO4Dyj06GSMVCaofCpDgYIIbqiFjw== X-Received: by 2002:a05:6830:3788:b0:72c:10db:f210 with SMTP id 46e09a7af769-732269faf05mr352368a34.13.1746722752395; Thu, 08 May 2025 09:45:52 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:1120:d1cf:c64a:ac7e? ([2600:8803:e7e4:1d00:1120:d1cf:c64a:ac7e]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-732264d59e1sm102555a34.34.2025.05.08.09.45.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 May 2025 09:45:51 -0700 (PDT) Message-ID: <37ae4941-da7e-4298-8269-b5faf29fffdd@baylibre.com> Date: Thu, 8 May 2025 11:45:50 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] iio: adc: adi-axi-adc: add set decimation rate To: Pop Ioan Daniel , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sergiu Cuciurean , Dragos Bogdan , Antoniu Miclaus , Olivier Moysan , Javier Carrasco , Matti Vaittinen , Tobias Sperling , Marcelo Schmitt , Alisa-Dariana Roman , Esteban Blanc , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250508123107.3797042-1-pop.ioan-daniel@analog.com> <20250508123107.3797042-3-pop.ioan-daniel@analog.com> From: David Lechner Content-Language: en-US In-Reply-To: <20250508123107.3797042-3-pop.ioan-daniel@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/8/25 7:30 AM, Pop Ioan Daniel wrote: > Add support for setting decimation rate. > > Signed-off-by: Pop Ioan Daniel > --- > changes in v2: > - update ADI_AXI_ADC_REG_CHAN_USR_CTRL_2 register in a per-channel register > - rename ADI_AXI_ADC_DEC_RATE_MASK in > ADI_AXI_ADC_CHAN_USR_CTRL_2_DEC_RATE_N_MASK > - add channel index parameter to keep axi_adc_set_dec_rate generic > - remove ad7405 chip-specific struct > drivers/iio/adc/adi-axi-adc.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c > index 9e8c30230791..33eb8f337e0b 100644 > --- a/drivers/iio/adc/adi-axi-adc.c > +++ b/drivers/iio/adc/adi-axi-adc.c > @@ -80,6 +80,9 @@ > #define ADI_AXI_ADC_REG_CHAN_CTRL_3(c) (0x0418 + (c) * 0x40) > #define ADI_AXI_ADC_CHAN_PN_SEL_MASK GENMASK(19, 16) > > +#define ADI_AXI_ADC_REG_CHAN_USR_CTRL_2(c) (0x0424 + (c) * 0x40) > +#define ADI_AXI_ADC_CHAN_USR_CTRL_2_DEC_RATE_N_MASK GENMASK(15, 0) > + > /* IO Delays */ > #define ADI_AXI_ADC_REG_DELAY(l) (0x0800 + (l) * 0x4) > #define AXI_ADC_DELAY_CTRL_MASK GENMASK(4, 0) > @@ -242,6 +245,17 @@ static int axi_adc_test_pattern_set(struct iio_backend *back, > } > } > > +static int axi_adc_set_dec_rate(struct iio_backend *back, unsigned int chan, > + unsigned int rate) > +{ > + struct adi_axi_adc_state *st = iio_backend_get_priv(back); > + > + return regmap_update_bits(st->regmap, > + ADI_AXI_ADC_REG_CHAN_USR_CTRL_2(chan), > + ADI_AXI_ADC_CHAN_USR_CTRL_2_DEC_RATE_N_MASK, > + FIELD_PREP(ADI_AXI_ADC_CHAN_USR_CTRL_2_DEC_RATE_N_MASK, rate)); Rate is getting a bit far past 80 chars, so would be nice to wrap that line. > +} > + > static int axi_adc_read_chan_status(struct adi_axi_adc_state *st, unsigned int chan, > unsigned int *status) > { > @@ -550,6 +564,7 @@ static const struct iio_backend_ops adi_axi_adc_ops = { > .test_pattern_set = axi_adc_test_pattern_set, > .chan_status = axi_adc_chan_status, > .interface_type_get = axi_adc_interface_type_get, > + .oversampling_ratio_set = axi_adc_set_dec_rate, Would make more sense if function was named axi_adc_oversampling_ratio_set. (Making the names match exactly (with namespace prefix added) make less info you have to hold in your head when reading the driver.) > .debugfs_reg_access = iio_backend_debugfs_ptr(axi_adc_reg_access), > .debugfs_print_chan_status = iio_backend_debugfs_ptr(axi_adc_debugfs_print_chan_status), > };