From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Yunfei Dong" <yunfei.dong@mediatek.com>,
"Chen-Yu Tsai" <wenst@chromium.org>,
"Nicolas Dufresne" <nicolas@ndufresne.ca>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>,
Steve Cho <stevecho@chromium.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH 1/6] media: mediatek: vcodec: can`t regard getting lat buffer fail as error
Date: Mon, 17 Apr 2023 11:18:15 +0200 [thread overview]
Message-ID: <37b56f69-99c2-adf0-cc9f-572fbdaa2eee@collabora.com> (raw)
In-Reply-To: <20230417054816.17097-2-yunfei.dong@mediatek.com>
Il 17/04/23 07:48, Yunfei Dong ha scritto:
> The speed of lat decoder is much faster than core, need to get trans
> buffer again when lat fail to get trans buffer.
>
The commit description is misleading, looks like you're doing functional
changes, but you're just changing loglevels... and the title is also a
little confusing, so.. I would propose:
media: mediatek: vcodec: Avoid unneeded error logging
Since the LAT decoder works faster than its CORE, getting the trans buffer may
be done only after CORE finishes processing: avoid printing an error if the
decode function returns -EAGAIN, as this means that the buffer from CORE is not
yet available, but will be at a later time.
Also change the log level for calls to vdec_msg_queue_dqbuf() in H264 and VP9
LAT decoder drivers to avoid excessive logging.
Cheers,
Angelo
next prev parent reply other threads:[~2023-04-17 9:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 5:48 [PATCH 0/6] media: mediatek: vcodec: Fix decoder under flow and plt test fails randomly Yunfei Dong
2023-04-17 5:48 ` [PATCH 1/6] media: mediatek: vcodec: can`t regard getting lat buffer fail as error Yunfei Dong
2023-04-17 9:18 ` AngeloGioacchino Del Regno [this message]
2023-04-17 12:09 ` Yunfei Dong (董云飞)
2023-04-17 5:48 ` [PATCH 2/6] media: mediatek: vcodec: add the definition of decoder status Yunfei Dong
2023-04-17 9:26 ` AngeloGioacchino Del Regno
2023-04-17 12:10 ` Yunfei Dong (董云飞)
2023-04-17 5:48 ` [PATCH 3/6] media: mediatek: vcodec: using decoder status instead of core work count Yunfei Dong
2023-04-17 5:48 ` [PATCH 4/6] media: mediatek: vcodec: add one empty lat buffer as the last one to decode Yunfei Dong
2023-04-17 9:35 ` AngeloGioacchino Del Regno
2023-04-17 12:11 ` Yunfei Dong (董云飞)
2023-04-17 5:48 ` [PATCH 5/6] media: mediatek: vcodec: move core context from device to each instance Yunfei Dong
2023-04-17 9:35 ` AngeloGioacchino Del Regno
2023-04-17 5:48 ` [PATCH 6/6] media: mediatek: vcodec: using empty lat buffer as the last one Yunfei Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37b56f69-99c2-adf0-cc9f-572fbdaa2eee@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=benjamin.gaignard@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=nicolas@ndufresne.ca \
--cc=stevecho@chromium.org \
--cc=wenst@chromium.org \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).