From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aq4aBjSh" Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3725610D4 for ; Tue, 28 Nov 2023 05:16:00 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2c997467747so38743991fa.1 for ; Tue, 28 Nov 2023 05:16:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701177358; x=1701782158; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o2U0Dw+C6h6+RoUlbLOMo/lv9uHPeB9SLzHDaRTZV7s=; b=aq4aBjShzauCTPcrw1rBmEmFJRHOZAvJt92AhlThn+N+MBM/k1/D2ClUuo/oIiLVlk ZoS9400FlRyjHk6VaNgyfV3BO3qyUWFTehddU0TwpMUVzdULBViISpeoNlnAO6dfNc5M Ep19/2B7gGFoVHIcBwbr/PMzKvGWGLe8K/2/0VxjuTLkTWIwRCAta+YCrhUnmZEl3Ude n4CI9rMo7RYVlq5NC8lt0+b/BgLqLXNBxtItNssBlnLIquZYBJJ7ZWjZ2CgSus9yezBL Ua9es5B5T/ja87fcsFOiCOicDItstxAG0sBEUpE5VOhrlUFLl7rFMVX+2zEk7CywknB3 W4xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701177358; x=1701782158; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o2U0Dw+C6h6+RoUlbLOMo/lv9uHPeB9SLzHDaRTZV7s=; b=vBoznve8+4Az/UduI4W/lBKnfZ8veKWQCYhNymyAp2Njq5Qs/fv0Iob2KsWftkpTfg 5ODjhjKMwn0oLoFJiIVV0qaNqnYu1z6oAnaed1XqRTfdi8nVBRXt0nxfzK7HwLJKRoJJ gGt6CvZVpJPHIJbBn9wPHOJCniuvC/ebsoPxdlckwKH8+Ofpmud4iMGM3K4onKAKiTlB Vo4Atsoe0qHBus563c0+RQDWDt3lOS/WXTDNTmeGjk+CyNWpyOtBDnmXtadRKasVXw+b TT7jAMx7r3e3J6SEV7RglQAQ1ogMV4iYeTG0KPE/S7KwAyy7cOGE0CUSXLtsNbSGy40R gIlA== X-Gm-Message-State: AOJu0YxpqkRPbmsW3Qf8CTT84pEELKEQDMIaosGWgkpZ54KRMKx1UQKw 19u822ImgrW5suap5rPBX+WmgQ== X-Google-Smtp-Source: AGHT+IEzEaz+EEBfeJx7la23pJ4m/XXEUN3X5Za/9Q6XMgt9Zg15Eol47FvI5Utk4vk+9djDSK1vPg== X-Received: by 2002:a2e:888f:0:b0:2c9:b96e:16e4 with SMTP id k15-20020a2e888f000000b002c9b96e16e4mr403296lji.42.1701177358355; Tue, 28 Nov 2023 05:15:58 -0800 (PST) Received: from ?IPV6:2001:14ba:a0db:1f00::227? (dzdqv0yyyyyyyyyyyykxt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::227]) by smtp.gmail.com with ESMTPSA id t7-20020a2e9547000000b002b657f10b78sm1707226ljh.58.2023.11.28.05.15.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Nov 2023 05:15:57 -0800 (PST) Message-ID: <37bfdc21-8d2a-4a6c-a2eb-9eaa1e808496@linaro.org> Date: Tue, 28 Nov 2023 15:15:57 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 12/12] arm64: dts: qcom: qrb2210-rb1: add wifi variant property Content-Language: en-GB To: Konrad Dybcio , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Loic Poulain , Bryan O'Donoghue , Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Georgi Djakov , Will Deacon , Robin Murphy , Joerg Roedel , Krishna Manikandan , Robert Marko , Das Srinagesh , cros-qcom-dts-watchers@chromium.org Cc: Marijn Suijten , Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev References: <20231125-topic-rb1_feat-v2-0-979b28f35e4a@linaro.org> <20231125-topic-rb1_feat-v2-12-979b28f35e4a@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20231125-topic-rb1_feat-v2-12-979b28f35e4a@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27/11/2023 17:28, Konrad Dybcio wrote: > From: Dmitry Baryshkov > > The RB1 platform doesn't have board-specific board-id programmed, it uses > generic 0xff. Thus add the property with the 'variant' of the > calibration data. > > Note: the driver will check for the calibration data for the following > IDs, so existing board-2.bin files will continue to work. > > - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=120,variant=Thundercomm_RB1' > - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=120' > - 'bus=snoc,qmi-board-id=ff' > > For the reference, the board is identified by the driver in the > following way: > > ath10k_snoc c800000.wifi: qmi chip_id 0x120 chip_family 0x4007 board_id 0xff soc_id 0x40670000 > ath10k_snoc c800000.wifi: qmi fw_version 0x337302d3 fw_build_timestamp 2023-01-06 01:50 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.3.3.7.c2-00723-QCAHLSWMTPLZ-1 > ath10k_snoc c800000.wifi: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000 > ath10k_snoc c800000.wifi: kconfig debug 0 debugfs 0 tracing 0 dfs 0 testmode 0 > ath10k_snoc c800000.wifi: firmware ver api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790 > ath10k_snoc c800000.wifi: htt-ver 3.114 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1 > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Konrad Dybcio As you are resending this patch, you should add your S-o-b. > --- > arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts > index ac597eb3fe9d..bd7bcf803654 100644 > --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts > +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts > @@ -535,6 +535,7 @@ &wifi { > vdd-1.8-xo-supply = <&pm2250_l13>; > vdd-1.3-rfa-supply = <&pm2250_l10>; > vdd-3.3-ch0-supply = <&pm2250_l22>; > + qcom,ath10k-calibration-variant = "Thundercomm_RB1"; > status = "okay"; > }; > > -- With best wishes Dmitry