From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79819C6FD1D for ; Wed, 15 Mar 2023 13:17:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232027AbjCONRh (ORCPT ); Wed, 15 Mar 2023 09:17:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232111AbjCONR0 (ORCPT ); Wed, 15 Mar 2023 09:17:26 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B6A72940A for ; Wed, 15 Mar 2023 06:17:24 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id x3so75332159edb.10 for ; Wed, 15 Mar 2023 06:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678886242; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xb3QrMvZd6yXgo618qylfqMF5lEqCyijeAUK/t+b8pY=; b=tllWpTVkNiFevbCV6hrsro8EDioioGuXMk8U7uog+O3LTKQ+iwWPKkRrK2a6/gFt5T KwLk2WSdmaLSw+gfle9g2We2K7WaRPNyZefDvVsHAna15v3BHpv77DQTr9pWOkmNC4Fa /BgHTwnJJ9jluRuRVQULjJbYi5tK3ItpWVTJBKEmpsz/nkG3RIRNcGGKCsMrhxjGhIL1 RXGOIpfj/3xbldFNygvv8MeKNPspTZ6uEJahOCtvAvU16zTpPJIFPt8K0LF8Rl3rOBrF 4E9YCPTFe/5T1pbj4Z8UQEI0WAdq8sKV3npKVuuklm/+UvBjD02NfY57buCnifJZWVoW OQ+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678886242; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xb3QrMvZd6yXgo618qylfqMF5lEqCyijeAUK/t+b8pY=; b=UGkEthzfWu24Zsbqrr5GnXzw8ycqBmw9p3gCiVQn2+fdzQs/cwrJCoPQG3Kx//1r9j xZ7s38I7WepkVKex9SSfj5Sb7aD2s9BcbNLgkIzyI13bBWNxhX+SJX5ixH8diKdOGe1U 0gxwvi0kEy2HgAirRH3WOg97+FdCjBudD33uXf5JwRPnrFhgisFOgPEp81F8lvLJRLDn jNxlrhpTU7GMZfZE6ssNXnL/9GuL4IUdQSeAg8/f6qh7sydGnCoQ8EXbE8qcjygqYi4Z U4UUW1oAlea4nIHHKfqCXCKmvuwi8VeI02ECoksIrdjkD5rpY1RomcpHmmiNZ0I5+4ck JP5w== X-Gm-Message-State: AO0yUKUq9P2WeaeDYwbDKnXMi+5+sJDouUiF2jRqpvZKzqjhbgeQUVcW YHjv6wzET1Z5JEWim0TaZlNa0w== X-Google-Smtp-Source: AK7set8XLwvi0YYJ2zeYnMe04uDSQnmdw08tghX2TWXAj6C5xYII9tMdLb9fM2JagC5ZFNQlGrwrlA== X-Received: by 2002:a05:6402:455:b0:4fc:b83d:c31f with SMTP id p21-20020a056402045500b004fcb83dc31fmr2560472edw.16.1678886242456; Wed, 15 Mar 2023 06:17:22 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:940e:8615:37dc:c2bd? ([2a02:810d:15c0:828:940e:8615:37dc:c2bd]) by smtp.gmail.com with ESMTPSA id r9-20020a50c009000000b004c13fe8fabfsm2414078edb.84.2023.03.15.06.17.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 06:17:21 -0700 (PDT) Message-ID: <37c2c7de-792e-0289-4551-24bbb9fe31d9@linaro.org> Date: Wed, 15 Mar 2023 14:17:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC Content-Language: en-US To: Alexandre Mergnat Cc: Daniel Vetter , CK Hu , Jitao Shi , Thierry Reding , Philipp Zabel , Sam Ravnborg , Rob Herring , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Chun-Kuang Hu , Matthias Brugger , David Airlie , Krzysztof Kozlowski , Xinlei Lee , Guillaume La Roque , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Fabien Parent , Neil Armstrong , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230220-display-v1-0-45cbc68e188b@baylibre.com> <20230220-display-v1-15-45cbc68e188b@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/03/2023 09:01, Alexandre Mergnat wrote: > Le ven. 10 mars 2023 à 09:39, Krzysztof Kozlowski > a écrit : >> >> On 09/03/2023 15:23, Alexandre Mergnat wrote: >>> Add compatible for the MT8365 SoC. >>> >>> Signed-off-by: Alexandre Mergnat >>> --- >>> Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >>> index ca0ca549257d..931d66893dff 100644 >>> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >>> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >>> @@ -34,6 +34,7 @@ properties: >>> - mediatek,mt8186-mdp3-mutex >>> - mediatek,mt8192-disp-mutex >>> - mediatek,mt8195-disp-mutex >>> + - mediatek,mt8365-disp-mutex >> >> All these look compatible. Either make mt8635 compatible with something >> or even rework entire list and make everything compatible. > > All of them use "mtk_mutec.c" but have specific data. > > .data = &mt8173_mutex_driver_data}, > { .compatible = "mediatek,mt8183-disp-mutex", > .data = &mt8183_mutex_driver_data}, > { .compatible = "mediatek,mt8186-disp-mutex", > .data = &mt8186_mutex_driver_data}, > { .compatible = "mediatek,mt8186-mdp3-mutex", > .data = &mt8186_mdp_mutex_driver_data}, > { .compatible = "mediatek,mt8192-disp-mutex", > .data = &mt8192_mutex_driver_data}, > { .compatible = "mediatek,mt8195-disp-mutex", > .data = &mt8195_mutex_driver_data}, > { .compatible = "mediatek,mt8365-disp-mutex", > .data = &mt8365_mutex_driver_data}, > > I don't see any SoC compatible with mt8635, and I have no idea which > rework you have in mind. Can you please point me an example ? You are right, I looked at wrong of_device_id. Best regards, Krzysztof