From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E7CDC4332F for ; Tue, 22 Nov 2022 01:27:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232182AbiKVB1B (ORCPT ); Mon, 21 Nov 2022 20:27:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbiKVB05 (ORCPT ); Mon, 21 Nov 2022 20:26:57 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 249C4DEAF6; Mon, 21 Nov 2022 17:26:55 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 9ECF524E09F; Tue, 22 Nov 2022 09:26:48 +0800 (CST) Received: from EXMBX072.cuchost.com (172.16.6.82) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 22 Nov 2022 09:26:48 +0800 Received: from [192.168.125.106] (113.72.144.23) by EXMBX072.cuchost.com (172.16.6.82) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 22 Nov 2022 09:26:49 +0800 Message-ID: <37d5a252-6540-7ba1-41f0-f68cb1c817d1@starfivetech.com> Date: Tue, 22 Nov 2022 09:26:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2 08/14] dt-bindings: reset: Add StarFive JH7110 system and always-on reset definitions Content-Language: en-US To: Krzysztof Kozlowski , , , CC: Conor Dooley , Palmer Dabbelt , "Rob Herring" , Krzysztof Kozlowski , Stephen Boyd , "Michael Turquette" , Philipp Zabel , Emil Renner Berthing , References: <20221118010627.70576-1-hal.feng@starfivetech.com> <20221118010627.70576-9-hal.feng@starfivetech.com> From: Hal Feng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.144.23] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX072.cuchost.com (172.16.6.82) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 21 Nov 2022 09:50:13 +0100, Krzysztof Kozlowski wrote: > On 18/11/2022 02:06, Hal Feng wrote: > > From: Emil Renner Berthing > > > > Add resets for the StarFive JH7110 system (SYS) and always-on (AON) > > reset controller. > > > > Signed-off-by: Emil Renner Berthing > > Signed-off-by: Hal Feng > > --- > > MAINTAINERS | 5 +- > > include/dt-bindings/reset/starfive-jh7110.h | 154 ++++++++++++++++++++ > > 2 files changed, 157 insertions(+), 2 deletions(-) > > create mode 100644 include/dt-bindings/reset/starfive-jh7110.h > > > > Thank you for your patch. There is something to discuss/improve. > > > +#define JH7110_SYSRST_TIMER0 118 > > +#define JH7110_SYSRST_TIMER1 119 > > +#define JH7110_SYSRST_TIMER2 120 > > +#define JH7110_SYSRST_TIMER3 121 > > +#define JH7110_SYSRST_INT_CTRL_APB 122 > > +#define JH7110_SYSRST_TEMP_APB 123 > > +#define JH7110_SYSRST_TEMP_CORE 124 > > +#define JH7110_SYSRST_JTAG_CERTIFICATION 125 > > + > > +#define JH7110_SYSRST_END 126 > > Drop weird indentation in the middle of syntax. Will fix it. > > > + > > +/* AONCRG resets */ > > +#define JH7110_AONRST_GMAC0_AXI 0 > > +#define JH7110_AONRST_GMAC0_AHB 1 > > +#define JH7110_AONRST_AON_IOMUX 2 > > +#define JH7110_AONRST_PMU_APB 3 > > +#define JH7110_AONRST_PMU_WKUP 4 > > +#define JH7110_AONRST_RTC_APB 5 > > +#define JH7110_AONRST_RTC_CAL 6 > > +#define JH7110_AONRST_RTC_32K 7 > > + > > +#define JH7110_AONRST_END 8 > > Ditto Will fix it. Thanks. Best regards, Hal