From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E14C10F1B for ; Wed, 21 Dec 2022 20:13:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234765AbiLUUN2 (ORCPT ); Wed, 21 Dec 2022 15:13:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232786AbiLUUN1 (ORCPT ); Wed, 21 Dec 2022 15:13:27 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87392B17 for ; Wed, 21 Dec 2022 12:13:26 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id b3so25201084lfv.2 for ; Wed, 21 Dec 2022 12:13:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xMyITnYC6iA3G/LtEs1ZWz7dfXVBOhvaku8kkCxxo2s=; b=NJ8AI4l2bQDByL8abuo9ZMfM5BPB4rECN8H01ymKifVUY+P87GD6cLLj1DOw8UYrXJ RFj0+t9/IMWcKCfvpaHXpHjAn8jiwV/W6dJmariZAs0zaIQC27W6YLXL83pkN9LJofS7 sWKSxrAIlzfqj1KmTovKHodA+XZN86a5usHWzOFMUwEnlQMqkKT5yXpmlymD1ASRwS9b O5ZYDOZGSNYO896EYzazZhQI25k7JEwA4bka5JyJmOFLXIpCX0QvDDJvssCvHX69ea98 GZ8tE+9HSrIapYUsDAlESvqazowB1JwXFO5oZIzKT+HgKLJxBN1x1QEOWdBtaQb5U6VQ Gjtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xMyITnYC6iA3G/LtEs1ZWz7dfXVBOhvaku8kkCxxo2s=; b=LJesx0RmZQOWEQ7HI8XLCW2ZGMRI7X8sNH9NtSsZS7KZwOY8rNdnEGAZAP3K/P3wpt x5W1LJhNd7FT96RHX+LZmkBr8B0IncQFeFubtv/cBQ07wiAcjLwidYNv+yYhhbJvpBGW n/EpWxTBybahiYxul2gYWruxnhZ/9xmOrmqEn/EbJQnXwso79ZvdvY0Xo5oHJYJSZXMK ZDqg3Lq5Cw3QuicDg1Lai88PYnYIKVuMhFGteW/Rc3bOlFLn8I55pc1J0th7pbbSQGSW BmZMzwg5bsXR2vHzi7JPKDDZbv52QVSBRVgDFPfTbxACAc1T6zofy3s8x+fRRPrrzQJ+ hJtQ== X-Gm-Message-State: AFqh2kr5Xrjxl3IosY+aZvdQMkNrcmpUEOhBeqRb+tuYxb8MT9zwSJSH 3poChZBPp4JQefyPqOKa9FgWyA== X-Google-Smtp-Source: AMrXdXute0xsVtVJ10dXcWI2H6DJdIl5HiEylBrKZzmX9Ceo5peUrYXWQp5vg+dwntUF5danaNmPtQ== X-Received: by 2002:ac2:5975:0:b0:4b5:8f03:a2bc with SMTP id h21-20020ac25975000000b004b58f03a2bcmr756347lfp.9.1671653604897; Wed, 21 Dec 2022 12:13:24 -0800 (PST) Received: from [192.168.1.101] (abyl184.neoplus.adsl.tpnet.pl. [83.9.31.184]) by smtp.gmail.com with ESMTPSA id s16-20020a056512215000b004ca0ea7af24sm788834lfr.174.2022.12.21.12.13.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 12:13:24 -0800 (PST) Message-ID: <37ee797c-02e5-f35b-2066-feb58e48fb0f@linaro.org> Date: Wed, 21 Dec 2022 21:13:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v4 07/20] thermal/drivers/tsens: limit num_sensors to 9 To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org References: <20221221020520.1326964-1-dmitry.baryshkov@linaro.org> <20221221020520.1326964-8-dmitry.baryshkov@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20221221020520.1326964-8-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21.12.2022 03:05, Dmitry Baryshkov wrote: > According to the vendor kernels (msm-3.10, 3.14 and 3.18), msm8939 > supports only 9 sensors. Remove the rogue sensor's hw_id. msm-3.18 and 8939.. I would have never thought it was there! > > Fixes: 332bc8ebab2c ("thermal: qcom: tsens-v0_1: Add support for MSM8939") > Cc: Bryan O'Donoghue > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > drivers/thermal/qcom/tsens-v0_1.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c > index 0bc4e5cec184..57ac23f9d9b7 100644 > --- a/drivers/thermal/qcom/tsens-v0_1.c > +++ b/drivers/thermal/qcom/tsens-v0_1.c > @@ -605,9 +605,9 @@ static const struct tsens_ops ops_8939 = { > }; > > struct tsens_plat_data data_8939 = { > - .num_sensors = 10, > + .num_sensors = 9, > .ops = &ops_8939, > - .hw_ids = (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9, 10 }, > + .hw_ids = (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9 }, > > .feat = &tsens_v0_1_feat, > .fields = tsens_v0_1_regfields,