From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BB3C4321E for ; Mon, 5 Dec 2022 07:31:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230037AbiLEHb4 (ORCPT ); Mon, 5 Dec 2022 02:31:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231473AbiLEHbv (ORCPT ); Mon, 5 Dec 2022 02:31:51 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF7C411170 for ; Sun, 4 Dec 2022 23:31:49 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id a19so12577010ljk.0 for ; Sun, 04 Dec 2022 23:31:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a64rVG9Ar18ZQniQlMUt+8pfp4eItxEV9w2eYv/pKNY=; b=NMAXZbjHwIbXkRNbg6BrJIBwvsV6jrLt7CDPT075W1TEEoNSVbA04pL3R/u2BeeBMg L+oM2LahFuGws4kT5G+DWaz4N57J9hUSu0YfHCRr0S9Vf2KZmOJ8VJWZFxDxDeUK9XKe bCwIQeLCHITtSEZDVqo7KXns+H/Zh373Exvp6+fKUunKH1Z4aO6d8g1dZMkkzwjHex7m 03DNVJA3NozFKwSimo1AxF8Qsda7FsdOD5zT2tYHf6Ck7pWG/QDfJn0sssIF9qcjFFaJ 3ap7iGSLvGjJ1DVZinCNVPrJODfYSCvAHUJgIAANwdkbNmdAcDgBcpajiwAgrrOdBx4r 9qMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a64rVG9Ar18ZQniQlMUt+8pfp4eItxEV9w2eYv/pKNY=; b=uqaqt4rHVq3pASNFwqin9/IHyeMJGtlHB2G1cLixr9EMQre1xJjlKVL4DV6h5HC2km NlbSi/gO69xJKpWZN7AFYLHlpDUZSju0tXy4ezR1uZx9QobRUN3Oyywz4NTRkMYTmfhN 7jajrElpXy1LCHdlh4hcLWdeNcBLatrw+GyJYkwHbEeUtU8kdq+qf+6Xf/4lY3WhpEwH Ct1Q3axJrOjF5HG2RNJGyxoZyQoCB8BU0xcrkgOQBfcRq/fPsoNktQmdWYuzLrwVfh5T OX/FribhLhHisaEsSqxYdnrc/wJ+YnvcYW6hp+YSKfa7UutJMASRGTW7wOfXhX42vJdl 1dtg== X-Gm-Message-State: ANoB5pm8KQM4R7yeYxEEW+bTcZxc6CoR1lsscW/lyzuiivJAhhybzLBS G8QkAC9hV9o098WXvfiY6+kxew== X-Google-Smtp-Source: AA0mqf61RwmMr3Y0QNaJx5XXdo1MjWnCyAQRndhzxJQdgVe9ziURWBuFDT3vMwcHECqWUYRbgIGdPA== X-Received: by 2002:a2e:c52:0:b0:277:9bf:9411 with SMTP id o18-20020a2e0c52000000b0027709bf9411mr18528188ljd.504.1670225508159; Sun, 04 Dec 2022 23:31:48 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id k8-20020a05651210c800b004acff58a951sm2022349lfg.133.2022.12.04.23.31.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Dec 2022 23:31:47 -0800 (PST) Message-ID: <380178d3-7248-4200-d9db-2fd8584eb386@linaro.org> Date: Mon, 5 Dec 2022 08:31:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH v1 1/2] dt-bindings: usb: samsung,exynos-xhci: support Samsung Exynos xHCI Controller Content-Language: en-US To: Jung Daehwan Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Mathias Nyman , Arnd Bergmann , Linus Walleij , Colin Ian King , Artur Bujdoso , Juergen Gross , Tomer Maimon , "open list:USB SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , open list , sc.suh@samsung.com, taehyun.cho@samsung.com, jh0801.jung@samsung.com, eomji.oh@samsung.com References: <1669860811-171746-1-git-send-email-dh10.jung@samsung.com> <1669860811-171746-2-git-send-email-dh10.jung@samsung.com> <20221205020634.GA54922@ubuntu> From: Krzysztof Kozlowski In-Reply-To: <20221205020634.GA54922@ubuntu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/12/2022 03:06, Jung Daehwan wrote: > On Thu, Dec 01, 2022 at 09:59:06AM +0100, Krzysztof Kozlowski wrote: >> On 01/12/2022 03:13, Daehwan Jung wrote: >>> Add the Samsung Exynos xHCI Controller bindings with DT schema format. >>> >>> Signed-off-by: Daehwan Jung >>> --- >>> .../bindings/usb/samsung,exynos-xhci.yaml | 25 +++++++++++++++++++ >>> 1 file changed, 25 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/usb/samsung,exynos-xhci.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-xhci.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-xhci.yaml >>> new file mode 100644 >>> index 000000000000..c5dde53b6491 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/usb/samsung,exynos-xhci.yaml >>> @@ -0,0 +1,25 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: https://protect2.fireeye.com/v1/url?k=7899b46f-19e45c17-78983f20-74fe485fffb1-728a1b33a5d009dd&q=1&e=bdc50247-e986-43da-a15e-03ac6c3a25e8&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Fsamsung%2Cexynos-xhci.yaml%23 >>> +$schema: https://protect2.fireeye.com/v1/url?k=ea1282f0-8b6f6a88-ea1309bf-74fe485fffb1-536f21757c62f28b&q=1&e=bdc50247-e986-43da-a15e-03ac6c3a25e8&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >>> + >>> +title: Samsung Exynos xHCI >>> + >>> +maintainers: >>> + - Daehwan Jung >>> + >>> +properties: >>> + compatible: >>> + const: samsung,exynos-xhci >>> + >>> +required: >>> + - compatible >>> + >>> +additionalProperties: false >>> + >> >> These do not look like complete bindings... What type of device has no >> resources at all, just compatible? >> >> Best regards, >> Krzysztof >> >> > > It gets resources from dwc->xhci_resources as you can see > dwc3_host_init(usb/dwc3/host.c). I think it doesn't need to get another resource. You refer to driver, but we talk about hardware. Not driver. Your hardware has no resources, so this does not look like complete binding. Best regards, Krzysztof