From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se,
robh@kernel.org, hverkuil@xs4all.nl, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] omap3isp: Drop redundant isp->subdevs field and ISP_MAX_SUBDEVS
Date: Tue, 22 Aug 2017 15:30:22 +0300 [thread overview]
Message-ID: <3810750.ISKOUEcbCg@avalon> (raw)
In-Reply-To: <20170818112317.30933-2-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Friday, 18 August 2017 14:23:15 EEST Sakari Ailus wrote:
> struct omap3isp.subdevs field and ISP_MAX_SUBDEVS macro are both unused.
> Remove them.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
The field and macro are still used, you only remove them in patch 2/3. You can
squash 1/3 and 2/3 together.
> ---
> drivers/media/platform/omap3isp/isp.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/media/platform/omap3isp/isp.h
> b/drivers/media/platform/omap3isp/isp.h index e528df6efc09..848cd96b67ca
> 100644
> --- a/drivers/media/platform/omap3isp/isp.h
> +++ b/drivers/media/platform/omap3isp/isp.h
> @@ -220,9 +220,6 @@ struct isp_device {
>
> unsigned int sbl_resources;
> unsigned int subclk_resources;
> -
> -#define ISP_MAX_SUBDEVS 8
> - struct v4l2_subdev *subdevs[ISP_MAX_SUBDEVS];
> };
>
> struct isp_async_subdev {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-08-22 12:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 11:23 [PATCH v3 0/3] Unified fwnode endpoint parser Sakari Ailus
2017-08-18 11:23 ` [PATCH v3 1/3] omap3isp: Drop redundant isp->subdevs field and ISP_MAX_SUBDEVS Sakari Ailus
2017-08-22 12:30 ` Laurent Pinchart [this message]
2017-08-22 12:33 ` Sakari Ailus
2017-08-18 11:23 ` [PATCH v3 2/3] v4l: fwnode: Support generic parsing of graph endpoints in a device Sakari Ailus
[not found] ` <20170818112317.30933-3-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-08-22 12:52 ` Laurent Pinchart
2017-08-23 9:01 ` Sakari Ailus
[not found] ` <20170823090123.ztqz6usu7l5qdwkj-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2017-08-23 12:59 ` Laurent Pinchart
2017-08-24 8:01 ` Sakari Ailus
2017-08-18 11:23 ` [PATCH v3 3/3] v4l: fwnode: Support generic parsing of graph endpoints in a single port Sakari Ailus
[not found] ` <20170818112317.30933-4-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-08-22 12:55 ` Laurent Pinchart
[not found] ` <20170818112317.30933-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-08-18 14:06 ` [PATCH v3 0/3] Unified fwnode endpoint parser Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3810750.ISKOUEcbCg@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).