Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

Arnd Bergmann
2015-03-10T15:54:40Z

On Monday 09 March 2015 23:03:30 Eliad Peller wrote:
> On Mon, Mar 9, 2015 at 9:50 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday 09 March 2015 17:36:42 Eliad Peller wrote:
> >> --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts
> >> +++ b/arch/arm/boot/dts/omap3-igep0030-rev-g.dts
> >> @@ -64,4 +64,13 @@
> >> vmmc-supply = <&lbep5clwmc_wlen>;
> >> bus-width = <4>;
> >> non-removable;
> >> +
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + wlcore: wlcore@2 {
> >> + compatible = "ti,wl1835";
> >> + reg = <2>;
> >> + interrupt-parent = <&gpio5>;
> >> + interrupts = <8 IRQ_TYPE_NONE>;
> >> + };
> >>
> >
> > Why IRQ_TYPE_NONE?
> >
> i simply mirrored the current board file (which only sets the irq number).

The irq type is set in this chunk of code from wlcore_nvs_cb:

if (wl->platform_quirks & WL12XX_PLATFORM_QUIRK_EDGE_IRQ) {
irqflags = IRQF_TRIGGER_RISING;
hardirq_fn = wlcore_hardirq;
} else {
irqflags = IRQF_TRIGGER_HIGH | IRQF_ONESHOT;
}

This means you would replace the platform_quirks with setting the
correct irq type.

Arnd