From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B46CCA47B for ; Fri, 10 Jun 2022 09:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344642AbiFJJ4B (ORCPT ); Fri, 10 Jun 2022 05:56:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344854AbiFJJ4A (ORCPT ); Fri, 10 Jun 2022 05:56:00 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26C5F36E16 for ; Fri, 10 Jun 2022 02:55:58 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id v1so41760253ejg.13 for ; Fri, 10 Jun 2022 02:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=fYLaThkrJ3eihxzDkJJoKJeN/ruDQRHwWXWApkInkkA=; b=eZMqUcnQvs+mvcIh4RmsXSM85Xjm0GxOtCVFq5r1QIgnOUj23JAk0RZ5CYM8+YSH9k f7ybIkD+/HHywul6k2FzvEWj8SR1iNcawcxRgqCp0cNbU4FrnUEmDmQcF8mIN1ez667E Aq4VD6nD8UwxBRV1fjIp8o7Egebu8P+xxQbiBQVNMKHTSONgGjZXbTqn0H7tbZTVNHxh MKwzQOOe029LUFO69vjUIO1dhmMlLvtTbthq4qRZJLpmHPIDVsqIuKB7U89mdaZ2XW+M 057kmVyPGLomjrI5VMUYNgMnHZu1WjHD/iavKMoSQ2Qa0UscSO6I4dJ3+/XBVFuWPtUf Yk5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fYLaThkrJ3eihxzDkJJoKJeN/ruDQRHwWXWApkInkkA=; b=OAUzlgtmzPVoxzorGvSoBDtn27xEem2BYHxc0RdferwkSGJyytCUfc4uGvyTGWrop9 efLodGXEli8BKFJdpwh/F862f9kdRmaTmZ+5mTpBngGM7rg4VrQ+5SKb7NclEKeFEW5Z QQLi61YWJb4TN6zkOrLi87BlwB+esHII4GbrqY4QVPBQT1Zcd2Njclfgs3MFQLaghIiM oseV+iHgETwooaAE1kGh0954UNxFijI6zBe9rkjHvYFYwbVKJXktuloNYp2mdFQHOy5f wJan449YuXjMiUw6+RjJfEP1m1ZxOvowaGyH1y46as8Seoup/qb7VAtuTEwcMNYnUn69 vP8g== X-Gm-Message-State: AOAM533YKNCXLKOsCoGZDeMwnGEqFtiWW1rQRH//dtTMG0fSN/EWNWcS FNjXsoTotE67ajfF+0citk0p3g== X-Google-Smtp-Source: ABdhPJx+Nk5zqg4CzsaQGTYi5O5u5pqYvXJFs635gcflemvPBdHWm+Lqwl+EZSP0zP++5Ct8WUneEQ== X-Received: by 2002:a17:906:a06:b0:711:4f17:4391 with SMTP id w6-20020a1709060a0600b007114f174391mr28161039ejf.288.1654854956040; Fri, 10 Jun 2022 02:55:56 -0700 (PDT) Received: from [192.168.0.201] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id zc10-20020a170906988a00b006fef0c7072esm12179646ejb.144.2022.06.10.02.55.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 02:55:55 -0700 (PDT) Message-ID: <381ff739-e898-8812-d549-df7101f0eaa2@linaro.org> Date: Fri, 10 Jun 2022 11:55:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 12/20] dt-bindings: reset: npcm: Add support for NPCM8XX Content-Language: en-US To: Tomer Maimon Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , Greg KH , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , Robert Hancock , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Lubomir Rintel , devicetree , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM References: <20220608095623.22327-1-tmaimon77@gmail.com> <20220608095623.22327-13-tmaimon77@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/06/2022 00:05, Tomer Maimon wrote: > Hi Krzysztof, > > Sorry, but I thought the fix is only to add an explanation to the > dt-binding file as was done in V2. > > The NPCM8XX binding is done in the same way as the NPCM7XX and both > use the same reset driver and use the same reset method in upstreamed > NPCM reset driver. > > Can you please explain again what you suggest to do? If you want abstract IDs, they must be abstract, so not representing hardware registers. Then they start at 1 and are incremented by 1. Other option is to skip such IDs entirely and use register offsets/addresses directly, like Arnd suggested in linked documents. I think he expressed it clearly, so please read his answers which I linked in previous discussion. There is no single reason to store register addresses/values/offsets as binding headers. These are not bindings. Best regards, Krzysztof