Re: [PATCH v2 5/8] net: pxa168_eth: get and set the mac address on the Ethernet controller

Arnd Bergmann
2014-09-09T15:59:59Z

On Tuesday 09 September 2014 16:44:05 Antoine Tenart wrote:
> When changing the MAC address, in addition to updating the dev_addr in
> the net_device structure, this patch also update the MAC address
> registers (high and low) of the Ethernet controller with the new MAC.
> The address stored in these registers is used for IEEE 802.3x Ethernet
> flow control, which is already enabled.
>
> This patch also tries reading the MAC address stored in these registers
> when probing the driver, to use the MAC address set by the bootloader
> and avoid using a random one.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
>

I think it would be good to allow overriding the address using a
'mac-address' property from DT. It's very easy to call
of_get_mac_address().

Arnd