From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0C653B42F2 for ; Tue, 25 Aug 2026 19:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787686628; cv=none; b=j9fuGD9NOcGg3Kzxj/X0d71IVs7NCo+B6ERIyppgoqpIqnfRi0JGgGduPtJR6lnj4aDEy5tBO5BMhg0oH6o8O00AHPJOg/iU9ZkN72QpUkwC+cP8nw3ZKC8L6Syc8APn/qv9V+4qZiwkYSbHG9JW8Ltl6s6NiDJIHG8XdyIkyTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787686628; c=relaxed/simple; bh=7m7TNZhyYbcvU8NmAPii/n8q+O2MozWQnPW2147/foQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=rH7Aru6TakZ+lUmyJSKBkBErKLfyn6Ucqjai0zFKM/Io2/0NsRZ1kFxcg0vHrphm1U3uMbwYXkjlaJWA7Jn5fCgMtXuLKdDYXPat77W5ONinMT/Dn7SlGsMncFtY+Nc5PG4FD5lyfOTaS0YR5xN70MdtcP9/D36JfFUJANWj4bo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=luKPtGn3; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="luKPtGn3" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5B70A240103 for ; Tue, 25 Aug 2026 21:36:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1787686619; bh=p4qU8UEuk8hAWA4J8Z8HVyWYj+RRgr9W0B2GQX/5MrY=; h=Message-ID:Subject:From:To:Cc:Date:Autocrypt:Content-Type: MIME-Version:OpenPGP:From; b=luKPtGn3Uwr7q+C6llJ3Sz2tmSQk4qA3Fe5GNLGk1bL9P40+aWajI032aC8xvAiG2 WC/aaPrZIkhvz2RqasvO5hDVhCL72Xb0ngL2BGAKURYLFoC5qeoXexYtulz4IGdGLA llsr/boLtvaDIF+VbO1y09WLo5qKBnue8i6MsyjU5YL94VDx26yYURFzR4uzBH/17j VfbihwCUc/z1hVwXg+5lg/SuGlQa+Yhzwcskp0Iz+QX5UtCh+q3PnhTMoQxR0HaC65 Y15OQBUPR5N6Cvk4kt9Suum68tJa1YOpmUDomGCRFNpyaA2Qmwt0zwEsbAmRR76gjs 0qOeh8hz5jK0A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4hTyhp2kcNz9rxB; Tue, 25 Aug 2026 21:36:58 +0200 (CEST) Message-ID: <3827a4e6be868e8726c140281a140a85e706aacc.camel@posteo.de> Subject: Re: [PATCH v6 5/6] rtc: s35390a: Add pinctrl From: Markus Probst To: Linus Walleij , sashiko-reviews@lists.linux.dev Cc: Alexandre Belloni , devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org Date: Tue, 25 Aug 2026 19:36:59 +0000 In-Reply-To: References: <20260824-rtc_s35390a_int1-v6-0-df96569e3412@posteo.de> <20260824-rtc_s35390a_int1-v6-5-df96569e3412@posteo.de> <20260823222611.B176B1F000E9@smtp.kernel.org> Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=mQINBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93 qReNLkOWguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVA m76Ww+/pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt 9k5JARhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbm fAjaoT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwT jRQxBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1 J+FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN 6OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJCX CeMe4BO4iaxUQARAQABtCdNYXJrdXMgUHJvYnN0IDxtYXJrdXMucHJvYnN0QHBvc3Rlby5kZT6JAl QEEwEIAD4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AWIQSCdBjE9KxY53IwxHM0dh/4561 D0gUCaIZ9HQIZAQAKCRA0dh/4561D0pKmD/92zsCfbD+SrvBpNWtbit7J9wFBNr9qSFFm2n/65qen NNWKDrCzDsjRbALMHSO8nigMWzjofbVjj8Nf7SDcdapRjrMCnidS0DuW3pZBo6W0sZqV/fLx+AzgQ 7PAr6jtBbUoKW/GCGHLLtb6Hv+zjL17KGVO0DdQeoHEXMa48mJh8rS7VlUzVtpbxsWbb1wRZJTD88 ALDOLTWGqMbCTFDKFfGcqBLdUT13vx706Q29wrDiogmQhLGYKc6fQzpHhCLNhHTl8ZVLuKVY3wTT+ f9TzW1BDzFTAe3ZXsKhrzF+ud7vr6ff9p1Zl+Nujz94EDYHi/5Yrtp//+N/ZjDGDmqZOEA86/Gybu 6XE/v4S85ls0cAe37WTqsMCJjVRMP52r7Y1AuOONJDe3sIsDge++XFhwfGPbZwBnwd4gEVcdrKhnO ntuP9TvBMFWeTvtLqlWJUt7n8f/ELCcGoO5acai1iZ59GC81GLl2izObOLNjyv3G6hia/w50Mw9MU dAdZQ2MxM6k+x4L5XeysdcR/2AydVLtu2LGFOrKyEe0M9XmlE6OvziWXvVVwomvTN3LaNUmaINhr7 pHTFwDiZCSWKnwnvD2+jA1trKq1xKUQY1uGW9XgSj98pKyixHWoeEpydr+alSTB43c3m0351/9rYT TTi4KSk73wtapPKtaoIR3rOFHLQXbWFya3VzLnByb2JzdEBwb3N0ZW8uZGWJAlEEEwEIADsWIQSCd BjE9KxY53IwxHM0dh/4561D0gUCaIO9eAIbAwULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgAAKCR A0dh/4561D0oHZEACEmk5Ng9+OXoVxJJ+c9slBI2lYxyBO84qkWjoJ/0GpwoHk1IpyL+i+kF1Bb7y Hx9Tiz8ENYX7xIPTZzS8hXs1ksuo76FQUyD6onA/69xZIrYZ0NSA5HUo62qzzMSZL7od5e12R6OPR lR0PIuc4ecOGCEq3BLRPfZSYrL54tiase8HubXsvb6EBQ8jPI8ZUlr96ZqFEwrQZF/3ihyV6LILLk geExgwlTzo5Wv3piOXPTITBuzuFhBJqEnT25q2j8OumGQ+ri8oVeAzx24g1kc11pwpR0sowfa5MvZ WrrBcaIL7uJfR/ig7FyGnTQ1nS3btf3p0v8A3fc4eUu/K2No3l2huJp3+LHhCmpmeykOhSB63Mj3s 3Q87LD0HE0HBkTEMwp+sD97ZRpO67H5shzJRanUaDTb/mREfzpJmRT1uuec0X2zItL7a6itgMJvYI KG29aJLX3fTzzVzFGPgzVZYEdhu4y53p0qEGrrC1JtKR6DRPE1hb/OdWOkjmJ75+PPLD9U5IuRd6y sHJWsEBR1F0wkMPkEofWsvMYJzWXx/rvTWO8N4D6HigTgBXAXNgbc3IHpHlkvKoBJptv6DRVRtIrz 0G0cfBY0Sm7he4N2IYDWWdGnPBZ3rlLSdj5EiBU2YWgIgtLrb8ZNJ3ZlhYluGnBJDGRqy2jC9s1jY 66sLA9rQZMHhJTzMyIDwweGlvMzJAcG9zdGVvLmV1PokCbQQTAQgAVxYhBIJ0GMT0rFjncjDEczR2 H/jnrUPSBQJpa71VGxSAAAAAAAQADm1hbnUyLDIuNSsxLjExLDIsMgIbAwULCQgHAgIiAgYVCgkIC wIEFgIDAQIeBwIXgAAKCRA0dh/4561D0gKJD/9uOQKYlsDoQX65Gd0LiMT0C+5vXgr3VI0PHDOwcv 51fJ3A1vNyPZRFPGrz8+mDEXUQOF/INfnz5Tu1QHwf+iYcWcTGAN/FHgVR6ET6VBNU2hJaKhu+Ggo kjYyJTOvyX+3yNRUfSny0GjTjIPuPTErjqmHF+BtjXslpgwqnNMznf3lRIuUjRORupos6p3k1DndE 5vzUTmXSvMyXyOD2KhBl/kL76k0bHYyAQytZPag12pltrtFbA/r2phDGN2si8PooDT99bSTJjaM45 MTAAHbHKJfvgfK41bNFD5mMtpWpL195XRtS0Nrxdg3PaYBxN5gtTG0RyZfpYRlkdEhm+jj/8RxuSG i/qdhRdbiI7K2IELWeQVHSNDi9JabR/UzlR4NSnhfAjRIVlRM+eFbUl8XwxwVrAkojF5IraH2qRvg VCmuFsHUW07FUlrDrzpjXsD73cKppoFGDCdDR0BHJepXbFLS9+AqkT+guRJlnCTg2p+TQtnbwPgKp Vj98JixovCl99zRYTsL2bRNU5+q8iET65VMJ1ydyNanvLd5vI/NqDkXhlXLsGmdaDTtu4R21PkToX dQNGrZ91M9nlIBKw8Y7c7xZ4098qX2b8JX/CxD+gC1r4C8vuA3GkhFLx+KlkON7LyiJPkrePp6Qky jfGillcaQOqFZ3WwVqyzG1BUfTow== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-HigqI20tf/dH56WXWSZ/" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt --=-HigqI20tf/dH56WXWSZ/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2026-08-25 at 21:28 +0200, Linus Walleij wrote: > On Mon, Aug 24, 2026 at 12:26=E2=80=AFAM wrote: >=20 > > > config RTC_DRV_S35390A > > > tristate "Seiko Instruments S-35390A" > > > + depends on PINCTRL > >=20 > > [Severity: High] > > Will this unconditional dependency cause the RTC driver to be silently = dropped > > on platforms without PINCTRL enabled? >=20 > Maybe just select PINCTRL then, it's a valid point. >=20 > > > + err =3D pinctrl_enable(pctl); > > > + if (err) > > > + return dev_err_probe(dev, err, "pinctrl enable failed\n= "); > > > + > > > + /* If no pinmux function is defined in DT, fallback to previous= behaviour */ > > > + fallback[0] =3D S35390A_FUNC_IGNORE; > > > + fallback[1] =3D S35390A_FUNC_WAKEUP; > > > + > > > + for (i =3D 0; i < ARRAY_SIZE(s35390a_pin_groups); i++) { > > > + if (s35390a->pinfunction[i] =3D=3D -1) { > >=20 > > [Severity: Medium] > > Is there a data race here since the pinfunction array is accessed lockl= essly > > after pinctrl_enable() has made the pinctrl device available? >=20 > That's a valid concern. I don't think so. `s35390a_pinctrl_set_mux` itself will take a lock for the operation. `pinfunction[i]` is a 32-bit integer, so there should be no load tearing. If we take a lock here, it shouldn't change anything. In a normal condition this shouldn't happen anyway, as `pinctrl_enable` should block until the default state is selected. If another driver is concurrently selecting a pinctrl state of this device while we probe (which is the only time pinfunction should be modified here concurrently), it is still a race condition whether the fallback applies or not. Thanks - Markus Probst >=20 > Yours, > Linus Walleij --=-HigqI20tf/dH56WXWSZ/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQJPBAABCAA5FiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IFAmqN7tQbFIAAAAAABAAO bWFudTIsMi41KzEuMTIsMiwyAAoJEDR2H/jnrUPSQg4P/izzncyNk2s4i2KbAmF8 DyrPryK/Za2VM2tJwnPq1yVS5A8DWfnCoA2+bRjBkNY2XlT/R5Fn+76qvjJKipfo G/93ift9ra3MaShNhvGypUg7d2x2gWe8tb+PNBazlPdevejZBAxzf9X0rlI3IFCX Urvq/9bPEY9OrFIdl9RViWESlncGxofN99XztvGNBIKr7EXlrkkqGwq46lfk2T6l aD95kqboD+EAhTXQr3xEele5y2ctimcY9J09uS9AE7pSv9fAg63Xpf75mgeztp/g dosYx4/8bwZhrULSc44585hUqcIFQdAA1eMRPT45bbBKEkoa4cudeA9NMa9PIpUE P9YcXF0JPFQk6xgEeq3wiFTl6XPd9mBTWaw15YlW5Eltce4478J5q0qUqMuxXxgI aZAq/MtCyMWRjBF9ZFoKRMKHXE39txWG3qCSqGQ3Xz/01xJZOlG8fWkDXJsV7sgy sv07fLSDgp2AJBgOka0GvnutpzjjujTnjbdYXbAk7CbJuf1cPg+XosLsoVw+WA8G /BcGbBXQmxEONjLNYmHs/yFL8gRlRTbYKt7bWsEb/uL6vpYwIRX4Gnq6D8sy+vmO ObzBOH0k6s/gIRzRiqvrCMRFHFwiD3nKL+8JJQ86Zn3FQQOZrOsS2aafG/yeatHp nVCOIgxNYZpsHVgb4zlqjEcq =877B -----END PGP SIGNATURE----- --=-HigqI20tf/dH56WXWSZ/--