From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5267DC433EF for ; Thu, 17 Mar 2022 09:34:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230183AbiCQJfw (ORCPT ); Thu, 17 Mar 2022 05:35:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231987AbiCQJfv (ORCPT ); Thu, 17 Mar 2022 05:35:51 -0400 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3634D16C084; Thu, 17 Mar 2022 02:34:35 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id x15so6438334wru.13; Thu, 17 Mar 2022 02:34:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sWJXxumggqkeiId/uryaGdIFQhUjPzM/H86XSQncuv4=; b=AN8qKPkU6ZQe4xpdx8+vHNLtlO3e7RbO/eMGndOcXUkNhjBtAUKKz9qxmvgW60C7hT YE5p/R9LxEBFKZ9jrQnpZ60M6Np/QhXflkj0SV+GMlMVOOp1NoWEX9xguiNCkofW6HcS 6iG5cloJd3opm1g1ICC5brJUeAbCfHhygPRMEE7V0qiJiS44GV9zCaAAcePj77hgxh+p XQ6M8av4htb3zh3OL7bPw/hvi1Nwilzgk8NTx+EW8qlVRb565ctLZV4AAUBnrdiank6+ GLJIeq2/vy/4ty/8HT+3NpRoemXVYbuWCeabPKa/lUizJEhWPAuZlwUhHwF9uoCkiMCX Cbrw== X-Gm-Message-State: AOAM531Ee1fp+JSj5jjGnBeZgqE/Rh5dWsa7oEQhq43dK6jSqsvZ70QR 0FuHkGE4mmTmTe6bWmRB9tQ= X-Google-Smtp-Source: ABdhPJxHOdLhJhlAVBYo1oJlNZ4aWgDo2Hdsjm7E0SRhNq6Y4fIHNktuOUpzgNYnKItKDquR0sUcWw== X-Received: by 2002:adf:8003:0:b0:1f1:d81b:d752 with SMTP id 3-20020adf8003000000b001f1d81bd752mr3108143wrk.429.1647509673521; Thu, 17 Mar 2022 02:34:33 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id u11-20020a056000038b00b00203e5c9aa09sm2723905wrf.27.2022.03.17.02.34.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Mar 2022 02:34:33 -0700 (PDT) Message-ID: <3828e37f-f8e0-8473-537c-8e47cd5df8c6@kernel.org> Date: Thu, 17 Mar 2022 10:34:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 1/3] dt-bindings: chrome: Add ChromeOS fingerprint binding Content-Language: en-US To: Stephen Boyd , Benson Leung Cc: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, Rob Herring , devicetree@vger.kernel.org, Guenter Roeck , Douglas Anderson , Craig Hesling , Tom Hughes , Alexandru M Stan , Tzung-Bi Shih References: <20220317005814.2496302-1-swboyd@chromium.org> <20220317005814.2496302-2-swboyd@chromium.org> From: Krzysztof Kozlowski In-Reply-To: <20220317005814.2496302-2-swboyd@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/03/2022 01:58, Stephen Boyd wrote: > Add a binding to describe the fingerprint processor found on Chromebooks > with a fingerprint sensor. > > Cc: Rob Herring > Cc: > Cc: Guenter Roeck > Cc: Douglas Anderson > Cc: Craig Hesling > Cc: Tom Hughes > Cc: Alexandru M Stan > Cc: Tzung-Bi Shih > Signed-off-by: Stephen Boyd > --- > .../bindings/chrome/google,cros-ec-fp.yaml | 85 +++++++++++++++++++ > 1 file changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/chrome/google,cros-ec-fp.yaml > > diff --git a/Documentation/devicetree/bindings/chrome/google,cros-ec-fp.yaml b/Documentation/devicetree/bindings/chrome/google,cros-ec-fp.yaml > new file mode 100644 > index 000000000000..ba4212e6b583 > --- /dev/null > +++ b/Documentation/devicetree/bindings/chrome/google,cros-ec-fp.yaml Hm, so chrome starts to be its own subsystem? I see USB connector bindings are already there, instead of usb directory. Is there anything special about Chrome that it is equal to subsystem or architecture? Once second file ends up there, this will encourage more of such patterns. > @@ -0,0 +1,85 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/chrome/google,cros-ec-fp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ChromeOS Embedded Fingerprint Controller > + > +description: > + Google's ChromeOS embedded fingerprint controller is a device which > + implements fingerprint functionality such as unlocking a Chromebook > + without typing a password. > + > +maintainers: > + - Tom Hughes > + > +properties: > + compatible: > + const: google,cros-ec-fp > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 3000000 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: true > + boot0-gpios: > + maxItems: 1 > + description: Assert for bootloader mode. > + > + vdd-supply: true > + > + google,cros-ec-spi-pre-delay: Use proper unit suffix, so "-us". No need for type then. > + description: > + This property specifies the delay in usecs between the > + assertion of the CS and the first clock pulse. > + allOf: No need for allOf. Just put default/minimum directly. > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - default: 0 > + - minimum: 0 > + > + google,cros-ec-spi-msg-delay: > + description: > + This property specifies the delay in usecs between messages. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - default: 0 > + - minimum: 0 Same here (proper suffix + allOf). Best regards, Krzysztof