* [PATCH] arm64: dts: qcom: sdm845-akatsuki: Round down l22a regulator voltage
@ 2022-06-20 21:12 Marijn Suijten
2022-06-20 21:13 ` Konrad Dybcio
2022-06-28 20:19 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Marijn Suijten @ 2022-06-20 21:12 UTC (permalink / raw)
To: phone-devel
Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Konrad Dybcio, Martin Botka, Jami Kettunen, Marijn Suijten,
Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel
2700000 is not a multiple of pmic4_pldo's step size of 8000 (with base
voltage 1664000), resulting in pm8998-rpmh-regulators not probing. Just
as we did with MSM8998's Sony Yoshino Poplar [1], round the voltages
down to err on the cautious side and leave a comment in place to
document this discrepancy wrt downstream sources.
[1]: https://lore.kernel.org/linux-arm-msm/20220507153627.1478268-1-marijn.suijten@somainline.org/
Fixes: 30a7f99befc6 ("arm64: dts: qcom: Add support for SONY Xperia XZ2 / XZ2C / XZ3 (Tama platform)")
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
---
.../arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
index 36ff1178b705..3839850cf7dd 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
@@ -22,8 +22,9 @@ &vreg_l14a_1p8 {
};
&vreg_l22a_2p8 {
- regulator-min-microvolt = <2700000>;
- regulator-max-microvolt = <2700000>;
+ /* Note: Round-down from 2700000 to be a multiple of PLDO step-size 8000 */
+ regulator-min-microvolt = <2696000>;
+ regulator-max-microvolt = <2696000>;
};
&vreg_l28a_2p8 {
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845-akatsuki: Round down l22a regulator voltage
2022-06-20 21:12 [PATCH] arm64: dts: qcom: sdm845-akatsuki: Round down l22a regulator voltage Marijn Suijten
@ 2022-06-20 21:13 ` Konrad Dybcio
2022-06-28 20:19 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2022-06-20 21:13 UTC (permalink / raw)
To: Marijn Suijten, phone-devel
Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Martin Botka, Jami Kettunen, Andy Gross, Bjorn Andersson,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree,
linux-kernel
On 20.06.2022 23:12, Marijn Suijten wrote:
> 2700000 is not a multiple of pmic4_pldo's step size of 8000 (with base
> voltage 1664000), resulting in pm8998-rpmh-regulators not probing. Just
> as we did with MSM8998's Sony Yoshino Poplar [1], round the voltages
> down to err on the cautious side and leave a comment in place to
> document this discrepancy wrt downstream sources.
>
> [1]: https://lore.kernel.org/linux-arm-msm/20220507153627.1478268-1-marijn.suijten@somainline.org/
>
> Fixes: 30a7f99befc6 ("arm64: dts: qcom: Add support for SONY Xperia XZ2 / XZ2C / XZ3 (Tama platform)")
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> .../arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
> index 36ff1178b705..3839850cf7dd 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
> @@ -22,8 +22,9 @@ &vreg_l14a_1p8 {
> };
>
> &vreg_l22a_2p8 {
> - regulator-min-microvolt = <2700000>;
> - regulator-max-microvolt = <2700000>;
> + /* Note: Round-down from 2700000 to be a multiple of PLDO step-size 8000 */
> + regulator-min-microvolt = <2696000>;
> + regulator-max-microvolt = <2696000>;
> };
>
> &vreg_l28a_2p8 {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845-akatsuki: Round down l22a regulator voltage
2022-06-20 21:12 [PATCH] arm64: dts: qcom: sdm845-akatsuki: Round down l22a regulator voltage Marijn Suijten
2022-06-20 21:13 ` Konrad Dybcio
@ 2022-06-28 20:19 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-06-28 20:19 UTC (permalink / raw)
To: Marijn Suijten, phone-devel
Cc: linux-kernel, devicetree, ~postmarketos/upstreaming, Martin Botka,
linux-arm-msm, Jami Kettunen, Krzysztof Kozlowski, Andy Gross,
Rob Herring, AngeloGioacchino Del Regno, Konrad Dybcio
On Mon, 20 Jun 2022 23:12:12 +0200, Marijn Suijten wrote:
> 2700000 is not a multiple of pmic4_pldo's step size of 8000 (with base
> voltage 1664000), resulting in pm8998-rpmh-regulators not probing. Just
> as we did with MSM8998's Sony Yoshino Poplar [1], round the voltages
> down to err on the cautious side and leave a comment in place to
> document this discrepancy wrt downstream sources.
>
> [1]: https://lore.kernel.org/linux-arm-msm/20220507153627.1478268-1-marijn.suijten@somainline.org/
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sdm845-akatsuki: Round down l22a regulator voltage
commit: 4148a9eeb15152865d60b0913d96beb7ca166f9a
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-28 20:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-20 21:12 [PATCH] arm64: dts: qcom: sdm845-akatsuki: Round down l22a regulator voltage Marijn Suijten
2022-06-20 21:13 ` Konrad Dybcio
2022-06-28 20:19 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).