From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B43CCCA481 for ; Mon, 20 Jun 2022 21:15:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231604AbiFTVPY (ORCPT ); Mon, 20 Jun 2022 17:15:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343837AbiFTVN3 (ORCPT ); Mon, 20 Jun 2022 17:13:29 -0400 Received: from relay05.th.seeweb.it (relay05.th.seeweb.it [IPv6:2001:4b7a:2000:18::166]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50BDA6453 for ; Mon, 20 Jun 2022 14:13:22 -0700 (PDT) Received: from [192.168.1.101] (abxh227.neoplus.adsl.tpnet.pl [83.9.1.227]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 9102C3EE24; Mon, 20 Jun 2022 23:35:32 +0200 (CEST) Message-ID: <3840f74b-91dc-25ab-e5db-a63cc198b111@somainline.org> Date: Mon, 20 Jun 2022 23:13:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] arm64: dts: qcom: sdm845-akatsuki: Round down l22a regulator voltage Content-Language: en-US To: Marijn Suijten , phone-devel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220620211212.269956-1-marijn.suijten@somainline.org> From: Konrad Dybcio In-Reply-To: <20220620211212.269956-1-marijn.suijten@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20.06.2022 23:12, Marijn Suijten wrote: > 2700000 is not a multiple of pmic4_pldo's step size of 8000 (with base > voltage 1664000), resulting in pm8998-rpmh-regulators not probing. Just > as we did with MSM8998's Sony Yoshino Poplar [1], round the voltages > down to err on the cautious side and leave a comment in place to > document this discrepancy wrt downstream sources. > > [1]: https://lore.kernel.org/linux-arm-msm/20220507153627.1478268-1-marijn.suijten@somainline.org/ > > Fixes: 30a7f99befc6 ("arm64: dts: qcom: Add support for SONY Xperia XZ2 / XZ2C / XZ3 (Tama platform)") > Signed-off-by: Marijn Suijten > --- Reviewed-by: Konrad Dybcio Konrad > .../arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts > index 36ff1178b705..3839850cf7dd 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts > @@ -22,8 +22,9 @@ &vreg_l14a_1p8 { > }; > > &vreg_l22a_2p8 { > - regulator-min-microvolt = <2700000>; > - regulator-max-microvolt = <2700000>; > + /* Note: Round-down from 2700000 to be a multiple of PLDO step-size 8000 */ > + regulator-min-microvolt = <2696000>; > + regulator-max-microvolt = <2696000>; > }; > > &vreg_l28a_2p8 {