From: "Heiko Stübner" <heiko@sntech.de>
To: cl@rock-chips.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
zhengxing@rock-chips.com, andy.yan@rock-chips.com,
jay.xu@rock-chips.com, matthias.bgg@gmail.com,
paweljarosz3691@gmail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
wsa@the-dreams.de, linux-i2c@vger.kernel.org, jic23@kernel.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
wxt@rock-chips.com, david.wu@rock-chips.com,
linux-iio@vger.kernel.org, shawn.lin@rock-chips.com,
akpm@linux-foundation.org, dianders@chromium.org,
yamada.masahiro@socionext.com, catalin.marinas@arm.com,
will.deacon@arm.com, afaerber@suse.de, shawnguo@kernel.org,
khilman@baylibre.com, arnd@arndb.de, fabio.estevam@nxp.com,
zhangqing@rock-chips.com, kever.yang@rock-chips.com
Subject: Re: [PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl
Date: Thu, 16 Mar 2017 09:02:47 +0100 [thread overview]
Message-ID: <3841077.a8qRkotiEM@diego> (raw)
In-Reply-To: <1489572237-6649-2-git-send-email-cl@rock-chips.com>
Hi,
Am Mittwoch, 15. März 2017, 18:03:51 CET schrieb cl@rock-chips.com:
> From: Chen Liang <cl@rock-chips.com>
>
> The rk3328 soc need more pin function index for pinctrl.
>
> Signed-off-by: Chen Liang <cl@rock-chips.com>
> ---
> include/dt-bindings/pinctrl/rockchip.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/dt-bindings/pinctrl/rockchip.h
> b/include/dt-bindings/pinctrl/rockchip.h index aaec8ba..bc2b6af 100644
> --- a/include/dt-bindings/pinctrl/rockchip.h
> +++ b/include/dt-bindings/pinctrl/rockchip.h
> @@ -63,5 +63,8 @@
> #define RK_FUNC_2 2
> #define RK_FUNC_3 3
> #define RK_FUNC_4 4
> +#define RK_FUNC_5 5
> +#define RK_FUNC_6 6
> +#define RK_FUNC_7 7
please don't amend that function list anymore.
Only RK_FUNC_GPIO serves a real purpose but having constants FUNC_7 mapping
simply to 7 does not help understand things better, so it's way easier to just
have "7" as function in pinctrl entries in the devicetree.
That list is mainly a remnant to keep compatibility with old devicetrees and I
guess I should add a deprecated notice at some point :-) .
Heiko
next prev parent reply other threads:[~2017-03-16 8:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 10:03 [PATCH v1 0/7] initialize dtsi file and dts file for RK3328 SoCs cl-TNX95d0MmH7DzftRWevZcw
[not found] ` <1489572237-6649-1-git-send-email-cl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-03-15 10:03 ` [PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl cl-TNX95d0MmH7DzftRWevZcw
2017-03-16 8:02 ` Heiko Stübner [this message]
2017-03-15 10:03 ` [PATCH v1 2/7] dt-bindings: iio: rockchip-saradc: add support for rk3328 cl-TNX95d0MmH7DzftRWevZcw
2017-03-16 8:28 ` Heiko Stuebner
2017-03-19 10:34 ` Jonathan Cameron
2017-03-15 10:03 ` [PATCH v1 3/7] dt-bindings: i2c: rk3x: " cl-TNX95d0MmH7DzftRWevZcw
2017-03-16 8:29 ` Heiko Stuebner
2017-03-15 10:03 ` [PATCH v1 4/7] dt-bindings: soc: rockchip: grf: " cl-TNX95d0MmH7DzftRWevZcw
2017-03-15 11:11 ` [PATCH v1 0/7] initialize dtsi file and dts file for RK3328 SoCs Heiko Stübner
2017-03-16 1:44 ` [PATCH v1 5/7] arm64: dts: rockchip: add core dtsi " cl
2017-03-16 16:15 ` Andre Przywara
2017-03-16 1:45 ` [PATCH v1 6/7] arm64: dts: rockchip: add dts file for RK3328 evaluation board cl
2017-03-16 16:18 ` Andre Przywara
2017-03-17 2:26 ` 陈亮
[not found] ` <58CB4945.9020408-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-03-17 8:45 ` Heiko Stuebner
2017-03-21 7:59 ` 陈亮
[not found] ` <58D0DD76.8090909-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-03-21 8:57 ` Heiko Stübner
2017-03-16 1:45 ` [PATCH v1 7/7] dt-bindings: document rockchip rk3328-evb board cl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3841077.a8qRkotiEM@diego \
--to=heiko@sntech.de \
--cc=afaerber@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andy.yan@rock-chips.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cl@rock-chips.com \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=fabio.estevam@nxp.com \
--cc=jay.xu@rock-chips.com \
--cc=jic23@kernel.org \
--cc=kever.yang@rock-chips.com \
--cc=khilman@baylibre.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=paweljarosz3691@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=shawnguo@kernel.org \
--cc=will.deacon@arm.com \
--cc=wsa@the-dreams.de \
--cc=wxt@rock-chips.com \
--cc=yamada.masahiro@socionext.com \
--cc=zhangqing@rock-chips.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).