Re: [PATCH tty-next v2 4/4] Documentation: devicetree: add bindings documentation for bcm63xx-uart

Arnd Bergmann
2014-02-21T12:49:05Z

Two more comments:

On Thursday 20 February 2014 10:15:54 Florian Fainelli wrote:
> +- clock-names: should contain "periph" for the functional clock

I think we should really start standardizing on the clock names more.
We don't have any uart that calls its functional clock "periph" so
far.

How about naming it "fclk" or "uart"?

I'd actually prefer making it an anonymous clock, but I know that
will just trigger comments about what might happen if it turns
out we need more than one clock for a future version of this device.

> +Example:
> +
> +serial0: uart@600 {
> + compatible = "brcm,bcm6345-uart";
> + reg = <0x600 0x1b>;
> + interrupts = <GIC_SPI 32 0>;
> + clocks = <&periph_clk>;
> + clock-names = "periph";
> +};

The device name for a uart is "serial" by convention, not "uart",
so better make this serial@600.

Arnd