From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 195DEC2D0E9 for ; Thu, 26 Mar 2020 19:44:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED29620714 for ; Thu, 26 Mar 2020 19:44:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728619AbgCZToI (ORCPT ); Thu, 26 Mar 2020 15:44:08 -0400 Received: from smtprelay0223.hostedemail.com ([216.40.44.223]:42186 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728317AbgCZToH (ORCPT ); Thu, 26 Mar 2020 15:44:07 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 9A217181D41BF; Thu, 26 Mar 2020 19:44:06 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: laugh42_7acb8a21a4a4b X-Filterd-Recvd-Size: 2711 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Thu, 26 Mar 2020 19:44:03 +0000 (UTC) Message-ID: <385ff77269e5df76c917d494de012a8f83fea31e.camel@perches.com> Subject: Re: [PATCH net-next 6/9] net: phy: add backplane kr driver support From: Joe Perches To: David Miller Cc: florinel.iordache@nxp.com, netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, kuba@kernel.org, corbet@lwn.net, shawnguo@kernel.org, leoyang.li@nxp.com, madalin.bucur@oss.nxp.com, ioana.ciornei@nxp.com, linux-kernel@vger.kernel.org Date: Thu, 26 Mar 2020 12:42:11 -0700 In-Reply-To: <20200326.120743.1932411612374465145.davem@davemloft.net> References: <1585230682-24417-7-git-send-email-florinel.iordache@nxp.com> <20200326.115330.2250343131621391364.davem@davemloft.net> <46bf05a81237ed716bf06b48891fcd7c129eae5d.camel@perches.com> <20200326.120743.1932411612374465145.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 2020-03-26 at 12:07 -0700, David Miller wrote: > From: Joe Perches > Date: Thu, 26 Mar 2020 11:55:17 -0700 > > > On Thu, 2020-03-26 at 11:53 -0700, David Miller wrote: > >> From: Florinel Iordache > >> Date: Thu, 26 Mar 2020 15:51:19 +0200 > >> > >> > +static void kr_reset_master_lane(struct kr_lane_info *krln) > >> > +{ > >> > + struct phy_device *bpphy = krln->bpphy; > >> > + struct backplane_phy_info *bp_phy = bpphy->priv; > >> > + const struct lane_io_ops *lane_ops = krln->bp_phy->bp_dev.lane_ops; > >> > >> Please use reverse christmas tree ordering for local variables. > > > > How (any why) do you suggest the first 2 entries here > > should be ordered? > > You have to sometimes put assignments into the code body rather than > the declarations in situations like this. No "why" reply given. An option is not using reverse christmas tree to both avoid ordering constraints and reduce overall line count. I think this is your own personal taste rather than an actual valuable addition for subsystem maintenance. And if this a serious requirement for the subsystem you oversee, you should add it to something like a maintainer-entry-profile with a "P:" line in MAINTAINERS. https://www.kernel.org/doc/html/latest/maintainer/maintainer-entry-profile.html