From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9210C2D0E2 for ; Tue, 22 Sep 2020 11:22:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96C792388B for ; Tue, 22 Sep 2020 11:22:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HFkCRyZ/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbgIVLWm (ORCPT ); Tue, 22 Sep 2020 07:22:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726454AbgIVLWm (ORCPT ); Tue, 22 Sep 2020 07:22:42 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7FD7C0613CF for ; Tue, 22 Sep 2020 04:22:41 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id g4so16617870wrs.5 for ; Tue, 22 Sep 2020 04:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KcHBNX7nlokKK8kXMf7m8iqw5HFaqgsL1z5AnKdw5mI=; b=HFkCRyZ/G04J1NQM/rjpr4zU+6zo1oRGQLNqubIT4svzl5PHzy4iRgnOurNoDiI+Gi MXvyGTRi0Z0M5B6IopUrBYm9enSxRWJM5DL+VfI4K6tad9FBRV3XF4cJiW1MiSQVyF+I 35Fg2wVjsjmBxcuTvBy+PbR0MjEnh5qRCk3phLYnJYAauDA71gn39IDbMsgXObjAgK0p i+KukRYF9A5kA/Xz1g7Ln4BZBwE2A/IlGSJKr19MLpYW9bHEWY8jbr+rrX94VtW/S1+p aLBNlVR6tinobS/05m0JH2pXzvGToQ2BIMswIsiwvB3e2DeUqzQmUmYtBDnC6ufG5KP7 6BgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KcHBNX7nlokKK8kXMf7m8iqw5HFaqgsL1z5AnKdw5mI=; b=on1ZRFAymEBMgCw4zol1XT83ptL9ezifqHq4XEnjDkRJPQTNDw61BQlfaAgTsqiO6f ATBDzbScz0qmKtyoLA81Y19b4jnYvFuq1Rl6nq521R/5Madml5aJEylqXl+p0S28kazC wTp5AwYN3WP4hx1ZBp54DCY+9WrZ9J+0SwKRkljRNxTRjDj991TK4tIwvOJYk8BeyNdY PDeGZPUiOdI8Swou/N4Rt304wq92euUNWCJyI9zrC5e7avVk2MHHpaNS5GtYfcnXb20a mjYBg7svJS+x8vmGie/jkhsjXXKN/UcmxoCKqetR9elsY7h9yrF+x39ua37Pv7BuZt0F ZyCQ== X-Gm-Message-State: AOAM532GHQmi+8hcZVHNh4L/ZbDfgHrsCXqL6jf5uulE1lgx1wZ/nNe0 6vMiEzb85IlW8RWVdI3JPEe9IA== X-Google-Smtp-Source: ABdhPJwoirXaeQd83hSfKFcPFFMyZX+E/QOqT24xhgtDSOc64OlQ49XFn+VCUoLu28OplXJhN5OQGg== X-Received: by 2002:a05:6000:109:: with SMTP id o9mr4276415wrx.364.1600773760449; Tue, 22 Sep 2020 04:22:40 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id n10sm4494807wmk.7.2020.09.22.04.22.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Sep 2020 04:22:39 -0700 (PDT) Subject: Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API To: Mark Brown Cc: Srinivasa Rao Mandadapu , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, V Sujith Kumar Reddy References: <1600409084-29093-1-git-send-email-srivasam@codeaurora.org> <1600409084-29093-4-git-send-email-srivasam@codeaurora.org> <040290a8-26a3-ab9c-04dc-beb23ee827e8@linaro.org> <20200922110825.GN4792@sirena.org.uk> From: Srinivas Kandagatla Message-ID: <3866ce69-b7d0-5eb5-e0aa-874d150cd47a@linaro.org> Date: Tue, 22 Sep 2020 12:22:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200922110825.GN4792@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/09/2020 12:08, Mark Brown wrote: >> On 18/09/2020 07:04, Srinivasa Rao Mandadapu wrote: >>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif"); >> Index is always preferred over name w.r.t device tree bindings, so lets >> stick with that for now! > It is? That's not usually the case... > >> Unless you have any strong reason to lookup resource by name? > Looking things up by name tends to make the DT easier to read (since > things are named). I agree with you on this and I see the point, but Rob had a very different opinion about the reg-names bindings to start with. This topic been discussed in the past with Rob in many instances ex: https://lore.kernel.org/linux-devicetree/CAL_Jsq+MMunmVWqeW9v2RyzsMKP+=kMzeTHNMG4JDHM7Fy0HBg@mail.gmail.com/ According to him, reg-names seems to be highly discouraged as it came along for the OMAP folks and was related to the hwmods stuff. --srini