From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2CD8C43331 for ; Wed, 1 Apr 2020 13:21:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8AD720776 for ; Wed, 1 Apr 2020 13:21:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mm-sol.com header.i=@mm-sol.com header.b="hOQ+FwI4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732575AbgDANV0 (ORCPT ); Wed, 1 Apr 2020 09:21:26 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:34561 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732557AbgDANV0 (ORCPT ); Wed, 1 Apr 2020 09:21:26 -0400 Received: from [192.168.1.3] (212-5-158-187.ip.btc-net.bg [212.5.158.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by extserv.mm-sol.com (Postfix) with ESMTPSA id E352ECFAB; Wed, 1 Apr 2020 16:21:23 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mm-sol.com; s=201706; t=1585747284; bh=jQLOaV/9gNCw8k6Dt09Ffv5U8fBSYoigBETbYtsrfGg=; h=Subject:To:Cc:From:Date:From; b=hOQ+FwI48FvfF4wgRCrjSPX9HRQope4b+LmxDEKYjeqnGLh8jbjR0tx1EX+E5ptKp 0ytSgtjowjMUO6eybbWh+YvQnCL+0oAo+NdYwfBY8qw3iNMidnhC1bbXhw65uBYczK A1vmXZOtyKyq+P5MwGPWp0+WazbYk2SEBkcd9IusLpfeYHjOxhHERPuYl0L6NFI5lU I7mdYarbwmXm2EEzzlaiTxsDvPt/yDv7p4UPMjTJzyxbIGJ7jVdPvocgrHXI9N8MO5 V3Mdd3SPEVWwVooVP7+RFnGIR41vehx8QXe3q4+OgF/7T/7ScF93OPUEBbGLzE91eB mYz1QcKewFzjA== Subject: Re: [PATCH 09/12] pcie: qcom: Programming the PCIE iATU for IPQ806x To: Ansuel Smith Cc: Sham Muthayyan , Andy Gross , Bjorn Andersson , Bjorn Helgaas , Rob Herring , Mark Rutland , Lorenzo Pieralisi , Andrew Murray , Philipp Zabel , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200320183455.21311-1-ansuelsmth@gmail.com> <20200320183455.21311-9-ansuelsmth@gmail.com> From: Stanimir Varbanov Message-ID: <3890fd67-53a3-aa73-af52-4b79c5881dca@mm-sol.com> Date: Wed, 1 Apr 2020 16:21:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200320183455.21311-9-ansuelsmth@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Ansuel, On 3/20/20 8:34 PM, Ansuel Smith wrote: > From: Sham Muthayyan > > Resolved PCIE EP detection errors caused due to missing iATU programming. NACK, the iATU programing is not belonging here. Did you check what pcie-designware-*.c is doing with iATU? If you want to support endpoint mode in pcie-qcom driver you have to see how the other drivers is doing that. > > Signed-off-by: Sham Muthayyan > Signed-off-by: Ansuel Smith > --- > drivers/pci/controller/dwc/pcie-qcom.c | 78 ++++++++++++++++++++++++++ > 1 file changed, 78 insertions(+) > -- regards, Stan